From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id BB8BD236 for ; Tue, 21 Nov 2017 14:30:00 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 6D5FF20B2D; Tue, 21 Nov 2017 08:30:00 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Tue, 21 Nov 2017 08:30:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=Tso+xVUgtcMj8KN39 0zkLyjk2ihCi2/aJBj20n2VzRw=; b=qvzMDSmyKkktY7tR1WyHmmQSQvOBt/l4m eT0OabLqaWYgQzJVGh2oPhPHShkdIgQ599sFU3eY9C5BCzrAqG00W775ZVSm56Zn cvcM/dBkV+UCvnfTN6S58/p0O7cJISq9fODDptBvNhHgdsT+QScrpAFNItRY7DjC hAyzGGor9kV2UMmcCijmKvt/hQ2xBBJxMYUeDG1sjMs+R+VdL6UQPX8CebrazEE7 HkPmv3pDtijObi87gS/a+XKge8G9GMIiBqmNOz7jM021e5LMJfx3e6I9cRvbMd+n aHVuZ/ARNBuYvvg0GHAAdHYyiD594qovA06h+4K9bmrcE86wOjPPQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=Tso+xVUgtcMj8KN390zkLyjk2ihCi2/aJBj20n2VzRw=; b=GVU+KWAd ivW+uTU8/7r6xch0tbAr8v674svZnnhYr9Lgkeus+vJF724z/6nTm5yOyKK6Onz1 TReolbrQJdldWlZdrbSPcqOhBnfxOwy9WdIpTKsdyoJoQONlxnY9nnhACzulEIVx DiwP4y+TeMIEd2MJpXoqjRjXYN8f53HPaFlys5fApz/xnA9L9EBQwYrc9MgjPgIE lKTkFwfDhXZJvSXzfG/fbOpToHBFVBbUMyJLVC4QMxi6qulcC09t2uLHpg498ZS2 CmFN/+ZpjcTAf4CEn1KSOW/kGkQo7WCUdGiDICiT1IgLGaTMuGReaNjyWnwZB8ig vj09z02maDLNjg== X-ME-Sender: Received: from localhost.localdomain (unknown [180.158.62.0]) by mail.messagingengine.com (Postfix) with ESMTPA id 960A1243B9; Tue, 21 Nov 2017 08:29:57 -0500 (EST) From: Yuanhan Liu To: Nikhil Rao Cc: Job Abraham , Bruce Richardson , dpdk stable Date: Tue, 21 Nov 2017 21:18:28 +0800 Message-Id: <1511270333-31002-166-git-send-email-yliu@fridaylinux.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1511270333-31002-1-git-send-email-yliu@fridaylinux.org> References: <1511270333-31002-1-git-send-email-yliu@fridaylinux.org> Subject: [dpdk-stable] patch 'eal/x86: fix atomic cmpset' has been queued to stable release 17.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Nov 2017 13:30:00 -0000 Hi, FYI, your patch has been queued to stable release 17.08.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/24/17. So please shout if anyone has objections. Thanks. --yliu --- >>From 9778ba324d3cee8f14bbc008a43b8df7dfee4392 Mon Sep 17 00:00:00 2001 From: Nikhil Rao Date: Fri, 30 Sep 2016 02:54:53 +0530 Subject: [PATCH] eal/x86: fix atomic cmpset [ upstream commit 9d1c2a6a912bebde1139157b950e39ffa7192c9d ] The original code used movl instead of xchgl, this caused rte_atomic64_cmpset to use ebx as the lower dword of the source to cmpxchg8b instead of the lower dword of function argument "src". Fixes: af75078fece3 ("first public release") Reported-by: Job Abraham Signed-off-by: Nikhil Rao Tested-by: Job Abraham Acked-by: Bruce Richardson --- lib/librte_eal/common/include/arch/x86/rte_atomic_32.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/include/arch/x86/rte_atomic_32.h b/lib/librte_eal/common/include/arch/x86/rte_atomic_32.h index 2e04c75..fb3abf1 100644 --- a/lib/librte_eal/common/include/arch/x86/rte_atomic_32.h +++ b/lib/librte_eal/common/include/arch/x86/rte_atomic_32.h @@ -81,7 +81,7 @@ rte_atomic64_cmpset(volatile uint64_t *dst, uint64_t exp, uint64_t src) : "memory" ); /* no-clobber list */ #else asm volatile ( - "mov %%ebx, %%edi\n" + "xchgl %%ebx, %%edi;\n" MPLOCKED "cmpxchg8b (%[dst]);" "setz %[res];" -- 2.7.4