From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 48E8C235 for ; Tue, 21 Nov 2017 14:20:25 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id F22D220AAF; Tue, 21 Nov 2017 08:20:24 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Tue, 21 Nov 2017 08:20:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=LiuVjMgFAXAK1g7aD n6B8IBDsGsc6wbhATcazbmk9Xc=; b=l88A5IUMe+BnLxleIwYQvAuutDkChxbdD GMZaoNlSOLK1aZmxqe7ldiffuG2W6NPbEb0azDyy68qiuAGSDkOnlQMy7Nli53ae lKk3tByHr64blqcxlJrNu7gk4F1YGUzk2xwwIab/hKpBEoVHtqU4uU5jRAut3T+8 OAXLN1XwQ6mF7uQqA5qMow9MF93JNpCXsPlxGGacF88t1IqIPQSkX5lnP4IMHw4s dyjq6dPeaw+kQLWBsv2n0qjGm9vjComudcIvm3v1JNqs7gwZFycipsCTvYLc1kqB AbkphIA36pnlTng8SsPOrtnRwTw9Cq3HkUhB6ismd6AryXRdhjtdg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=LiuVjMgFAXAK1g7aDn6B8IBDsGsc6wbhATcazbmk9Xc=; b=Izk7dVQw dhlw/UjuYbDM04uTdvXEZviQgMxzQwRV2krUTSpy1LMkhm6kYHqoTA9ja62gHTlE VDFp2eTfdB8r+Y6OUT1xLuZv5ERjjzO7RKOM5QhNGaU5ffG0kbWRuTe67UuDaihb hx1xyej/zRIgbR7xKiWdNWzqEBsRlBfAjXTJDiccTOZB1kRZ6OTCDurF3rN9yih6 ZtYfsGxOWddNyjrnwLDMZow2kltuPRyf8KzHJWbJiWmAIF6kBrllh75vyZ+ar5Im 0qFXOvk70MZbWUqXKPZE2HYMWrVHaS6c2+U1lSn86zgL3ujb1SDqJBz4MlNMstzr oh+dh9Ou0v4YJA== X-ME-Sender: Received: from localhost.localdomain (unknown [180.158.62.0]) by mail.messagingengine.com (Postfix) with ESMTPA id 85952243B9; Tue, 21 Nov 2017 08:20:22 -0500 (EST) From: Yuanhan Liu To: RongQiang Xie Cc: Harish Patil , dpdk stable Date: Tue, 21 Nov 2017 21:15:59 +0800 Message-Id: <1511270333-31002-17-git-send-email-yliu@fridaylinux.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1511270333-31002-1-git-send-email-yliu@fridaylinux.org> References: <1511270333-31002-1-git-send-email-yliu@fridaylinux.org> Subject: [dpdk-stable] patch 'net/qede: fix possible null pointer dereference' has been queued to stable release 17.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Nov 2017 13:20:25 -0000 Hi, FYI, your patch has been queued to stable release 17.08.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/24/17. So please shout if anyone has objections. Thanks. --yliu --- >>From f869c214e03d7ba2d3216179e6220efb86316c80 Mon Sep 17 00:00:00 2001 From: RongQiang Xie Date: Thu, 24 Aug 2017 15:12:33 +0800 Subject: [PATCH] net/qede: fix possible null pointer dereference [ upstream commit ef86e67ad5d873573882e19d92a206a842d22927 ] In function qede_rss_reta_update(), the pointer params returned from call to function rte_zmalloc() may be NULL and will be dereferenced. So, should judge if the params is NULL or not. Fixes: 8b3ee85efe11 ("net/qede: fix RSS table entries for 100G adapter") Signed-off-by: RongQiang Xie Acked-by: Harish Patil --- drivers/net/qede/qede_ethdev.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c index 0e05989..4e9e89f 100644 --- a/drivers/net/qede/qede_ethdev.c +++ b/drivers/net/qede/qede_ethdev.c @@ -2012,6 +2012,10 @@ int qede_rss_reta_update(struct rte_eth_dev *eth_dev, memset(&vport_update_params, 0, sizeof(vport_update_params)); params = rte_zmalloc("qede_rss", sizeof(*params) * edev->num_hwfns, RTE_CACHE_LINE_SIZE); + if (params == NULL) { + DP_ERR(edev, "failed to allocate memory\n"); + return -ENOMEM; + } for (i = 0; i < reta_size; i++) { idx = i / RTE_RETA_GROUP_SIZE; -- 2.7.4