From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 8692D23B for ; Tue, 21 Nov 2017 14:30:14 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 2928D2086A; Tue, 21 Nov 2017 08:30:14 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Tue, 21 Nov 2017 08:30:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=E2ujCbtFNbKsQctKw 4eCrzisR8CpbdMr47CfavZY3Wc=; b=Yp0qsO4uE99u8RGEy0FUn9UxQlaxrFwct YN9qq+G5LEb0NnsnFFPeMhpr1Wuoc/4mUVRmcMQU1/G2UITQDoC+9/43UxjEIYFj mp7p1bm38zCT72UepBFL/izl6zlkAuylhia78Ez8vxjzpjwp+JbnxLNiL72x4X0A 2hTgOFZfnck4WpDFYJ9jHi8dZZdDA7i4Rh/4HhgAcsZ0wFc4uTb9gkZROCZMJG8T ZYeiR6WXgAARwtZTvfe/6EFdA548NHbpuylVd1ABc8e/SSuB/+qGt5Q/gEf0rZI1 I1T4EfaLxVAdK5hG7r4OxDUHP9/CiLHosVyomrThpdUmMNdTI1p6Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=E2ujCbtFNbKsQctKw4eCrzisR8CpbdMr47CfavZY3Wc=; b=r/ElAe7z xcBtLMVyP6vQsK0xbch9gHRocjErtaI0QULAd6nPRkRFZ2w7395ZWTpPJirnWBOh TrvONT+PBlr5d2QtdmMxjOqSaD7ROU6rTd1Ifx2XbHEYpOhblK/5F4322a/+voLh zxwcCDlxVfULYRUHhgBj4inLcKByBznmLO1Ft6MlAidyxuoCcpbyXg4PrU57Wx5V 8BDBfpVH3WQliX1ehIWtvby72hPls7mf+bu1w/JAJHhN9/qkjTnWs/g0CqooLKUU tefrlCLcYIlgTgowliurzAhjMdO1iK+4wpbd9TkEJuPHCjyB4q4fMyJJTKfvWmPQ BAENbuOz/u+kuw== X-ME-Sender: Received: from localhost.localdomain (unknown [180.158.62.0]) by mail.messagingengine.com (Postfix) with ESMTPA id 22B1224CCE; Tue, 21 Nov 2017 08:30:11 -0500 (EST) From: Yuanhan Liu To: Ajit Khaparde Cc: dpdk stable Date: Tue, 21 Nov 2017 21:18:32 +0800 Message-Id: <1511270333-31002-170-git-send-email-yliu@fridaylinux.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1511270333-31002-1-git-send-email-yliu@fridaylinux.org> References: <1511270333-31002-1-git-send-email-yliu@fridaylinux.org> Subject: [dpdk-stable] patch 'net/bnxt: do not set hash type unnecessarily' has been queued to stable release 17.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Nov 2017 13:30:14 -0000 Hi, FYI, your patch has been queued to stable release 17.08.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/24/17. So please shout if anyone has objections. Thanks. --yliu --- >>From d3320ab971a0959dc63ec44ad4cb5d2a5f595ce1 Mon Sep 17 00:00:00 2001 From: Ajit Khaparde Date: Thu, 26 Oct 2017 21:30:24 -0500 Subject: [PATCH] net/bnxt: do not set hash type unnecessarily [ upstream commit 652380382175cd64841b578d2a3d449d8105511c ] We are wrongly "OR-ing" the vnic->hash_type instead of assigning the new hash type thereby wrongly configuring hash settings. Fixing it. Fixes: fcc0aa1edc10 ("net/bnxt: add RSS hash configuration") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_rxq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_rxq.c b/drivers/net/bnxt/bnxt_rxq.c index 6715fbd..969b433 100644 --- a/drivers/net/bnxt/bnxt_rxq.c +++ b/drivers/net/bnxt/bnxt_rxq.c @@ -206,7 +206,7 @@ out: for (i = 0; i < bp->nr_vnics; i++) { STAILQ_FOREACH(vnic, &bp->ff_pool[i], next) { - vnic->hash_type |= hash_type; + vnic->hash_type = hash_type; /* * Use the supplied key if the key length is -- 2.7.4