From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 4C51BF94 for ; Tue, 21 Nov 2017 14:31:08 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id F12BB20696; Tue, 21 Nov 2017 08:31:07 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Tue, 21 Nov 2017 08:31:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=dm7h/ABTB2u2UOHAS +TTAZQp1/s7j8DhGo5oOUPepWw=; b=qS5kbF5HCiHYWYYeKbgHC6jOiAeX5abgz UL/asHFW2XsVrDQ3/0rKFtGhGe8aRDoVN6CjBdHUC9qPpJtLflSf9cL26nwAAODg 1f/MXFSTg/J6UdyxYy+QHdd1j5xay5c3+2ij3g/TscvqlvMLWSzn8sqjOrlXjbWy STIqo4TpLsfuX7GRCNFpiyJnUJbEhpqc59d/MssTVWhe9J7i5Z1BFQIsLFeu9utE 5Bp4zCmHO3tEO8QxpNrPJkv0os9xq3tYlxsUzbw1gYbrzYrsv0g5wcfxZkHFrUT4 vNxcLeQPPKYgvyWBbPFXIece2GWPLwM+d89jRE4Ip07YIz9Qe3YWg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=dm7h/ABTB2u2UOHAS+TTAZQp1/s7j8DhGo5oOUPepWw=; b=maa1lwiO uD/50KZsF2/ZUsA3QMCCkiFu3Z5l8tM3uWWr0m6cJaIYwqe8vNEeDV0naB0NTjcS Z89O98wZmdu8GfcYZoBDxJHlcSrJN37Kk+Om+JLPU1175AYfQq0CeIxHZaQJk7KW 8Ojqg9ExjLFoeVzkk++7/FsRwlEWCqhd8S7JwopdDXqNU8yn4y0OelHHQgO2ksPZ g6OjzpkTRlm9iAw+Z9Fd/EEaZ4qlt9uaMd/Pxy1h6x4nHp8iXuD8DbwHUD3RRUJd 3nnmH9wELq12LQ46D5ojm63fR2yjBnS2nvV0Cj1QjRF6hJOvsWdtZmmNf4TKL/y2 ZmB+n5Z4h03ygg== X-ME-Sender: Received: from localhost.localdomain (unknown [180.158.62.0]) by mail.messagingengine.com (Postfix) with ESMTPA id 67979248B4; Tue, 21 Nov 2017 08:31:03 -0500 (EST) From: Yuanhan Liu To: Guduri Prathyusha Cc: Jerin Jacob , Jianbo Liu , dpdk stable Date: Tue, 21 Nov 2017 21:18:44 +0800 Message-Id: <1511270333-31002-182-git-send-email-yliu@fridaylinux.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1511270333-31002-1-git-send-email-yliu@fridaylinux.org> References: <1511270333-31002-1-git-send-email-yliu@fridaylinux.org> Subject: [dpdk-stable] patch 'examples/l3fwd: fix aliasing in port grouping' has been queued to stable release 17.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Nov 2017 13:31:08 -0000 Hi, FYI, your patch has been queued to stable release 17.08.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/24/17. So please shout if anyone has objections. Thanks. --yliu --- >>From c592d2de222f21cbed30470654d855ee8bfeb115 Mon Sep 17 00:00:00 2001 From: Guduri Prathyusha Date: Fri, 3 Nov 2017 16:13:51 +0530 Subject: [PATCH] examples/l3fwd: fix aliasing in port grouping [ upstream commit 01ac23460c36927e019473e71b582223ad6b79c5 ] With -f-strict-aliasing enabled by default from -O2, gcc > 5.x gives undefined behavior in port_groupx4 in ARM. 'pn' and 'pnum' are two different pointers pointing to same chunk of memory and with -f-strict-aliasing the pointers are assumed to be pointing to different memory and compiler reorders instructions that depend on pnum and pn. This breaks port grouping algorithm. This patch eliminates the above problem by introducing a compiler barrier between the instructions that depend on pnum, pn and lp. Fixes: 569b290cdb36 ("examples/l3fwd: add NEON implementation") Signed-off-by: Guduri Prathyusha Acked-by: Jerin Jacob Acked-by: Jianbo Liu --- examples/l3fwd/l3fwd_neon.h | 1 + 1 file changed, 1 insertion(+) diff --git a/examples/l3fwd/l3fwd_neon.h b/examples/l3fwd/l3fwd_neon.h index 4bc1613..b319b5a 100644 --- a/examples/l3fwd/l3fwd_neon.h +++ b/examples/l3fwd/l3fwd_neon.h @@ -114,6 +114,7 @@ port_groupx4(uint16_t pn[FWDSTEP + 1], uint16_t *lp, uint16x8_t dp1, /* update last port counter. */ lp[0] += gptbl[v].lpv; + rte_compiler_barrier(); /* if dest port value has changed. */ if (v != GRPMSK) { -- 2.7.4