From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 6618AF1F for ; Tue, 21 Nov 2017 14:31:23 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 1AA0F20B68; Tue, 21 Nov 2017 08:31:23 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Tue, 21 Nov 2017 08:31:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=En+IXUT2Om7h97lAP H87VVFvi8UF8UOtcx8a3qA/6s0=; b=kqX4EOvf67ugn/btHvG64eeTpl640ix+O ogIqHmrwnTT5q2YmldR5VZIJfQ1V3tPIINc/C9GYoJli0+zwchi408SiWGXgPGnO I5hV4ZA29/gPTZLChClqePR1lbwbfJJF8SWJQD6jGtf6CeZ9IPpHQ9QneIeBWoTo GiM+pFfzuqSS/39P4FjTu/yMBiDlmg5FjnCZ67C1NMXIYHrwa87JzQOuPmDWz+5v HePT3PSDdh/oqB/xbWCEqBYLVBynGTYW2Gkkt8K6JLcRWsnA6lvMmMi/tXUOX9H3 WozuI4Up6mILEnkFxJFqIMyhGB8XkYmr2yML7G5XkUj40JF5wotxQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=En+IXUT2Om7h97lAPH87VVFvi8UF8UOtcx8a3qA/6s0=; b=k6ruiQqS vbgnSP2l5hsCmDmzSumbZesLfvY5UrL8rFAdnTwGldd+9RhFv5ZjLKHNDfRzmdyZ J8g4D9hboYr1X2a5H8ZHvNQFjE1gXBP24Y3dlSUQpC1e111ohvSIdlQOtKSCnbIk HqUarLXy94+wDipYtmYhtqhub/pGbwKj5ByeyNTg6gHaiy0fg1aJQEwPT2vz53Nw mJ/R8gbB6/GezYB2yRkNT93KuaOK0qqpUESbOErCKMQx1mGzfnUNYqM1d0XLUERf ZkT9DpBA5+KWoLaMl6D104E1jzAjwGViPcMN/DDniOqBk4hfSEGB0f/nCbxJjLcy 48yXyjs6M/kX/A== X-ME-Sender: Received: from localhost.localdomain (unknown [180.158.62.0]) by mail.messagingengine.com (Postfix) with ESMTPA id 812A324810; Tue, 21 Nov 2017 08:31:17 -0500 (EST) From: Yuanhan Liu To: Ophir Munk Cc: Raslan Darawsheh , Pablo de Lara , dpdk stable Date: Tue, 21 Nov 2017 21:18:48 +0800 Message-Id: <1511270333-31002-186-git-send-email-yliu@fridaylinux.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1511270333-31002-1-git-send-email-yliu@fridaylinux.org> References: <1511270333-31002-1-git-send-email-yliu@fridaylinux.org> Subject: [dpdk-stable] patch 'app/testpmd: fix forwarding between non consecutive ports' has been queued to stable release 17.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Nov 2017 13:31:23 -0000 Hi, FYI, your patch has been queued to stable release 17.08.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/24/17. So please shout if anyone has objections. Thanks. --yliu --- >>From ef9e21d051e711c34e795e0f0d632c31a70630a4 Mon Sep 17 00:00:00 2001 From: Ophir Munk Date: Tue, 7 Nov 2017 13:52:30 +0000 Subject: [PATCH] app/testpmd: fix forwarding between non consecutive ports [ upstream commit fafee5e9caaf439b29a6e10600e91b8de81eff66 ] When defining two failsafe devices in testpmd the port numbers of the failsafe devices may not be consecutive. For example: if failsafe device includes a PCI device and a TAP device then failsafe port numbers would be 0 and 3. Port 0 - failsafe #1 device Port 1 - PCI #1 device Port 2 - TAP #1 device Port 3 - failsafe #2 device Port 4 - PCI #2 device Port 5 - TAP #2 device If forwarding is defined between the failsafe devices including a peer address the forwarding should be between peer addresses of ports 0 and 3. Instead testpmd establishes forwarding between peer addresses of consecutive ports 0 and 1. This commit fixes this bug. Fixes: af75078fece3 ("first public release") Signed-off-by: Ophir Munk Signed-off-by: Raslan Darawsheh Acked-by: Pablo de Lara --- app/test-pmd/config.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index ae4d793..af78d7a 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -1885,7 +1885,7 @@ simple_fwd_config_setup(void) fwd_streams[i]->rx_queue = 0; fwd_streams[i]->tx_port = fwd_ports_ids[j]; fwd_streams[i]->tx_queue = 0; - fwd_streams[i]->peer_addr = j; + fwd_streams[i]->peer_addr = fwd_streams[i]->tx_port; fwd_streams[i]->retry_enabled = retry_enabled; if (port_topology == PORT_TOPOLOGY_PAIRED) { @@ -1893,7 +1893,7 @@ simple_fwd_config_setup(void) fwd_streams[j]->rx_queue = 0; fwd_streams[j]->tx_port = fwd_ports_ids[i]; fwd_streams[j]->tx_queue = 0; - fwd_streams[j]->peer_addr = i; + fwd_streams[j]->peer_addr = fwd_streams[j]->tx_port; fwd_streams[j]->retry_enabled = retry_enabled; } } -- 2.7.4