From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id C1CF6239 for ; Tue, 21 Nov 2017 14:20:38 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 75F8820B94; Tue, 21 Nov 2017 08:20:38 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Tue, 21 Nov 2017 08:20:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=SvqegUNCwPAx3SHVZ GZUuQP6M6QrX/KT0P5SjzZBkGM=; b=kGeSZeVAek9c3bH4lVRY9sI/816X7DlvK kmQIDQs//Er1+Sh3ut+dtP0eKWiiqlLMSuaw6tUWGQDpBib1NGxFX444/ikn17rW 50qVd/UWRR0PqPN1MdFj6bVDZObqorlCf01Mt0RfESgcMpqRaj6X3tXhRJBeTBkH 5YREEMeWuF37nthOgJVQat9IOdEwKUVSxOkfWPiXHKkuD8Jx98PTwAfhgK/rNVPV okfiQs/nNX4Rxu6WEfIAr0A5HXydNSFSD3/LLCvdbjxB+keRSTW81GbeMTpvnEos RuUc9lqH0FKZlvMH3/p2vCqil4Gjt4SiCdqE/wyEb4yt3LDAqIBqw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=SvqegUNCwPAx3SHVZGZUuQP6M6QrX/KT0P5SjzZBkGM=; b=bDD+tPEW 9RvJS5Dr6EXvqVD9C7G8nL9ov6hp5I38YdZWSPAlY5Y54J/ryPzd2Z34XBjNGEv1 vvLWoNDZXxDz8cIXBdu8F/CGU0OonaA55LO3X2dou+DUsgYek4VyzMFU+LFegocL 2iEMactF4An0URwm/m0VvbVIUXDKw9tshnRPtk4ON5DDcK0d7HfHTYjjAEZspkDX y0Pp8WZ7p6MTZdHEyKk4FoP605dTb6tF4KVFaRzlYTwS4TcGSb2Z2seMegPBearJ svxuKUPkZ+V813XzXrkb+mbrYInjPklZi76ZEKn6shEP9Nd2PnsLY7IBqyUWwSL4 2vRFY4n5vTlmDg== X-ME-Sender: Received: from localhost.localdomain (unknown [180.158.62.0]) by mail.messagingengine.com (Postfix) with ESMTPA id 3C79B248B4; Tue, 21 Nov 2017 08:20:34 -0500 (EST) From: Yuanhan Liu To: Raslan Darawsheh Cc: Gaetan Rivet , dpdk stable Date: Tue, 21 Nov 2017 21:16:02 +0800 Message-Id: <1511270333-31002-20-git-send-email-yliu@fridaylinux.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1511270333-31002-1-git-send-email-yliu@fridaylinux.org> References: <1511270333-31002-1-git-send-email-yliu@fridaylinux.org> Subject: [dpdk-stable] patch 'net/failsafe: fix failsafe bus uninit return value' has been queued to stable release 17.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Nov 2017 13:20:39 -0000 Hi, FYI, your patch has been queued to stable release 17.08.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/24/17. So please shout if anyone has objections. Thanks. --yliu --- >>From 435e52a3c92028b4c3a8960a52e49fb97e58bdd5 Mon Sep 17 00:00:00 2001 From: Raslan Darawsheh Date: Tue, 29 Aug 2017 12:08:08 +0300 Subject: [PATCH] net/failsafe: fix failsafe bus uninit return value [ upstream commit 6969a22bf6ee18d8f34990688194aef4bad3a19c ] fs_bus_uninit is always returning 0 no matter what was the status of each sub device bus_uninit value. Fixes: a46f8d584eb8 ("net/failsafe: add fail-safe PMD") Signed-off-by: Raslan Darawsheh Acked-by: Gaetan Rivet --- drivers/net/failsafe/failsafe_eal.c | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/net/failsafe/failsafe_eal.c b/drivers/net/failsafe/failsafe_eal.c index c8f4318..aeb87a0 100644 --- a/drivers/net/failsafe/failsafe_eal.c +++ b/drivers/net/failsafe/failsafe_eal.c @@ -90,19 +90,20 @@ fs_bus_uninit(struct rte_eth_dev *dev) { struct sub_device *sdev = NULL; uint8_t i; - int ret; + int sdev_ret; + int ret = 0; FOREACH_SUBDEV_STATE(sdev, i, dev, DEV_PROBED) { - ret = rte_eal_hotplug_remove(sdev->bus->name, - sdev->dev->name); - if (ret) { - ERROR("Failed to remove requested device %s", - sdev->dev->name); + sdev_ret = rte_eal_hotplug_remove(sdev->bus->name, + sdev->dev->name); + if (sdev_ret) { + ERROR("Failed to remove requested device %s (err: %d)", + sdev->dev->name, sdev_ret); continue; } sdev->state = DEV_PROBED - 1; } - return 0; + return ret; } int @@ -111,8 +112,6 @@ failsafe_eal_uninit(struct rte_eth_dev *dev) int ret; ret = fs_bus_uninit(dev); - if (ret) - return ret; PRIV(dev)->state = DEV_PROBED - 1; - return 0; + return ret; } -- 2.7.4