From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 9251123B for ; Tue, 21 Nov 2017 14:21:17 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 4732320B19; Tue, 21 Nov 2017 08:21:17 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Tue, 21 Nov 2017 08:21:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=G2zXZ7SWCL0ahHXTL dIhI8Gcx7B7O8GrmfcvfEN4xzs=; b=BOZeNpODzbleHo2WnpZJAshK2wCGNXAZg XygLNzb1cUuWCjndmXFFGvUl9S1NN8751iE8VokGjkTflhvOKzjEYlCyWse79JDf SeIb16mWZXNWr0lKO/YWHn5D6a0KM6co+GwF03eUe4GeyUY6LDuqxaX7hRa6mqoK WD0zHqs9BeP3aedLwSUxqrqRZdV8DcAW6OnDkWWYhR9RJlYSZ1eNE2xBlVhfTQH+ cLcmdmGL0ZmC46HrK7uXJCQZfA4zYckX6WCWGcro0iURyQaQQ0Q3PLSd1gKujh8+ ocG2YROh8gk62eEP6I4Dx8k28ESgjPgLLG8wUFabkAoN7vgIr+pTQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=G2zXZ7SWCL0ahHXTLdIhI8Gcx7B7O8GrmfcvfEN4xzs=; b=cNWwRRiD kiKRthN0woKS9WXeRV2BMIXif+zQ9bcUMvJ5lWS2yvIdrVwtlpBJfYQ0TIdFpWJU tX3tPmam6GKKyhXtNGQSyspljsTzeryWDWW+ZIVJfMTSaixzhfqL+TtzkGk2qouO QguqkpEbEuIL2zZ4zqbFe6wEFbKEE9HAxVhtIIT42hW8cFfDLnvuM0nZ834pd055 avC3LsPm1cgdGOhlIPOfnUDtAusZZTMiyrmLrDFyJ1q1vizteunjMsFkcw8fg2/V Q6LHelQ2X3QgStdIRqvLBvHP/msHDiKrydZPtb+6tN/gmGSvtmb0nuMikHIJuZ2P 9pK6prRmd6Ux1A== X-ME-Sender: Received: from localhost.localdomain (unknown [180.158.62.0]) by mail.messagingengine.com (Postfix) with ESMTPA id E0B35243B9; Tue, 21 Nov 2017 08:21:14 -0500 (EST) From: Yuanhan Liu To: Congwen Zhang Cc: Rahul Lakkireddy , dpdk stable Date: Tue, 21 Nov 2017 21:16:12 +0800 Message-Id: <1511270333-31002-30-git-send-email-yliu@fridaylinux.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1511270333-31002-1-git-send-email-yliu@fridaylinux.org> References: <1511270333-31002-1-git-send-email-yliu@fridaylinux.org> Subject: [dpdk-stable] patch 'net/cxgbe: fix memory leak' has been queued to stable release 17.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Nov 2017 13:21:17 -0000 Hi, FYI, your patch has been queued to stable release 17.08.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/24/17. So please shout if anyone has objections. Thanks. --yliu --- >>From c8491b82764fc171e8f54f27e0f4b55cfe5f8233 Mon Sep 17 00:00:00 2001 From: Congwen Zhang Date: Tue, 5 Sep 2017 16:46:57 +0800 Subject: [PATCH] net/cxgbe: fix memory leak [ upstream commit c0b865d4717d85138f716d42ca186672b060f166 ] In function t4_wr_mbox_meat_timeout(), dynamic memory stored in 'temp' variable and it is not freed when the function return, this is a possible memory leak. Fixes: 3bd122eef2cc ("cxgbe/base: add hardware API for Chelsio T5 series adapters") Signed-off-by: Congwen Zhang Acked-by: Rahul Lakkireddy --- drivers/net/cxgbe/base/t4_hw.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/cxgbe/base/t4_hw.c b/drivers/net/cxgbe/base/t4_hw.c index a8ccea0..013d996 100644 --- a/drivers/net/cxgbe/base/t4_hw.c +++ b/drivers/net/cxgbe/base/t4_hw.c @@ -403,6 +403,7 @@ int t4_wr_mbox_meat_timeout(struct adapter *adap, int mbox, t4_os_atomic_list_del(&entry, &adap->mbox_list, &adap->mbox_lock); t4_report_fw_error(adap); + free(temp); return (pcie_fw & F_PCIE_FW_ERR) ? -ENXIO : -EBUSY; } @@ -446,6 +447,7 @@ int t4_wr_mbox_meat_timeout(struct adapter *adap, int mbox, &adap->mbox_list, &adap->mbox_lock)); t4_report_fw_error(adap); + free(temp); return (v == X_MBOWNER_FW ? -EBUSY : -ETIMEDOUT); } @@ -546,6 +548,7 @@ int t4_wr_mbox_meat_timeout(struct adapter *adap, int mbox, T4_OS_MBOX_LOCKING( t4_os_atomic_list_del(&entry, &adap->mbox_list, &adap->mbox_lock)); + free(temp); return -G_FW_CMD_RETVAL((int)res); } } -- 2.7.4