From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id EBD4C237 for ; Tue, 21 Nov 2017 14:21:48 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 9591E20B1F; Tue, 21 Nov 2017 08:21:48 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Tue, 21 Nov 2017 08:21:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=D793oosaA15oyRG1f eXF8svpdDxAey8dZIsIhPfUHLo=; b=ghR2jEJn5X9R/TdgtYFtsjw0ab7dG3ZE0 H/NbCGZo98eO9fEdkQ4HvyaFNRwgBVYvClnpr5ohluJG02QBfAvoA7WAGDRJnKFR R/iRemFxXg/QsmMyD0iHjFX0L6QCGbELuQh3Qd+Kmhxr20H4HnM+OX4Zkge08Io+ NDYD9v+bFfpJgY9BNNYjPiha7rgWAhl3FxCi2aR5eBAWYV+NJ9VII816kskCHo3C HoASXFFSqWlCVRsMggwmUYwHiTEGTrSN5uoEdkuHYQkDIPPeNfEYjO8UKircZcVq 9pcMVdGHT42Rtjod+1BvrwZBmIPh8QzpMysNiO5v97YXu89lhq5FQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=D793oosaA15oyRG1feXF8svpdDxAey8dZIsIhPfUHLo=; b=R/rJ4aPw w+bpzBSqTJcuQ0I0qxbBzVSDRL1gZQHjlSvekcZFKzfuTHagkWTkCTAf6Xp+xnky 1cIedpRjGVUTvyWZDnmE6IHBiba8egbGbqEjvqFgEoWTQLhSmF8rqbApaLY6d7cg XU0UlR0oX5wOcM+X1OJBv7e9Wq9ELLSyRbktsigxeq1TAO/rtBlfzvGcjSB9MdUl k1le+cpwe8vI8lBREuwQNSdiVWSCbmrZbgVpkDq6wi57A09dP5nACMjqQBxeWRbA e3tonvx9ybcrGRm8+dfzxRawuGUM6D6GRYU094PbvpCr0McZJFjOTzchuLofgf1w bScXpbOrfrOorA== X-ME-Sender: Received: from localhost.localdomain (unknown [180.158.62.0]) by mail.messagingengine.com (Postfix) with ESMTPA id 61CE324631; Tue, 21 Nov 2017 08:21:43 -0500 (EST) From: Yuanhan Liu To: Shahaf Shuler Cc: Yongseok Koh , Nelio Laranjeiro , dpdk stable Date: Tue, 21 Nov 2017 21:16:19 +0800 Message-Id: <1511270333-31002-37-git-send-email-yliu@fridaylinux.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1511270333-31002-1-git-send-email-yliu@fridaylinux.org> References: <1511270333-31002-1-git-send-email-yliu@fridaylinux.org> Subject: [dpdk-stable] patch 'net/mlx5: fix Tx stats error counter definition' has been queued to stable release 17.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Nov 2017 13:21:49 -0000 Hi, FYI, your patch has been queued to stable release 17.08.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/24/17. So please shout if anyone has objections. Thanks. --yliu --- >>From c598434e626b9511491191c5210f98ad2f3b0f1a Mon Sep 17 00:00:00 2001 From: Shahaf Shuler Date: Thu, 14 Sep 2017 13:50:37 +0300 Subject: [PATCH] net/mlx5: fix Tx stats error counter definition [ upstream commit 9f9a48eb2978157954242e08acf81d7a26f38810 ] The current Tx error counter counts, according to its description, the total number of packets not sent when TX ring full. It is reported to application as part of oerrors field. The drop due to full ring is not the statistic that should be set on oerrors field. Such number can be counted by the application using the return value of the Tx burst function. The number that should be set there is the number of packets the device could not transmit in any way, even when it has resources. Therefore, replace this counter to count the total number of failed transmitted packets. Fixes: 87011737b715 ("mlx5: add software counters") Signed-off-by: Shahaf Shuler Acked-by: Yongseok Koh Acked-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_rxtx.h | 2 +- drivers/net/mlx5/mlx5_stats.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/mlx5/mlx5_rxtx.h b/drivers/net/mlx5/mlx5_rxtx.h index 7de1d10..0d65748 100644 --- a/drivers/net/mlx5/mlx5_rxtx.h +++ b/drivers/net/mlx5/mlx5_rxtx.h @@ -81,7 +81,7 @@ struct mlx5_txq_stats { uint64_t opackets; /**< Total of successfully sent packets. */ uint64_t obytes; /**< Total of successfully sent bytes. */ #endif - uint64_t odropped; /**< Total of packets not sent when TX ring full. */ + uint64_t oerrors; /**< Total number of failed transmitted packets. */ }; /* Flow director queue structure. */ diff --git a/drivers/net/mlx5/mlx5_stats.c b/drivers/net/mlx5/mlx5_stats.c index 33997af..671c5d0 100644 --- a/drivers/net/mlx5/mlx5_stats.c +++ b/drivers/net/mlx5/mlx5_stats.c @@ -367,13 +367,13 @@ mlx5_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) tmp.q_opackets[idx] += txq->stats.opackets; tmp.q_obytes[idx] += txq->stats.obytes; #endif - tmp.q_errors[idx] += txq->stats.odropped; + tmp.q_errors[idx] += txq->stats.oerrors; } #ifdef MLX5_PMD_SOFT_COUNTERS tmp.opackets += txq->stats.opackets; tmp.obytes += txq->stats.obytes; #endif - tmp.oerrors += txq->stats.odropped; + tmp.oerrors += txq->stats.oerrors; } #ifndef MLX5_PMD_SOFT_COUNTERS /* FIXME: retrieve and add hardware counters. */ -- 2.7.4