From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 2E7CB237 for ; Tue, 21 Nov 2017 14:21:53 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id D58F720914; Tue, 21 Nov 2017 08:21:52 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Tue, 21 Nov 2017 08:21:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=mO0MuemYVUZCPDtwH t2OS9rN5sg/Oauz+W1+jpU0cNU=; b=NhlboL/h/rUVodIfQ6BI65Rjaa1I/kfwt vyRYc6lGzD9So8PILuA7keY1+S4hHglO9KaXfu2naRT1VxmNNfu9/A2cwpBVIDkb +WlWc51D3bLvNM9aIanWQXbPW1sY4DB7G2nbKwy3Asf3UYiP+izSZ3MI8/G0O05O rBdQpqKX75+ZPeXsiOLmfd0yRDgDco61KoaLsWBseSPZlK7V+lqZNmBUGU77zhaM Y/UKEbayIh6VnNqktXmuZtzKPOtjyxq01oxEr7GJ4gMBrqvzezjCu8RFm19ArFM7 5rihu6VSY3W0bT0s/sEnr/WHl2MCQWSP2jPWctwmh8xKox+Or2x6Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=mO0MuemYVUZCPDtwHt2OS9rN5sg/Oauz+W1+jpU0cNU=; b=lZvldMn/ KMZYTMq5FroFcSJc19dvy2CGWfGoKLGoXxMb0RT1SfOtzkyCel7AoyqggBmMHvHg JC/gUC1RFIsISKoNPFmJb0j3RH7jYb1l+QNHwdaTNefneY7UsrL3tDyOoUhXtb65 qktWLkgW5/nkG3SW+b+OzEMyzeuMq2Uwmgf/bYABZExVSM641pR0kjMgHMhnrZa7 txq0U/j9jC5c3Dwt7bmkKu9cAPh+J2U7mqh6b5oS79f03eYoJZoPxYyMbzPy9+JW E6tS6Rr5RohpgkKBDCwl4nLkdkyef37cc4Qh+CF+ceUolnPo/IcafATuVfffaP/f bOhWzUGq5Ukh/A== X-ME-Sender: Received: from localhost.localdomain (unknown [180.158.62.0]) by mail.messagingengine.com (Postfix) with ESMTPA id F2B0C243B9; Tue, 21 Nov 2017 08:21:49 -0500 (EST) From: Yuanhan Liu To: Shahaf Shuler Cc: Yongseok Koh , Nelio Laranjeiro , dpdk stable Date: Tue, 21 Nov 2017 21:16:20 +0800 Message-Id: <1511270333-31002-38-git-send-email-yliu@fridaylinux.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1511270333-31002-1-git-send-email-yliu@fridaylinux.org> References: <1511270333-31002-1-git-send-email-yliu@fridaylinux.org> Subject: [dpdk-stable] patch 'net/mlx5: fix Tx stats error counter logic' has been queued to stable release 17.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Nov 2017 13:21:53 -0000 Hi, FYI, your patch has been queued to stable release 17.08.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/24/17. So please shout if anyone has objections. Thanks. --yliu --- >>From e67f972d9790d4f1e958d00ad62f9ee070f38913 Mon Sep 17 00:00:00 2001 From: Shahaf Shuler Date: Thu, 14 Sep 2017 13:50:38 +0300 Subject: [PATCH] net/mlx5: fix Tx stats error counter logic [ upstream commit 24c14430cdc4556a30a1e608f67230e881718f7f ] Tx error counter lacks the logic of incrementation, making it useless for applications. Fixes: 87011737b715 ("mlx5: add software counters") Signed-off-by: Shahaf Shuler Acked-by: Yongseok Koh Acked-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_rxtx.c | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c index d3d61c8..ef80682 100644 --- a/drivers/net/mlx5/mlx5_rxtx.c +++ b/drivers/net/mlx5/mlx5_rxtx.c @@ -413,8 +413,10 @@ mlx5_tx_burst(void *dpdk_txq, struct rte_mbuf **pkts, uint16_t pkts_n) #ifdef MLX5_PMD_SOFT_COUNTERS total_length = length; #endif - if (length < (MLX5_WQE_DWORD_SIZE + 2)) + if (length < (MLX5_WQE_DWORD_SIZE + 2)) { + txq->stats.oerrors++; break; + } /* Update element. */ (*txq->elts)[elts_head & elts_m] = buf; /* Prefetch next buffer data. */ @@ -489,8 +491,10 @@ mlx5_tx_burst(void *dpdk_txq, struct rte_mbuf **pkts, uint16_t pkts_n) cs_flags |= MLX5_ETH_WQE_L4_CSUM; } if (unlikely(tso_header_sz > - MLX5_MAX_TSO_HEADER)) + MLX5_MAX_TSO_HEADER)) { + txq->stats.oerrors++; break; + } copy_b = tso_header_sz - pkt_inline_sz; /* First seg must contain all headers. */ assert(copy_b <= length); @@ -843,8 +847,10 @@ mlx5_tx_burst_mpw(void *dpdk_txq, struct rte_mbuf **pkts, uint16_t pkts_n) if (max_elts < segs_n) break; /* Do not bother with large packets MPW cannot handle. */ - if (segs_n > MLX5_MPW_DSEG_MAX) + if (segs_n > MLX5_MPW_DSEG_MAX) { + txq->stats.oerrors++; break; + } max_elts -= segs_n; --pkts_n; /* Should we enable HW CKSUM offload */ @@ -1064,8 +1070,10 @@ mlx5_tx_burst_mpw_inline(void *dpdk_txq, struct rte_mbuf **pkts, if (max_elts < segs_n) break; /* Do not bother with large packets MPW cannot handle. */ - if (segs_n > MLX5_MPW_DSEG_MAX) + if (segs_n > MLX5_MPW_DSEG_MAX) { + txq->stats.oerrors++; break; + } max_elts -= segs_n; --pkts_n; /* @@ -1353,8 +1361,10 @@ mlx5_tx_burst_empw(void *dpdk_txq, struct rte_mbuf **pkts, uint16_t pkts_n) if (max_elts - j < segs_n) break; /* Do not bother with large packets MPW cannot handle. */ - if (segs_n > MLX5_MPW_DSEG_MAX) + if (segs_n > MLX5_MPW_DSEG_MAX) { + txq->stats.oerrors++; break; + } /* Should we enable HW CKSUM offload. */ if (buf->ol_flags & (PKT_TX_IP_CKSUM | PKT_TX_TCP_CKSUM | PKT_TX_UDP_CKSUM)) -- 2.7.4