From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id BE3C9235 for ; Tue, 21 Nov 2017 14:22:20 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 72F6D20914; Tue, 21 Nov 2017 08:22:20 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Tue, 21 Nov 2017 08:22:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=eLZcWND/uk5YgcVvv nA7EKGKCXC53LHtUEDQ2YX6l6s=; b=L8lvSC8NxKwsZBizkUn/pCQvZ7w8PWcGE UfmROE8hvEkyZodQ5n/L0NcYel6/m846dasn9S//4CV7t4zXOzcfRJsMfAoqog8g HDEbgMIvEEYcPdZQFDwW+ftLjb23KIaTbC7nQKtgjEV0Z2jFnCrj94OgFd+M5R3Z 4mN34mrZFGr00Pz7BKIrVFoxupkszpD85qgJFWOP/Bt7GVaMHnNzkK+SR2ariJLl 93e8ec+tM1X9M8kZFyP+V5/De9NKWVnb/gYsfSJjDLYTnoHfnfA/shyPzwomp3Ns W2OOnnV/jU/QBg9W/qqI0BXwpQpeqECi+5M0fnOUzf8naEOS+ulIA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=eLZcWND/uk5YgcVvvnA7EKGKCXC53LHtUEDQ2YX6l6s=; b=HOylPiBD imKsAmf0B7A5GJvxgBWumBRQ/tcX89FUX/YsXZv+UCLQ+NScdyPC2uXQVzr4AJFo 4Qn7xObh9VatYly86KkRQQxTZPQpE17KbxUrVaMWzyB7m+U/Y+ooeBqC3x4Sz+Ij KAjXfKcZR9idlGzOAscPbv6IoP5OzKx8Yt0lp43EMUylOdpjFsl7fjV9qXd+Gv5t oP9KALLEOQNdaUwU5bizoS4T+nYPtzOrpBWTGaqxQXVBesQ+HR08hLWhw63YygiK jMjzCYIHH/XSv+2uKJU41DhEYtdWrxApzHGpn8K5/u9v0qKrVT9PhEJ/TV503Wz7 q6g0hnltvisZ+w== X-ME-Sender: Received: from localhost.localdomain (unknown [180.158.62.0]) by mail.messagingengine.com (Postfix) with ESMTPA id 2445E24810; Tue, 21 Nov 2017 08:22:17 -0500 (EST) From: Yuanhan Liu To: Yong Wang Cc: Ferruh Yigit , dpdk stable Date: Tue, 21 Nov 2017 21:16:27 +0800 Message-Id: <1511270333-31002-45-git-send-email-yliu@fridaylinux.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1511270333-31002-1-git-send-email-yliu@fridaylinux.org> References: <1511270333-31002-1-git-send-email-yliu@fridaylinux.org> Subject: [dpdk-stable] patch 'net/igb: fix memcpy length' has been queued to stable release 17.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Nov 2017 13:22:20 -0000 Hi, FYI, your patch has been queued to stable release 17.08.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/24/17. So please shout if anyone has objections. Thanks. --yliu --- >>From 87876fbf4de985ed985a80bd21bb2cd2c89e684c Mon Sep 17 00:00:00 2001 From: Yong Wang Date: Tue, 12 Sep 2017 08:44:00 -0400 Subject: [PATCH] net/igb: fix memcpy length [ upstream commit 671f8776871d2e46c0619c743a82b2f6f6ce58ec ] The size of "flex_filter.filter_info.mask" and "filter->mask" are 16 bytes, but the length of memcpy--"RTE_ALIGN(filter->len, sizeof(char)) / sizeof(char)" may reach 128 bytes which may cause array access out of bound. Fix it by replacing "sizeof(char)" by "CHAR_BIT". Fixes: 231d43909a31 ("igb: migrate flex filter to new API") Signed-off-by: Yong Wang Reviewed-by: Ferruh Yigit --- drivers/net/e1000/igb_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c index e4f7a9f..8078a1e 100644 --- a/drivers/net/e1000/igb_ethdev.c +++ b/drivers/net/e1000/igb_ethdev.c @@ -4094,7 +4094,7 @@ eth_igb_get_flex_filter(struct rte_eth_dev *dev, flex_filter.filter_info.priority = filter->priority; memcpy(flex_filter.filter_info.dwords, filter->bytes, filter->len); memcpy(flex_filter.filter_info.mask, filter->mask, - RTE_ALIGN(filter->len, sizeof(char)) / sizeof(char)); + RTE_ALIGN(filter->len, CHAR_BIT) / CHAR_BIT); it = eth_igb_flex_filter_lookup(&filter_info->flex_list, &flex_filter.filter_info); -- 2.7.4