From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 7552D235 for ; Tue, 21 Nov 2017 14:22:33 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 29B4320A7B; Tue, 21 Nov 2017 08:22:33 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Tue, 21 Nov 2017 08:22:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=Hh4NZhZoKAwdFFXyZ MTQ25AO9uiKXOsbgPRygu8YaLE=; b=DP+eoAINIBuQ8/nk9X2+q5F+72SS0/Sd5 pRLl8EZrP8JAnyGptj5Cqg1oe94NfB1bqEk+HJ2ptKwHcW3q6ruAXZ0neUce+56c /hG0IqBQdge6z96gVJcB4aeL08BH2SmHdqrUq79b5EnDj8QsEH0lGJhInwHGxSsi evC/5/hoLEG9PqqFdEkR4/x7sH4h0F1Vqd4nOJnT/4jCmwcncMkuU0BkfF9eaEgc eYl7Z4Q7Ycc6LtI2EJPT8MmCvlHFF72P+5dTCfw50o259TJyK7Cv8ABAFCwC2/rL y30La2pesnWQjfxw0LYIic5So1/fv3+wFqO1sYPanLHYo4NZfQZsw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=Hh4NZhZoKAwdFFXyZMTQ25AO9uiKXOsbgPRygu8YaLE=; b=ZiU0+yT6 RPgXtSJcNIxU0WV/PA+3Gbp7zzNL1FbakTA3EEsOPFcpvqI0inQAZy9o3KPmZSM9 z3YVIUEnMamJBC0Y7tIGqfQ+IsyXMXKupRUNVXeyr96u62JW0J6w8o8zhOJvasfs h/LFlNIDboWgSHsACPFnbYuQ99Y0FuDJ1lDuWgFcDY62ag3gebvhMwNpOsMrJtgt mh8u5AbR9EWXZTdfamMAcCqPK+n42+f1OtTjZcXgY7MZMVsxPXu/G5YzdFdPu5qJ NmexjX+QNiAynKizD0adMsciCxIfA79VWGfUSS9NMpjfZTQ29tNxdE8T0wv0htm+ LVeU3YCYjphirw== X-ME-Sender: Received: from localhost.localdomain (unknown [180.158.62.0]) by mail.messagingengine.com (Postfix) with ESMTPA id 2144C243B9; Tue, 21 Nov 2017 08:22:29 -0500 (EST) From: Yuanhan Liu To: Vipin Varghese Cc: Pascal Mazon , dpdk stable Date: Tue, 21 Nov 2017 21:16:30 +0800 Message-Id: <1511270333-31002-48-git-send-email-yliu@fridaylinux.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1511270333-31002-1-git-send-email-yliu@fridaylinux.org> References: <1511270333-31002-1-git-send-email-yliu@fridaylinux.org> Subject: [dpdk-stable] patch 'net/tap: fix unregistering callback with invalid fd' has been queued to stable release 17.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Nov 2017 13:22:33 -0000 Hi, FYI, your patch has been queued to stable release 17.08.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/24/17. So please shout if anyone has objections. Thanks. --yliu --- >>From 1d9b04559516a301820f4d947e5811d4dac31984 Mon Sep 17 00:00:00 2001 From: Vipin Varghese Date: Mon, 18 Sep 2017 19:47:35 +0100 Subject: [PATCH] net/tap: fix unregistering callback with invalid fd [ upstream commit d8f759a0ea03f8258db2b8e7fad3c7dffc8a9c39 ] tap_intr_handle_set() called by tap_dev_start(), and if LSC is disabled (dev_conf.intr_conf.lsc == 0), it tries to unregister interrupt callback without checking the interrupt file descriptor. Fixes: c0bddd3a057f ("net/tap: add link status notification") Signed-off-by: Vipin Varghese Acked-by: Pascal Mazon --- drivers/net/tap/rte_eth_tap.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c index d926d4b..52380b4 100644 --- a/drivers/net/tap/rte_eth_tap.c +++ b/drivers/net/tap/rte_eth_tap.c @@ -1132,10 +1132,11 @@ tap_intr_handle_set(struct rte_eth_dev *dev, int set) /* In any case, disable interrupt if the conf is no longer there. */ if (!dev->data->dev_conf.intr_conf.lsc) { - if (pmd->intr_handle.fd != -1) + if (pmd->intr_handle.fd != -1) { nl_final(pmd->intr_handle.fd); - rte_intr_callback_unregister( - &pmd->intr_handle, tap_dev_intr_handler, dev); + rte_intr_callback_unregister(&pmd->intr_handle, + tap_dev_intr_handler, dev); + } return 0; } if (set) { -- 2.7.4