From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 90F2A235 for ; Tue, 21 Nov 2017 14:22:38 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 4552C20CDE; Tue, 21 Nov 2017 08:22:38 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Tue, 21 Nov 2017 08:22:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=sEyZAvAsPTdJsl2SD onc1rEk+tX+EGdfwPbnA9owfUo=; b=TxCOwzLCEgzjtYUH7VWWqJf9K3KPC+g6u ttO3qnoXiZNAexReYavGiSFxjeQ4HQVm7HjTL3QX82CQxUsb/0fopXBjtMGpOcKy d11NgqwNDU9ZpylDQzEFb+gQFdObF9XMMO7e4cf0KtkTL1hYErDSnAbbYYFxih6U paFOjVY1HE3fjuPl/0FENKZQXT1AtxM9GgtLsR9uVuXjl8juEffqpuShNDdrrGv0 XXaMrkvRIUPpL98/TSWc27304PT1i/uji8jAAN3Sew65XBaCbammjrUtg/Abgt6L wrCgaJqRHDd5mGeYmjyfOOJN8xrKV8LwKmAL5VNzc2jpbNKA6bvIA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=sEyZAvAsPTdJsl2SDonc1rEk+tX+EGdfwPbnA9owfUo=; b=FQVe930N Mkg90l8IjJDNGXBr8LQwtiNuCv6x0t9E1mRPgtCaUjbz0whaiN0SgVd6LBcOLwz2 RNO3y9q//RiUrbuYYvKM7OmV0A2rs0k4AjKD/yB7+PBmcTQkPRxYSD5NuvbHYeyp waiDfCHATbHrsVp8bj/imYEHrAqFcgUYZHeWK9CtolcEIEh14woAoRcJZkP/H+Ry NmTBayCaCXl8wpMDn2r/qbqug73secQuma/WXsxa52Z61/7pbllZWEGuMw7/MBZh ZpXEgXDzqtJvJlHG1BaxAI4WaiKBiSpNcchswxM4rivj+PQXegzgKjeBq2tZV7xy BI37l4Ge9g8dfQ== X-ME-Sender: Received: from localhost.localdomain (unknown [180.158.62.0]) by mail.messagingengine.com (Postfix) with ESMTPA id E0B13243B9; Tue, 21 Nov 2017 08:22:33 -0500 (EST) From: Yuanhan Liu To: Sebastian Basierski Cc: Ferruh Yigit , dpdk stable Date: Tue, 21 Nov 2017 21:16:31 +0800 Message-Id: <1511270333-31002-49-git-send-email-yliu@fridaylinux.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1511270333-31002-1-git-send-email-yliu@fridaylinux.org> References: <1511270333-31002-1-git-send-email-yliu@fridaylinux.org> Subject: [dpdk-stable] patch 'net/vmxnet3: fix unintentional integer overflow' has been queued to stable release 17.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Nov 2017 13:22:38 -0000 Hi, FYI, your patch has been queued to stable release 17.08.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/24/17. So please shout if anyone has objections. Thanks. --yliu --- >>From 0048a055720cb389207b138fb9898540654567ea Mon Sep 17 00:00:00 2001 From: Sebastian Basierski Date: Tue, 19 Sep 2017 13:47:58 +0200 Subject: [PATCH] net/vmxnet3: fix unintentional integer overflow [ upstream commit e8c1642a3ce7517d8c974ed16446d5fc2c917e39 ] Fixed overflow by casting txq->cmd_ring.next2fill to uint64_t type. Coverity issue: 143457 Fixes: 01fef6e3c181 ("net/vmxnet3: allow variable length Tx data ring") Signed-off-by: Sebastian Basierski Reviewed-by: Ferruh Yigit --- drivers/net/vmxnet3/vmxnet3_rxtx.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c b/drivers/net/vmxnet3/vmxnet3_rxtx.c index d9cf437..680da17 100644 --- a/drivers/net/vmxnet3/vmxnet3_rxtx.c +++ b/drivers/net/vmxnet3/vmxnet3_rxtx.c @@ -504,8 +504,9 @@ vmxnet3_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, */ gdesc = txq->cmd_ring.base + txq->cmd_ring.next2fill; if (copy_size) { - uint64 offset = txq->cmd_ring.next2fill * - txq->txdata_desc_size; + uint64 offset = + (uint64)txq->cmd_ring.next2fill * + txq->txdata_desc_size; gdesc->txd.addr = rte_cpu_to_le_64(txq->data_ring.basePA + offset); -- 2.7.4