From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 6127D235 for ; Tue, 21 Nov 2017 14:19:43 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 1574D20AEB; Tue, 21 Nov 2017 08:19:43 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Tue, 21 Nov 2017 08:19:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=XWuIUZX+LYL2oVnHz VawwnYklGw34F0PKz2dlBnwS/o=; b=J7gx/F/G7jS45poOPzqljCZWou9a3vHbr 2yQSvNvSfR58NCKqgq2XKjx+o2cOm6GGUja+nl+wYPNyBWCeNdIoTIDjiRBsp8sG cqZbTYzyaTnNzLy9JcQHzrQn9nszqBitHzaQAdoy7BCJSuf4eA0Yyv12HQNDILcv a7ySGm75s+Qx8w0gkVupiVUpnXOvwTVmKq0T0kdGxcolIMrEyHuIX6glj/QoowvS ja5+jQud5gtlU9ROrdb/iYPP/ol3/xKSyxxrlePX/ukyN5f34y4LjlDtg28oKnr/ mKpWhQesAr0MtJlbKvnCkKlqnRAPc5uE/lc+Xz/utEXeXz8FWj3jw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=XWuIUZX+LYL2oVnHzVawwnYklGw34F0PKz2dlBnwS/o=; b=NQlEsGQ3 aAVHf5c7VT9umIvMLzQhNYyCbfGcmid8eKMp9KXDEWBxhh3H5ZmBIw4D/Zx+uEpE GliKE+hpZZi3PPDWuC+aDBbr2C0qmVZ+tQH2OmaDX31HCh7BFrI5XgO++x4V42SN Q2RxWyD81v+Zol3DNnzobW7KmANlNttj2fIdPrC5KzqCKLNYs7xKZBo6eZGtHXzQ ScJoSeOkFrqkFmUt0VMIuzN2Mh5LIH4N5LZQLrr4Dy8QDkhVMkaZmnXBv2cpKKtl 4uHqba7SbulM8xl7GWoCFuMb2V01onPTCh+1WWo6uDvOiO7a7ngAUrwN0wCWSytp NW7oKkT/ydo5hA== X-ME-Sender: Received: from localhost.localdomain (unknown [180.158.62.0]) by mail.messagingengine.com (Postfix) with ESMTPA id 44A4F243B9; Tue, 21 Nov 2017 08:19:39 -0500 (EST) From: Yuanhan Liu To: Kuba Kozak Cc: Anatoly Burakov , Patrick MacArthur , dpdk stable Date: Tue, 21 Nov 2017 21:15:48 +0800 Message-Id: <1511270333-31002-6-git-send-email-yliu@fridaylinux.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1511270333-31002-1-git-send-email-yliu@fridaylinux.org> References: <1511270333-31002-1-git-send-email-yliu@fridaylinux.org> Subject: [dpdk-stable] patch 'vfio: fix close unchecked file descriptor' has been queued to stable release 17.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Nov 2017 13:19:43 -0000 Hi, FYI, your patch has been queued to stable release 17.08.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/24/17. So please shout if anyone has objections. Thanks. --yliu --- >>From 0f718a5f2e9b500acf99f6dddbe36dfc75439ce7 Mon Sep 17 00:00:00 2001 From: Kuba Kozak Date: Thu, 21 Sep 2017 15:49:08 +0200 Subject: [PATCH] vfio: fix close unchecked file descriptor [ upstream commit 96128b365eff2a1e5477e676c08c1fc631cc82c2 ] Add file descriptor value check before calling close() function. Coverity issue: 141297 Fixes: 811b6b25060f ("vfio: fix file descriptor leak in multi-process") Signed-off-by: Kuba Kozak Acked-by: Anatoly Burakov Acked-by: Patrick MacArthur --- lib/librte_eal/linuxapp/eal/eal_vfio_mp_sync.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/librte_eal/linuxapp/eal/eal_vfio_mp_sync.c b/lib/librte_eal/linuxapp/eal/eal_vfio_mp_sync.c index 7e8095c..537beeb 100644 --- a/lib/librte_eal/linuxapp/eal/eal_vfio_mp_sync.c +++ b/lib/librte_eal/linuxapp/eal/eal_vfio_mp_sync.c @@ -301,7 +301,8 @@ vfio_mp_sync_thread(void __rte_unused * arg) vfio_mp_sync_send_request(conn_sock, SOCKET_ERR); else vfio_mp_sync_send_fd(conn_sock, fd); - close(fd); + if (fd >= 0) + close(fd); break; case SOCKET_REQ_GROUP: /* wait for group number */ -- 2.7.4