From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 7425823A for ; Tue, 21 Nov 2017 14:23:27 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 277E320BA4; Tue, 21 Nov 2017 08:23:27 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Tue, 21 Nov 2017 08:23:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=Gzuc8W28fse5/RJjv /rlFtUuXnNoEY7byE0/9FUkGns=; b=CLilHAosoqwm326DfhNaiviJDB0JKqaQv 6WT9jiRzb4VEl23Vvc8+YoBUdVrZRHXoOn6AxA9t8AH8c23sUPCH38lhuWap5Rpd abbu+ywScmZ91FUvXfghbep8HnZWtRw6/c4+2zD52KSiVdOrxLcnEysV/uIm779v huOOmMIeVsCEp7j0NN84e3cKS8wFbpjpPafaathvfpe7BTvmQDjuk/DKyeWQ6oJ5 DoM1q7GHSmifYK7hJdhbVN0sI9f+thsVkFAajhpzwNEYGzudJy9lKO/3QZ+RV0U0 y3qCjllE7JNkRHa6seowgFqlK2xcsm+UIlWY3BM8KnIZ4779rWMAw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=Gzuc8W28fse5/RJjv/rlFtUuXnNoEY7byE0/9FUkGns=; b=MOfkqrG1 8GCd1xjE3PsYs8ZmzliPPS5qzefjSQIMdOgHWNNujbI6+itH6NKyhK7stfVYBYCZ IwRAK14tJQgt6dVQE5TkFVmMjeEYwxNCBH7+nLnq6XX/LzThsFAL8x9fmhq9/dv5 tfwfaxYpFFZbpE5/HaT3+4+cIXgWBlR99P9BAeSv1p/7RBUJ08L3uG9tUG+/607B A/2f1bCDoF8ZG12kg30q/IrjOv+rmTx8NZixq4fTIHkdxRzhLLsgqjbuRlDdABoP wgKq1N2926OFb6zNP+3ohexF/Pvh9mAU/jA8rJyuSRhZq6MHiymBEYdzJPJA0CNw 14kvYHNi3USJxQ== X-ME-Sender: Received: from localhost.localdomain (unknown [180.158.62.0]) by mail.messagingengine.com (Postfix) with ESMTPA id C3C4A24631; Tue, 21 Nov 2017 08:23:24 -0500 (EST) From: Yuanhan Liu To: Ajit Khaparde Cc: Stephen Hurd , dpdk stable Date: Tue, 21 Nov 2017 21:16:44 +0800 Message-Id: <1511270333-31002-62-git-send-email-yliu@fridaylinux.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1511270333-31002-1-git-send-email-yliu@fridaylinux.org> References: <1511270333-31002-1-git-send-email-yliu@fridaylinux.org> Subject: [dpdk-stable] patch 'net/bnxt: fix usage of VMDq flags' has been queued to stable release 17.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Nov 2017 13:23:27 -0000 Hi, FYI, your patch has been queued to stable release 17.08.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/24/17. So please shout if anyone has objections. Thanks. --yliu --- >>From 8f30d6ea0bf5eefe971c83e70fbd6373597619b8 Mon Sep 17 00:00:00 2001 From: Ajit Khaparde Date: Thu, 28 Sep 2017 16:43:29 -0500 Subject: [PATCH] net/bnxt: fix usage of VMDq flags [ upstream commit 0714ee90de2665f08d7bf7b7ac540497da92c2a1 ] Map ETH_VMDQ_ACCEPT_HASH_UC to the promiscuous bit. Also, set ALLMULTI and MCAST when MCAST is set to ensure multicast traffic is received regardless of the VF driver list. Fixes: 4cfe399f6550 ("net/bnxt: support to set VF rxmode") Signed-off-by: Stephen Hurd Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/rte_pmd_bnxt.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/net/bnxt/rte_pmd_bnxt.c b/drivers/net/bnxt/rte_pmd_bnxt.c index c343d90..0bf5db5 100644 --- a/drivers/net/bnxt/rte_pmd_bnxt.c +++ b/drivers/net/bnxt/rte_pmd_bnxt.c @@ -409,20 +409,19 @@ int rte_pmd_bnxt_set_vf_rxmode(uint8_t port, uint16_t vf, if (vf >= bp->pdev->max_vfs) return -EINVAL; - if (rx_mask & (ETH_VMDQ_ACCEPT_UNTAG | ETH_VMDQ_ACCEPT_HASH_MC)) { + if (rx_mask & ETH_VMDQ_ACCEPT_UNTAG) { RTE_LOG(ERR, PMD, "Currently cannot toggle this setting\n"); return -ENOTSUP; } - if (rx_mask & ETH_VMDQ_ACCEPT_HASH_UC && !on) { - RTE_LOG(ERR, PMD, "Currently cannot disable UC Rx\n"); - return -ENOTSUP; - } + /* Is this really the correct mapping? VFd seems to think it is. */ + if (rx_mask & ETH_VMDQ_ACCEPT_HASH_UC) + flag |= BNXT_VNIC_INFO_PROMISC; if (rx_mask & ETH_VMDQ_ACCEPT_BROADCAST) flag |= BNXT_VNIC_INFO_BCAST; if (rx_mask & ETH_VMDQ_ACCEPT_MULTICAST) - flag |= BNXT_VNIC_INFO_ALLMULTI; + flag |= BNXT_VNIC_INFO_ALLMULTI | BNXT_VNIC_INFO_MCAST; if (on) bp->pf.vf_info[vf].l2_rx_mask |= flag; -- 2.7.4