From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 04176235 for ; Tue, 21 Nov 2017 14:23:36 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id AC9FB20CBA; Tue, 21 Nov 2017 08:23:35 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Tue, 21 Nov 2017 08:23:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=ugb5Sg9/o2iCwPimO SXqUbxcWnVVs+/XU9u5+WWWEn8=; b=EJeCoeXwakCcuuiII/nqWGRiwP5jVK2nE XU/OMrAwjO9zhqAv1cgJCISD/qXLN9fyArnkNQbfrd+EJAm5tWCfMaDrBT9tjJO7 NlvAN0onL5FmLLUUmYNE1mgKUQ26NKkFcCQBjFPGaDUfdaTPxj4qrxFHMRThmVea 6k0ZQNVVyzeBrB2YkvhWIU3p2hlS1GXcwAdEGyBlaIUkjZU8/OocCO0jf15c8o7w HtlTLqBKnGZ/KBhIQEXcqu19TCwRbefFkrSV/6qfXq4QmvqG4YkX1EZylhOeWSZK V0TKo5AVPvziQTjVbh5adjW6pgt/I5dx12eJ/zp1ZdqZHO6OisX5w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=ugb5Sg9/o2iCwPimOSXqUbxcWnVVs+/XU9u5+WWWEn8=; b=gZ2oq+Aq Z2B0LILsLhToTuMwkThCTR+rIkXMeDj2e8UEbhMB1+H3ag6lzfW7xfRiYi9CE5w2 edXdcOThglxxF4S4UsLFhFUlWFNM0jlXYafU8muskh9XzjiToeStwi5q91aTIzgv TcgiBw651HVN2EV03wXb3+wipsI2GtR4H41waGwqM28afLpG1SOzffzvOwX1UuNZ 1A6MFseCZPYrOeOORnfje2J4qOeDO00yuEsdJCI214ObYHcIh8kvaQowaKrND0pY w4aomX86Z2OH2RrcGTM6LB/VEW/fZUCasuD6vy65RCQtg2llzUWlJelHPcN8cc3m cOC6HV82SFNtFw== X-ME-Sender: Received: from localhost.localdomain (unknown [180.158.62.0]) by mail.messagingengine.com (Postfix) with ESMTPA id 198EB243B9; Tue, 21 Nov 2017 08:23:32 -0500 (EST) From: Yuanhan Liu To: Ajit Khaparde Cc: dpdk stable Date: Tue, 21 Nov 2017 21:16:47 +0800 Message-Id: <1511270333-31002-65-git-send-email-yliu@fridaylinux.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1511270333-31002-1-git-send-email-yliu@fridaylinux.org> References: <1511270333-31002-1-git-send-email-yliu@fridaylinux.org> Subject: [dpdk-stable] patch 'net/bnxt: fix config RSS update' has been queued to stable release 17.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Nov 2017 13:23:36 -0000 Hi, FYI, your patch has been queued to stable release 17.08.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/24/17. So please shout if anyone has objections. Thanks. --yliu --- >>From fb99c56f87ae45a3fa2b1f06ffe9019a105278a0 Mon Sep 17 00:00:00 2001 From: Ajit Khaparde Date: Thu, 28 Sep 2017 16:43:33 -0500 Subject: [PATCH] net/bnxt: fix config RSS update [ upstream commit 1ebb765090a6496e2f2a291cc4402e770670bf57 ] We are not configuring the RSS settings updated by rss_hash_update(). Fixing it. Fixes: fcc0aa1edc10 ("net/bnxt: add RSS hash configuration") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt.h | 2 ++ drivers/net/bnxt/bnxt_ethdev.c | 4 ++++ drivers/net/bnxt/bnxt_rxq.c | 5 +++++ 3 files changed, 11 insertions(+) diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h index 3579505..65f716b 100644 --- a/drivers/net/bnxt/bnxt.h +++ b/drivers/net/bnxt/bnxt.h @@ -176,6 +176,7 @@ struct bnxt { void *bar0; struct rte_eth_dev *eth_dev; + struct rte_eth_rss_conf rss_conf; struct rte_pci_device *pdev; uint32_t flags; @@ -184,6 +185,7 @@ struct bnxt { #define BNXT_FLAG_PORT_STATS (1 << 2) #define BNXT_FLAG_JUMBO (1 << 3) #define BNXT_FLAG_SHORT_CMD (1 << 4) +#define BNXT_FLAG_UPDATE_HASH (1 << 5) #define BNXT_PF(bp) (!((bp)->flags & BNXT_FLAG_VF)) #define BNXT_VF(bp) ((bp)->flags & BNXT_FLAG_VF) #define BNXT_NPAR_ENABLED(bp) ((bp)->port_partition_type) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 6e5cb88..7bcd9a3 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -837,6 +837,10 @@ static int bnxt_rss_hash_update_op(struct rte_eth_dev *eth_dev, if (rss_conf->rss_hf & BNXT_ETH_RSS_SUPPORT) return -EINVAL; } + + bp->flags |= BNXT_FLAG_UPDATE_HASH; + memcpy(&bp->rss_conf, rss_conf, sizeof(*rss_conf)); + if (rss_conf->rss_hf & ETH_RSS_IPV4) hash_type |= HWRM_VNIC_RSS_CFG_INPUT_HASH_TYPE_IPV4; if (rss_conf->rss_hf & ETH_RSS_NONFRAG_IPV4_TCP) diff --git a/drivers/net/bnxt/bnxt_rxq.c b/drivers/net/bnxt/bnxt_rxq.c index 8459fcc..690a599 100644 --- a/drivers/net/bnxt/bnxt_rxq.c +++ b/drivers/net/bnxt/bnxt_rxq.c @@ -188,6 +188,11 @@ out: struct rte_eth_rss_conf *rss = &dev_conf->rx_adv_conf.rss_conf; uint16_t hash_type = 0; + if (bp->flags & BNXT_FLAG_UPDATE_HASH) { + rss = &bp->rss_conf; + bp->flags &= ~BNXT_FLAG_UPDATE_HASH; + } + if (rss->rss_hf & ETH_RSS_IPV4) hash_type |= HWRM_VNIC_RSS_CFG_INPUT_HASH_TYPE_IPV4; if (rss->rss_hf & ETH_RSS_NONFRAG_IPV4_TCP) -- 2.7.4