From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 102EB237 for ; Tue, 21 Nov 2017 14:24:09 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B96BC20BBE; Tue, 21 Nov 2017 08:24:08 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Tue, 21 Nov 2017 08:24:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:content-transfer-encoding:content-type:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=gKbh/uSQIJUhGheth GV6PTShy4tlwOOIJWfK9ZQmQBI=; b=Nj/GfEREX5fnQQPDre8O7Z8SB1rp/Cp/R q8YhR6gbBoxtz0SGbL3rbcXB1cqE1L2ka+L7oXXTlJ8k5GgsL/I5s+G/43WSkRBA xWkxjb1Le4nB8gwG1Ybki0e9pD3y2xuo3iLAkft/pJ8zMGqCA5U8BWUwItMEEN7i njoYIM2cf+wo+3vBOjGIq0jbtajqc0TFd6bAcOa5E9XVDCp3zo9BAB9t4ggyBtM/ kIHxVNsGQOyx0cQAXtFTYqM9ddItb2KMZxFLpWxHloLl0Y43cL5+/WgWCHfbYbfj 7kvAkCy5q4BIwu3P5xLVoZ90gpwVNtKmlo1x+e+jzkeoV6gWnT4sg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=gKbh/u SQIJUhGhethGV6PTShy4tlwOOIJWfK9ZQmQBI=; b=iFyT5teyI11ymslH3W2Xhc LOSdfc8vS6DplGgfPSOH8K6FFong+mYr6bCrF+AbRFwI7P/biwG8wDZRYDIpvdxB piwHy5C0bK9QS0eiHvs2hBfW4+pPhTlEP0gFKsCCC2idr0SdTdAkYbHiVNGTxue1 n5Q2zY2T7dJsvTZxHoxsmOxCaetoAYSlLUZePE6lLQFyTyzttr6RpkEcq4ssUScd APd+XQh5YkasrD61WAW9t+ZYpEAEkpidfvOMK30fVOpY6CzHg2xOKSwubf/SpiOh yKFfuaSN3i9x4zQI116TkwYMahFfU7ctYbam83Cukg/LVRmdHY04UO0L54bXspbg == X-ME-Sender: Received: from localhost.localdomain (unknown [180.158.62.0]) by mail.messagingengine.com (Postfix) with ESMTPA id 249FA247A9; Tue, 21 Nov 2017 08:24:05 -0500 (EST) From: Yuanhan Liu To: Olivier Matz Cc: dpdk stable Date: Tue, 21 Nov 2017 21:16:55 +0800 Message-Id: <1511270333-31002-73-git-send-email-yliu@fridaylinux.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1511270333-31002-1-git-send-email-yliu@fridaylinux.org> References: <1511270333-31002-1-git-send-email-yliu@fridaylinux.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/bnxt: fix compilation with -Og' has been queued to stable release 17.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Nov 2017 13:24:09 -0000 Hi, FYI, your patch has been queued to stable release 17.08.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/24/17. So please shout if anyone has objections. Thanks. --yliu --- >>From 1b680e7b1780b4251f1700d711e4661e866c43f6 Mon Sep 17 00:00:00 2001 From: Olivier Matz Date: Mon, 11 Sep 2017 17:13:24 +0200 Subject: [PATCH] net/bnxt: fix compilation with -Og MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [ upstream commit 4a671fdea9f41ecb0a6113b66d21a8eed5ac06ec ] The compilation with gcc-6.3.0 and EXTRA_CFLAGS=-Og gives the following error: CC rte_pmd_bnxt.o rte_pmd_bnxt.c: In function ‘rte_pmd_bnxt_set_all_queues_drop_en’: rte_pmd_bnxt.c:116:6: error: ‘rc’ may be used uninitialized in this function [-Werror=maybe-uninitialized] int rc; ^~ This can happen if both bp->nr_vnics and bp->pf.active_vfs are 0. Fix it by initializing rc to -EINVAL. Fixes: 49947a13ba9e ("net/bnxt: support Tx loopback, set VF MAC and queues drop") Signed-off-by: Olivier Matz --- drivers/net/bnxt/rte_pmd_bnxt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/rte_pmd_bnxt.c b/drivers/net/bnxt/rte_pmd_bnxt.c index 0bf5db5..ef4b19b 100644 --- a/drivers/net/bnxt/rte_pmd_bnxt.c +++ b/drivers/net/bnxt/rte_pmd_bnxt.c @@ -113,7 +113,7 @@ int rte_pmd_bnxt_set_all_queues_drop_en(uint8_t port, uint8_t on) struct rte_eth_dev *eth_dev; struct bnxt *bp; uint32_t i; - int rc; + int rc = -EINVAL; RTE_ETH_VALID_PORTID_OR_ERR_RET(port, -ENODEV); -- 2.7.4