From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 9013D237 for ; Tue, 21 Nov 2017 14:24:12 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 0022F207B0; Tue, 21 Nov 2017 08:24:11 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Tue, 21 Nov 2017 08:24:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:content-transfer-encoding:content-type:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=h35tAS1bdtlrrdgoK fCa/a4dC9KGhFvPdz8smKpPmsA=; b=fJ3eX1PP+0eMHX3mQfkaTSFxAkRisIB+K gDWxLIpcvpS/mWf+BOI+GF5pVFNvSvOZRn3H+EwqevOs8mQ+8zh/kwGHhgD3hJMM HstmXDz/98dP3cM9BGBH4IGuCjLpX1ar6DaWtIv/6r0FFIIcqPa00c6Dwezqj3lR 6NXEbi01aXIIRw+TaGswILtfBGnA1oGfuo3BPfuYwa11t6IzJ7oIJxhZJwUqv9Jh StFG94/YDa15bBzdilFCO/uCOXpaP+Kf+rGqmY3MOBT5OvvqByRpO+4/nSejMBWy o5EJsuY897K9G+peM+JlX8XcCy1Ma5aWe2i0QWKNIIo4UBdJpVeBw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=h35tAS 1bdtlrrdgoKfCa/a4dC9KGhFvPdz8smKpPmsA=; b=UqLX17jPhKElPamP9S7xvF hV2Wi4G7d3Vwgd6xN4084MkH1SUG9MYBK/EH89Yqg+rzRKkSTuYL6ZBBtX7kTH6B lbpiVVcyLhiIKB2hxz0RnwjQ9cohqBgF0PfF4BmqsRnA5+2zgz8K7uMUNC4LjAgy LBCVCfojnXDENoHd28DDZvBfSJOXP1RRj5I4xiu4M7+O4WOaKO7wNA1Go5yqVcCe a+qX+u9iF52ewM0yw4ETd7+6Sjon1XkiQ/7xPXEPc8CCvmXP1aYv83B/eYMvE10/ 1TzhIDoCgU3rKO0X68l+Q/+W0Ch3z46zJS/buZYUHcPhIE6DbS5xGwl5n5/fVkMw == X-ME-Sender: Received: from localhost.localdomain (unknown [180.158.62.0]) by mail.messagingengine.com (Postfix) with ESMTPA id 78F57248B4; Tue, 21 Nov 2017 08:24:09 -0500 (EST) From: Yuanhan Liu To: Olivier Matz Cc: Harish Patil , dpdk stable Date: Tue, 21 Nov 2017 21:16:56 +0800 Message-Id: <1511270333-31002-74-git-send-email-yliu@fridaylinux.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1511270333-31002-1-git-send-email-yliu@fridaylinux.org> References: <1511270333-31002-1-git-send-email-yliu@fridaylinux.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/qede: fix compilation with -Og' has been queued to stable release 17.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Nov 2017 13:24:12 -0000 Hi, FYI, your patch has been queued to stable release 17.08.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/24/17. So please shout if anyone has objections. Thanks. --yliu --- >>From fb4b23ee976a022196cc50ca5ea3b827ebd2ba62 Mon Sep 17 00:00:00 2001 From: Olivier Matz Date: Mon, 11 Sep 2017 17:13:25 +0200 Subject: [PATCH] net/qede: fix compilation with -Og MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [ upstream commit f4b7699c88f74aeb9983aa7ef438f8e7e72eb8c5 ] The compilation with gcc-6.3.0 and EXTRA_CFLAGS=-Og gives the following error: CC qede_rxtx.o qede_rxtx.c: In function ‘qede_start_queues’: qede_rxtx.c:797:9: error: ‘rc’ may be used uninitialized in this function [-Werror=maybe-uninitialized] return rc; ^~ If there is no Rx or Tx queue, rc will not be initialized. Fix it by initializing rc to -1. Fixes: 4c4bdadfa9e7 ("net/qede: refactoring multi-queue implementation") Signed-off-by: Olivier Matz Acked-by: Harish Patil --- drivers/net/qede/qede_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/qede/qede_rxtx.c b/drivers/net/qede/qede_rxtx.c index 5c3613c..76e24ab 100644 --- a/drivers/net/qede/qede_rxtx.c +++ b/drivers/net/qede/qede_rxtx.c @@ -780,7 +780,7 @@ int qede_start_queues(struct rte_eth_dev *eth_dev) { struct qede_dev *qdev = QEDE_INIT_QDEV(eth_dev); uint8_t id; - int rc; + int rc = -1; for_each_rss(id) { rc = qede_rx_queue_start(eth_dev, id); -- 2.7.4