From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 88F73237 for ; Tue, 21 Nov 2017 14:25:08 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 3D78220ACE; Tue, 21 Nov 2017 08:25:08 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Tue, 21 Nov 2017 08:25:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=yGNvyiSL2DhaX4NX9 UWUdFjRj6knGDM6zYRDYVZ86pM=; b=ImG9IRcZnenVpF6htwIY4HVjaJwvJ2jmm fB0Izn0E/zrkBW05mRfv3R04xhXOZCXrslvQ2SK6sMC52qzcwhW6eTxR2KGKYUGZ crBJAmGuXWxsaSaqboqkfqykuUPVQvyZDOjeGTo8tX775xwNYlzCePl2yDNdSh6y Q3jijb5IklU3KjP8jNipIFIaTpMmnhlGV8QmUyO/IdjUiYUmKwYcWFtl7u/FGbGt b2yIN0Ued65Tc6kcL8gpYkPdlDL+xwIgaRae82bmW3nbHOj47+jj+jHBuqEaxDU8 t+UrqmYrH4enzyqCjgE+/9Yj9288ypQaX2W/BBo6VvFmj0AwiMQxQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=yGNvyiSL2DhaX4NX9UWUdFjRj6knGDM6zYRDYVZ86pM=; b=Kl0F9kVj Uqs5iPxjof42EN5x0KJKCOOrYjY1sxkrykeD05fL60mPS4z0t3DNqGzfZjkW6wt+ zNIqbvRLvYtzDQjGmkkoyNQX0Rbzw39BwTk/hHsOoFdS0VHXfoqJU/ADxV0JWM2Q U2GmR70tZ4VPVnzCi0LK/XpvVX1Urb6CKmKwQPWJM1DHRlnbq8m9F7vkr+6DTxM1 ixKD9l21ezhicd5Xh6GJJvZf2PaAl5zxtgHGy/Xc1lYlDhcAh6weVOt/beX+AGNk JElpQupGyauMfxsRw2Lmf4Ojd2o2PVmJ/m8qr/ROQaydBzkrXaK1WkCutxAABXHs 3lv6cikkW42PmA== X-ME-Sender: Received: from localhost.localdomain (unknown [180.158.62.0]) by mail.messagingengine.com (Postfix) with ESMTPA id 609FF24810; Tue, 21 Nov 2017 08:25:04 -0500 (EST) From: Yuanhan Liu To: Sebastian Basierski Cc: Jianfeng Tan , Yuanhan Liu , dpdk stable Date: Tue, 21 Nov 2017 21:17:12 +0800 Message-Id: <1511270333-31002-90-git-send-email-yliu@fridaylinux.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1511270333-31002-1-git-send-email-yliu@fridaylinux.org> References: <1511270333-31002-1-git-send-email-yliu@fridaylinux.org> Subject: [dpdk-stable] patch 'net/virtio-user: fix TAP name string termination' has been queued to stable release 17.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Nov 2017 13:25:08 -0000 Hi, FYI, your patch has been queued to stable release 17.08.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/24/17. So please shout if anyone has objections. Thanks. --yliu --- >>From ca7e6e85c42cc82e711bf8e2a324e17675d0b9d0 Mon Sep 17 00:00:00 2001 From: Sebastian Basierski Date: Tue, 19 Sep 2017 13:41:04 +0200 Subject: [PATCH] net/virtio-user: fix TAP name string termination [ upstream commit 907d125e2c3a4801558c2f6988e54f427e1b444a ] Fix calling strncpy with the a maximum size equal of destination array size. Coverity issue: 140732 Fixes: e3b434818bbb ("net/virtio-user: support kernel vhost") Signed-off-by: Sebastian Basierski Acked-by: Jianfeng Tan Acked-by: Yuanhan Liu --- drivers/net/virtio/virtio_user/vhost_kernel_tap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/virtio/virtio_user/vhost_kernel_tap.c b/drivers/net/virtio/virtio_user/vhost_kernel_tap.c index f585de8..689a5cf 100644 --- a/drivers/net/virtio/virtio_user/vhost_kernel_tap.c +++ b/drivers/net/virtio/virtio_user/vhost_kernel_tap.c @@ -95,9 +95,9 @@ vhost_kernel_open_tap(char **p_ifname, int hdr_size, int req_mq) ifr.ifr_flags |= IFF_MULTI_QUEUE; if (*p_ifname) - strncpy(ifr.ifr_name, *p_ifname, IFNAMSIZ); + strncpy(ifr.ifr_name, *p_ifname, IFNAMSIZ - 1); else - strncpy(ifr.ifr_name, "tap%d", IFNAMSIZ); + strncpy(ifr.ifr_name, "tap%d", IFNAMSIZ - 1); if (ioctl(tapfd, TUNSETIFF, (void *)&ifr) == -1) { PMD_DRV_LOG(ERR, "TUNSETIFF failed: %s", strerror(errno)); goto error; -- 2.7.4