From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 51E06235 for ; Tue, 21 Nov 2017 14:25:18 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id D9F4520ACE; Tue, 21 Nov 2017 08:25:17 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Tue, 21 Nov 2017 08:25:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:content-transfer-encoding:content-type:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=MifPLZ7ILDzihtX5X 9wsC1t/TKJNvuAUk7NrC6JA1nI=; b=txfkfffSV9Gw5cC7Xsa+pDlfvKMxMVOGn +rZsIS/8fCNFdnKZimiedE28voDQwhFyhXST05uwZkBO36xi0yrwwqksnCx4OY7o qzDMz3oUYX7TTkp5+fHachXi2ZXZ0CjNuoiO7lzKp1bvuLSlb4+5yFe+IaGKX2qn vPjHxWt9kcT9suM2PK1SwB1thxQmbUxSp7E8kjWStkK7u5jsXae8ZS30I+15fSuQ dTF0FpKC1VJ/zf/SnFFk3fdFvDNMdSY8tS/7ohPj8FlbASk++6O33oGuaUvc2/y7 2wsfpXsve5ltcsgwbKcqWHjRo2vOrCCcv/kpt0uVWowyITJyQxPdA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=MifPLZ 7ILDzihtX5X9wsC1t/TKJNvuAUk7NrC6JA1nI=; b=n/YyhYZ8g4/YxlX+GeWVDv 2cptEsHc6eYt0nsEA3JrzQK08S38upuYBmEu1/GEJ70/4h8jBqpEpAppNu1XouHu DSLj8TOTceF3litzQFW4PjMO3ygXUMUZ1AFGw+Glsa5MeCbSKLKnhI0eMz55dj+7 7S+K8vhAJqvekEo/cbsLY/2lA4TyFhWj6CNo2ImkEkrB726zdnBcH5eQeU2HqE/s XZ9gHYCrwbejwDs1an+AS3z20z5g7eCVRwbb9Ux4K12wQV2JX7DF6YU+3JYNKqgc 1XPycU6ulEKNxQG/Bw9p6tbnEjOy2u3nM8+SJVRdbr5EDb2ID4GkFgWPsNwb0dsA == X-ME-Sender: Received: from localhost.localdomain (unknown [180.158.62.0]) by mail.messagingengine.com (Postfix) with ESMTPA id 65BB2243B9; Tue, 21 Nov 2017 08:25:14 -0500 (EST) From: Yuanhan Liu To: Olivier Matz Cc: Maxime Coquelin , dpdk stable Date: Tue, 21 Nov 2017 21:17:15 +0800 Message-Id: <1511270333-31002-93-git-send-email-yliu@fridaylinux.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1511270333-31002-1-git-send-email-yliu@fridaylinux.org> References: <1511270333-31002-1-git-send-email-yliu@fridaylinux.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/virtio: fix compilation with -Og' has been queued to stable release 17.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Nov 2017 13:25:18 -0000 Hi, FYI, your patch has been queued to stable release 17.08.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/24/17. So please shout if anyone has objections. Thanks. --yliu --- >>From 50edf3f9468b82cf6b1f87ca227324740b7c1203 Mon Sep 17 00:00:00 2001 From: Olivier Matz Date: Mon, 11 Sep 2017 17:13:26 +0200 Subject: [PATCH] net/virtio: fix compilation with -Og MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [ upstream commit 3976f19e13cf7770597b207651c76b1676b9163a ] The compilation with gcc-6.3.0 and EXTRA_CFLAGS=-Og gives the following error: CC virtio_rxtx.o virtio_rxtx.c: In function ‘virtio_rx_offload’: virtio_rxtx.c:680:10: error: ‘csum’ may be used uninitialized in this function [-Werror=maybe-uninitialized] csum = ~csum; ~~~~~^~~~~~~ The function rte_raw_cksum_mbuf() may indeed return an error, and in this case, csum won't be initialized. Fix it by initializing csum to 0. Fixes: 96cb6711939e ("net/virtio: support Rx checksum offload") Signed-off-by: Olivier Matz Reviewed-by: Maxime Coquelin --- drivers/net/virtio/virtio_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c index a32e322..67e12de 100644 --- a/drivers/net/virtio/virtio_rxtx.c +++ b/drivers/net/virtio/virtio_rxtx.c @@ -694,7 +694,7 @@ virtio_rx_offload(struct rte_mbuf *m, struct virtio_net_hdr *hdr) * In case of SCTP, this will be wrong since it's a CRC * but there's nothing we can do. */ - uint16_t csum, off; + uint16_t csum = 0, off; rte_raw_cksum_mbuf(m, hdr->csum_start, rte_pktmbuf_pkt_len(m) - hdr->csum_start, -- 2.7.4