From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id F1754235 for ; Tue, 21 Nov 2017 14:25:30 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id A4A4120A5F; Tue, 21 Nov 2017 08:25:30 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Tue, 21 Nov 2017 08:25:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=oPSYO92R2GL+n7hrB Fy1IQ0O1sV4z9UZIT4phx1e9c4=; b=CCSNu7TvLY7m9XwKy4gPdWepU1pYCUr0A +xPj5JWOC+THmVwMZT8PDGxB13c4NAukayrfipH4ibbOPFF7zqAs+aE6PJYYj/cD yzEayJ/6f403Dbk0KIm1rYIDQwhnTvYju75xrtE4DezkVCUJKtWBui8KtgrAmXix JXT+CCGwAK4A50EhfI1KEdOmoSYu0pvuZ03w7V8UvYMf3Irp2mK3IU/KyjnX3i5u Tt3DoMwuVfIV9KXB6Cc2kRJ6YsY0IVldLLRKGto4yFC3BIgWLRDxC7oqxD8VsXwY mpya4+jTTPeAGTAFIUkPyYQzosycP25ZDQ3+o0XB6l1L7M2SJ1L2Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=oPSYO92R2GL+n7hrBFy1IQ0O1sV4z9UZIT4phx1e9c4=; b=gHxKTFZ5 yMeX4eWFtw1mhs6ldgZhunKMJgJ/wBJ9Ll2fwLMy2IIThjQOlwnHELdIuqQYCN0e UhV3gUXRwniqeWaa5NlJyLBE1kmYw3oD8XzNz7X2yA2T0SuBxOo95V0nkSr+k2I3 e7o9RffSkEwS9pcOHZrXkr2q7+nWouyz3Qd1WCuWjqvafzIAujDx8abcJ5+j4xkQ BuvOl7jDov6w7C7al6rnPEMojpFn3To621CBANJ1LLRH3XbDxozjgvYED9O7Xx1p cz7PlUu1cIHHALsYWXklP83WIJZlmFI09H5pzbATWcbL0ukv6uLC7fumIfMN77qX F9JTYAgaBgK+dQ== X-ME-Sender: Received: from localhost.localdomain (unknown [180.158.62.0]) by mail.messagingengine.com (Postfix) with ESMTPA id 4A22B24631; Tue, 21 Nov 2017 08:25:27 -0500 (EST) From: Yuanhan Liu To: Li Han Cc: Ferruh Yigit , dpdk stable Date: Tue, 21 Nov 2017 21:17:19 +0800 Message-Id: <1511270333-31002-97-git-send-email-yliu@fridaylinux.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1511270333-31002-1-git-send-email-yliu@fridaylinux.org> References: <1511270333-31002-1-git-send-email-yliu@fridaylinux.org> Subject: [dpdk-stable] patch 'app/testpmd: fix invalid port id parameters' has been queued to stable release 17.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Nov 2017 13:25:31 -0000 Hi, FYI, your patch has been queued to stable release 17.08.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/24/17. So please shout if anyone has objections. Thanks. --yliu --- >>From 15a7b723d238a141d3ac43c10cb9ce3078954988 Mon Sep 17 00:00:00 2001 From: Li Han Date: Tue, 22 Aug 2017 13:03:42 +0800 Subject: [PATCH] app/testpmd: fix invalid port id parameters [ upstream commit d1f1a0fd8a0b3e5b090e64a8d7d895479e959143 ] in parse_ringnuma_config/parse_portnuma_config functions, port_id should be less than RTE_MAX_ETHPORTS, but port_id_is_invalid check assumes that port_id may be RTE_PORT_ALL (65535). Also fix port_id storage size. Fixes: 4468635fdd04 ("app/testpmd: forbid actions on invalid port") Signed-off-by: Li Han Reviewed-by: Ferruh Yigit --- app/test-pmd/parameters.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c index 2f7f70f..31023fe 100644 --- a/app/test-pmd/parameters.c +++ b/app/test-pmd/parameters.c @@ -393,7 +393,8 @@ parse_portnuma_config(const char *q_arg) char s[256]; const char *p, *p0 = q_arg; char *end; - uint8_t i,port_id,socket_id; + uint8_t i, socket_id; + portid_t port_id; unsigned size; enum fieldnames { FLD_PORT = 0, @@ -423,8 +424,9 @@ parse_portnuma_config(const char *q_arg) if (errno != 0 || end == str_fld[i] || int_fld[i] > 255) return -1; } - port_id = (uint8_t)int_fld[FLD_PORT]; - if (port_id_is_invalid(port_id, ENABLED_WARN)) { + port_id = (portid_t)int_fld[FLD_PORT]; + if (port_id_is_invalid(port_id, ENABLED_WARN) || + port_id == (portid_t)RTE_PORT_ALL) { printf("Valid port range is [0"); RTE_ETH_FOREACH_DEV(pid) printf(", %d", pid); @@ -448,7 +450,8 @@ parse_ringnuma_config(const char *q_arg) char s[256]; const char *p, *p0 = q_arg; char *end; - uint8_t i,port_id,ring_flag,socket_id; + uint8_t i, ring_flag, socket_id; + portid_t port_id; unsigned size; enum fieldnames { FLD_PORT = 0, @@ -482,8 +485,9 @@ parse_ringnuma_config(const char *q_arg) if (errno != 0 || end == str_fld[i] || int_fld[i] > 255) return -1; } - port_id = (uint8_t)int_fld[FLD_PORT]; - if (port_id_is_invalid(port_id, ENABLED_WARN)) { + port_id = (portid_t)int_fld[FLD_PORT]; + if (port_id_is_invalid(port_id, ENABLED_WARN) || + port_id == (portid_t)RTE_PORT_ALL) { printf("Valid port range is [0"); RTE_ETH_FOREACH_DEV(pid) printf(", %d", pid); -- 2.7.4