* [dpdk-stable] [PATCH] net/nfp: fix CRC strip check behaviour
@ 2017-11-24 14:26 Alejandro Lucero
2017-12-04 23:34 ` Ferruh Yigit
0 siblings, 1 reply; 2+ messages in thread
From: Alejandro Lucero @ 2017-11-24 14:26 UTC (permalink / raw)
To: dev; +Cc: stable
NFP does CRC strip by default and it is not configurable. But, even
if an app requests not to do it, that should not be a reason for PMD
configuration failure.
Fixes: defb9a5dd156 ("nfp: introduce driver initialization")
Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
---
drivers/net/nfp/nfp_net.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
index e2cea06..6e61c56 100644
--- a/drivers/net/nfp/nfp_net.c
+++ b/drivers/net/nfp/nfp_net.c
@@ -491,10 +491,8 @@ enum nfp_qcp_ptr {
if (rxmode->jumbo_frame)
hw->mtu = rxmode->max_rx_pkt_len;
- if (rxmode->hw_strip_crc) {
- PMD_INIT_LOG(INFO, "strip CRC not supported");
- return -EINVAL;
- }
+ if (!rxmode->hw_strip_crc)
+ PMD_INIT_LOG(INFO, "HW does strip CRC and it is not configurable");
if (rxmode->enable_scatter) {
PMD_INIT_LOG(INFO, "Scatter not supported");
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-stable] [PATCH] net/nfp: fix CRC strip check behaviour
2017-11-24 14:26 [dpdk-stable] [PATCH] net/nfp: fix CRC strip check behaviour Alejandro Lucero
@ 2017-12-04 23:34 ` Ferruh Yigit
0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2017-12-04 23:34 UTC (permalink / raw)
To: Alejandro Lucero, dev; +Cc: stable
On 11/24/2017 6:26 AM, Alejandro Lucero wrote:
> NFP does CRC strip by default and it is not configurable. But, even
> if an app requests not to do it, that should not be a reason for PMD
> configuration failure.
>
> Fixes: defb9a5dd156 ("nfp: introduce driver initialization")
>
> Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-12-04 23:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-24 14:26 [dpdk-stable] [PATCH] net/nfp: fix CRC strip check behaviour Alejandro Lucero
2017-12-04 23:34 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).