* [dpdk-stable] [PATCH 1/5] net/qede: fix to enable LRO over tunnels
[not found] <1511555745-13793-1-git-send-email-rasesh.mody@cavium.com>
@ 2017-11-24 20:35 ` Rasesh Mody
2017-11-24 20:35 ` [dpdk-stable] [PATCH 3/5] net/qede: fix to reject config with no Rx queue Rasesh Mody
` (2 subsequent siblings)
3 siblings, 0 replies; 4+ messages in thread
From: Rasesh Mody @ 2017-11-24 20:35 UTC (permalink / raw)
To: dev; +Cc: Harish Patil, Dept-EngDPDKDev, stable
From: Harish Patil <harish.patil@cavium.com>
Enable LRO feature to work with tunnel encapsulation protocols.
Fixes: 29540be7efce ("net/qede: support LRO/TSO offloads")
Cc: stable@dpdk.org
Signed-off-by: Harish Patil <harish.patil@cavium.com>
---
drivers/net/qede/qede_ethdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c
index 6f5ba2a..cc473d6 100644
--- a/drivers/net/qede/qede_ethdev.c
+++ b/drivers/net/qede/qede_ethdev.c
@@ -482,8 +482,8 @@ int qede_activate_vport(struct rte_eth_dev *eth_dev, bool flg)
/* Enable LRO in split mode */
sge_tpa_params->tpa_ipv4_en_flg = enable;
sge_tpa_params->tpa_ipv6_en_flg = enable;
- sge_tpa_params->tpa_ipv4_tunn_en_flg = false;
- sge_tpa_params->tpa_ipv6_tunn_en_flg = false;
+ sge_tpa_params->tpa_ipv4_tunn_en_flg = enable;
+ sge_tpa_params->tpa_ipv6_tunn_en_flg = enable;
/* set if tpa enable changes */
sge_tpa_params->update_tpa_en_flg = 1;
/* set if tpa parameters should be handled */
--
1.7.10.3
^ permalink raw reply [flat|nested] 4+ messages in thread
* [dpdk-stable] [PATCH 3/5] net/qede: fix to reject config with no Rx queue
[not found] <1511555745-13793-1-git-send-email-rasesh.mody@cavium.com>
2017-11-24 20:35 ` [dpdk-stable] [PATCH 1/5] net/qede: fix to enable LRO over tunnels Rasesh Mody
@ 2017-11-24 20:35 ` Rasesh Mody
2017-12-14 6:36 ` [dpdk-stable] [PATCH v2 1/3] net/qede: fix to enable LRO over tunnels Rasesh Mody
2017-12-14 6:36 ` [dpdk-stable] [PATCH v2 2/3] net/qede: fix to reject config with no Rx queue Rasesh Mody
3 siblings, 0 replies; 4+ messages in thread
From: Rasesh Mody @ 2017-11-24 20:35 UTC (permalink / raw)
To: dev; +Cc: Harish Patil, Dept-EngDPDKDev, stable
From: Harish Patil <harish.patil@cavium.com>
The qede firmware expects minimum one RX queue to be created, otherwise
it results in firmware exception. So a check is added to prevent that.
Fixes: ec94dbc57362 ("qede: add base driver")
Cc: stable@dpdk.org
Signed-off-by: Harish Patil <harish.patil@cavium.com>
---
drivers/net/qede/qede_ethdev.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c
index cc473d6..0128cec 100644
--- a/drivers/net/qede/qede_ethdev.c
+++ b/drivers/net/qede/qede_ethdev.c
@@ -1233,6 +1233,14 @@ static int qede_dev_configure(struct rte_eth_dev *eth_dev)
}
}
+ /* We need to have min 1 RX queue.There is no min check in
+ * rte_eth_dev_configure(), so we are checking it here.
+ */
+ if (eth_dev->data->nb_rx_queues == 0) {
+ DP_ERR(edev, "Minimum one RX queue is required\n");
+ return -EINVAL;
+ }
+
/* Sanity checks and throw warnings */
if (rxmode->enable_scatter)
eth_dev->data->scattered_rx = 1;
--
1.7.10.3
^ permalink raw reply [flat|nested] 4+ messages in thread
* [dpdk-stable] [PATCH v2 1/3] net/qede: fix to enable LRO over tunnels
[not found] <1511555745-13793-1-git-send-email-rasesh.mody@cavium.com>
2017-11-24 20:35 ` [dpdk-stable] [PATCH 1/5] net/qede: fix to enable LRO over tunnels Rasesh Mody
2017-11-24 20:35 ` [dpdk-stable] [PATCH 3/5] net/qede: fix to reject config with no Rx queue Rasesh Mody
@ 2017-12-14 6:36 ` Rasesh Mody
2017-12-14 6:36 ` [dpdk-stable] [PATCH v2 2/3] net/qede: fix to reject config with no Rx queue Rasesh Mody
3 siblings, 0 replies; 4+ messages in thread
From: Rasesh Mody @ 2017-12-14 6:36 UTC (permalink / raw)
To: ferruh.yigit; +Cc: Harish Patil, dev, Dept-EngDPDKDev, stable
From: Harish Patil <harish.patil@cavium.com>
Enable LRO feature to work with tunnel encapsulation protocols.
Fixes: 29540be7efce ("net/qede: support LRO/TSO offloads")
Cc: stable@dpdk.org
Signed-off-by: Harish Patil <harish.patil@cavium.com>
---
drivers/net/qede/qede_ethdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c
index 6f5ba2a..cc473d6 100644
--- a/drivers/net/qede/qede_ethdev.c
+++ b/drivers/net/qede/qede_ethdev.c
@@ -482,8 +482,8 @@ int qede_activate_vport(struct rte_eth_dev *eth_dev, bool flg)
/* Enable LRO in split mode */
sge_tpa_params->tpa_ipv4_en_flg = enable;
sge_tpa_params->tpa_ipv6_en_flg = enable;
- sge_tpa_params->tpa_ipv4_tunn_en_flg = false;
- sge_tpa_params->tpa_ipv6_tunn_en_flg = false;
+ sge_tpa_params->tpa_ipv4_tunn_en_flg = enable;
+ sge_tpa_params->tpa_ipv6_tunn_en_flg = enable;
/* set if tpa enable changes */
sge_tpa_params->update_tpa_en_flg = 1;
/* set if tpa parameters should be handled */
--
1.7.10.3
^ permalink raw reply [flat|nested] 4+ messages in thread
* [dpdk-stable] [PATCH v2 2/3] net/qede: fix to reject config with no Rx queue
[not found] <1511555745-13793-1-git-send-email-rasesh.mody@cavium.com>
` (2 preceding siblings ...)
2017-12-14 6:36 ` [dpdk-stable] [PATCH v2 1/3] net/qede: fix to enable LRO over tunnels Rasesh Mody
@ 2017-12-14 6:36 ` Rasesh Mody
3 siblings, 0 replies; 4+ messages in thread
From: Rasesh Mody @ 2017-12-14 6:36 UTC (permalink / raw)
To: ferruh.yigit; +Cc: Harish Patil, dev, Dept-EngDPDKDev, stable
From: Harish Patil <harish.patil@cavium.com>
The qede firmware expects minimum one RX queue to be created, otherwise
it results in firmware exception. So a check is added to prevent that.
Fixes: ec94dbc57362 ("qede: add base driver")
Cc: stable@dpdk.org
Signed-off-by: Harish Patil <harish.patil@cavium.com>
---
drivers/net/qede/qede_ethdev.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c
index cc473d6..0128cec 100644
--- a/drivers/net/qede/qede_ethdev.c
+++ b/drivers/net/qede/qede_ethdev.c
@@ -1233,6 +1233,14 @@ static int qede_dev_configure(struct rte_eth_dev *eth_dev)
}
}
+ /* We need to have min 1 RX queue.There is no min check in
+ * rte_eth_dev_configure(), so we are checking it here.
+ */
+ if (eth_dev->data->nb_rx_queues == 0) {
+ DP_ERR(edev, "Minimum one RX queue is required\n");
+ return -EINVAL;
+ }
+
/* Sanity checks and throw warnings */
if (rxmode->enable_scatter)
eth_dev->data->scattered_rx = 1;
--
1.7.10.3
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-12-14 6:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1511555745-13793-1-git-send-email-rasesh.mody@cavium.com>
2017-11-24 20:35 ` [dpdk-stable] [PATCH 1/5] net/qede: fix to enable LRO over tunnels Rasesh Mody
2017-11-24 20:35 ` [dpdk-stable] [PATCH 3/5] net/qede: fix to reject config with no Rx queue Rasesh Mody
2017-12-14 6:36 ` [dpdk-stable] [PATCH v2 1/3] net/qede: fix to enable LRO over tunnels Rasesh Mody
2017-12-14 6:36 ` [dpdk-stable] [PATCH v2 2/3] net/qede: fix to reject config with no Rx queue Rasesh Mody
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).