* [PATCH] net/ice: fix tso tunnel setting to not take effect
@ 2023-11-24 6:44 Kaiwen Deng
2023-11-24 7:50 ` lihuisong (C)
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Kaiwen Deng @ 2023-11-24 6:44 UTC (permalink / raw)
To: dev
Cc: stable, qiming.yang, yidingx.zhou, Kaiwen Deng, Qi Zhang,
Jerin Jacob, Tyler Retzlaff, Somnath Kotur, Ajit Khaparde,
Ferruh Yigit
The Tx offload capabilities of ICE ethdev doesn't include
tso tunnel, which will result in tso tunnel setting to
not take effect.
This commit will add tso tunnel capabilities in ice_dev_info_get().
Fixes: 295968d17407 ("ethdev: add namespace")
Cc: stable@dpdk.org
Signed-off-by: Kaiwen Deng <kaiwenx.deng@intel.com>
---
drivers/net/ice/ice_ethdev.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
index 3ccba4db80..fbc957fcd8 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -3876,7 +3876,11 @@ ice_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
RTE_ETH_TX_OFFLOAD_TCP_CKSUM |
RTE_ETH_TX_OFFLOAD_SCTP_CKSUM |
RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM |
- RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM;
+ RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM |
+ RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO |
+ RTE_ETH_TX_OFFLOAD_GRE_TNL_TSO |
+ RTE_ETH_TX_OFFLOAD_IPIP_TNL_TSO |
+ RTE_ETH_TX_OFFLOAD_GENEVE_TNL_TSO;
dev_info->flow_type_rss_offloads |= ICE_RSS_OFFLOAD_ALL;
}
--
2.34.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] net/ice: fix tso tunnel setting to not take effect
2023-11-24 6:44 [PATCH] net/ice: fix tso tunnel setting to not take effect Kaiwen Deng
@ 2023-11-24 7:50 ` lihuisong (C)
2023-11-24 8:02 ` David Marchand
2023-12-07 2:30 ` [PATCH v2] " Kaiwen Deng
2 siblings, 0 replies; 6+ messages in thread
From: lihuisong (C) @ 2023-11-24 7:50 UTC (permalink / raw)
To: Kaiwen Deng, dev
Cc: stable, qiming.yang, yidingx.zhou, Qi Zhang, Jerin Jacob,
Tyler Retzlaff, Somnath Kotur, Ajit Khaparde, Ferruh Yigit
please add Bugzilla ID
在 2023/11/24 14:44, Kaiwen Deng 写道:
> The Tx offload capabilities of ICE ethdev doesn't include
> tso tunnel, which will result in tso tunnel setting to
> not take effect.
>
> This commit will add tso tunnel capabilities in ice_dev_info_get().
>
> Fixes: 295968d17407 ("ethdev: add namespace")
> Cc: stable@dpdk.org
>
> Signed-off-by: Kaiwen Deng <kaiwenx.deng@intel.com>
> ---
> drivers/net/ice/ice_ethdev.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
> index 3ccba4db80..fbc957fcd8 100644
> --- a/drivers/net/ice/ice_ethdev.c
> +++ b/drivers/net/ice/ice_ethdev.c
> @@ -3876,7 +3876,11 @@ ice_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
> RTE_ETH_TX_OFFLOAD_TCP_CKSUM |
> RTE_ETH_TX_OFFLOAD_SCTP_CKSUM |
> RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM |
> - RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM;
> + RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM |
> + RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO |
> + RTE_ETH_TX_OFFLOAD_GRE_TNL_TSO |
> + RTE_ETH_TX_OFFLOAD_IPIP_TNL_TSO |
> + RTE_ETH_TX_OFFLOAD_GENEVE_TNL_TSO;
> dev_info->flow_type_rss_offloads |= ICE_RSS_OFFLOAD_ALL;
> }
>
correct,
Reviewed-by: Huisong Li <lihuisong@huawei.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] net/ice: fix tso tunnel setting to not take effect
2023-11-24 6:44 [PATCH] net/ice: fix tso tunnel setting to not take effect Kaiwen Deng
2023-11-24 7:50 ` lihuisong (C)
@ 2023-11-24 8:02 ` David Marchand
2023-12-07 2:30 ` [PATCH v2] " Kaiwen Deng
2 siblings, 0 replies; 6+ messages in thread
From: David Marchand @ 2023-11-24 8:02 UTC (permalink / raw)
To: Kaiwen Deng
Cc: dev, stable, qiming.yang, yidingx.zhou, Qi Zhang, Jerin Jacob,
Tyler Retzlaff, Somnath Kotur, Ajit Khaparde, Ferruh Yigit
On Fri, Nov 24, 2023 at 8:27 AM Kaiwen Deng <kaiwenx.deng@intel.com> wrote:
>
> The Tx offload capabilities of ICE ethdev doesn't include
> tso tunnel, which will result in tso tunnel setting to
> not take effect.
>
> This commit will add tso tunnel capabilities in ice_dev_info_get().
>
> Fixes: 295968d17407 ("ethdev: add namespace")
This Fixes: tag is wrong.
> Cc: stable@dpdk.org
>
> Signed-off-by: Kaiwen Deng <kaiwenx.deng@intel.com>
> ---
> drivers/net/ice/ice_ethdev.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
> index 3ccba4db80..fbc957fcd8 100644
> --- a/drivers/net/ice/ice_ethdev.c
> +++ b/drivers/net/ice/ice_ethdev.c
> @@ -3876,7 +3876,11 @@ ice_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
> RTE_ETH_TX_OFFLOAD_TCP_CKSUM |
> RTE_ETH_TX_OFFLOAD_SCTP_CKSUM |
> RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM |
> - RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM;
> + RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM |
> + RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO |
> + RTE_ETH_TX_OFFLOAD_GRE_TNL_TSO |
> + RTE_ETH_TX_OFFLOAD_IPIP_TNL_TSO |
> + RTE_ETH_TX_OFFLOAD_GENEVE_TNL_TSO;
> dev_info->flow_type_rss_offloads |= ICE_RSS_OFFLOAD_ALL;
> }
Is this tunnel + tso feature supported with vector drivers?
Is there some documentation to update to reflect this addition?
--
David Marchand
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] net/ice: fix tso tunnel setting to not take effect
2023-11-24 6:44 [PATCH] net/ice: fix tso tunnel setting to not take effect Kaiwen Deng
2023-11-24 7:50 ` lihuisong (C)
2023-11-24 8:02 ` David Marchand
@ 2023-12-07 2:30 ` Kaiwen Deng
2023-12-27 11:20 ` Zhang, Qi Z
2 siblings, 1 reply; 6+ messages in thread
From: Kaiwen Deng @ 2023-12-07 2:30 UTC (permalink / raw)
To: dev
Cc: stable, qiming.yang, yidingx.zhou, Kaiwen Deng, Qi Zhang,
Ting Xu, Kevin Liu, Ajit Khaparde, Andrew Rybchenko, Jerin Jacob,
Hemant Agrawal, Somnath Kotur
The Tx offload capabilities of ICE ethdev doesn't include
tso tunnel, which will result in tso tunnel setting to
not take effect.
The patch adds tunnel tso offload to ICE_TX_NO_VECTOR_FLAGS.
This commit will add tso tunnel capabilities in ice_dev_info_get().
Bugzilla ID: 1327
Fixes: d852fec1be63 ("net/ice: fix Tx offload path choice")
Fixes: 295968d17407 ("ethdev: add namespace")
Cc: stable@dpdk.org
Signed-off-by: Kaiwen Deng <kaiwenx.deng@intel.com>
---
drivers/net/ice/ice_ethdev.c | 6 +++++-
drivers/net/ice/ice_rxtx_vec_common.h | 4 ++++
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
index 3ccba4db80..fbc957fcd8 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -3876,7 +3876,11 @@ ice_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
RTE_ETH_TX_OFFLOAD_TCP_CKSUM |
RTE_ETH_TX_OFFLOAD_SCTP_CKSUM |
RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM |
- RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM;
+ RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM |
+ RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO |
+ RTE_ETH_TX_OFFLOAD_GRE_TNL_TSO |
+ RTE_ETH_TX_OFFLOAD_IPIP_TNL_TSO |
+ RTE_ETH_TX_OFFLOAD_GENEVE_TNL_TSO;
dev_info->flow_type_rss_offloads |= ICE_RSS_OFFLOAD_ALL;
}
diff --git a/drivers/net/ice/ice_rxtx_vec_common.h b/drivers/net/ice/ice_rxtx_vec_common.h
index 55840cf170..4b73465af5 100644
--- a/drivers/net/ice/ice_rxtx_vec_common.h
+++ b/drivers/net/ice/ice_rxtx_vec_common.h
@@ -251,6 +251,10 @@ ice_rxq_vec_setup_default(struct ice_rx_queue *rxq)
RTE_ETH_TX_OFFLOAD_MULTI_SEGS | \
RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM | \
RTE_ETH_TX_OFFLOAD_TCP_TSO | \
+ RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO | \
+ RTE_ETH_TX_OFFLOAD_GRE_TNL_TSO | \
+ RTE_ETH_TX_OFFLOAD_IPIP_TNL_TSO | \
+ RTE_ETH_TX_OFFLOAD_GENEVE_TNL_TSO | \
RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM)
#define ICE_TX_VECTOR_OFFLOAD ( \
--
2.34.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH v2] net/ice: fix tso tunnel setting to not take effect
2023-12-07 2:30 ` [PATCH v2] " Kaiwen Deng
@ 2023-12-27 11:20 ` Zhang, Qi Z
2024-01-22 11:43 ` Thomas Monjalon
0 siblings, 1 reply; 6+ messages in thread
From: Zhang, Qi Z @ 2023-12-27 11:20 UTC (permalink / raw)
To: Deng, KaiwenX, dev
Cc: stable, Yang, Qiming, Zhou, YidingX, Ting Xu, Kevin Liu,
Ajit Khaparde, Andrew Rybchenko, Jerin Jacob, Hemant Agrawal,
Somnath Kotur
> -----Original Message-----
> From: Deng, KaiwenX <kaiwenx.deng@intel.com>
> Sent: Thursday, December 7, 2023 10:31 AM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Yang, Qiming <qiming.yang@intel.com>; Zhou, YidingX
> <yidingx.zhou@intel.com>; Deng, KaiwenX <kaiwenx.deng@intel.com>; Zhang,
> Qi Z <qi.z.zhang@intel.com>; Ting Xu <ting.xu@intel.com>; Kevin Liu
> <kevinx.liu@intel.com>; Ajit Khaparde <ajit.khaparde@broadcom.com>;
> Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>; Jerin Jacob
> <jerinj@marvell.com>; Hemant Agrawal <hemant.agrawal@nxp.com>;
> Somnath Kotur <somnath.kotur@broadcom.com>
> Subject: [PATCH v2] net/ice: fix tso tunnel setting to not take effect
>
> The Tx offload capabilities of ICE ethdev doesn't include tso tunnel, which will
> result in tso tunnel setting to not take effect.
>
> The patch adds tunnel tso offload to ICE_TX_NO_VECTOR_FLAGS.
>
> This commit will add tso tunnel capabilities in ice_dev_info_get().
>
> Bugzilla ID: 1327
> Fixes: d852fec1be63 ("net/ice: fix Tx offload path choice")
> Fixes: 295968d17407 ("ethdev: add namespace")
> Cc: stable@dpdk.org
>
> Signed-off-by: Kaiwen Deng <kaiwenx.deng@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] net/ice: fix tso tunnel setting to not take effect
2023-12-27 11:20 ` Zhang, Qi Z
@ 2024-01-22 11:43 ` Thomas Monjalon
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2024-01-22 11:43 UTC (permalink / raw)
To: Deng, KaiwenX
Cc: dev, stable, Yang, Qiming, Zhou, YidingX, Ting Xu, Kevin Liu,
Ajit Khaparde, Andrew Rybchenko, Jerin Jacob, Hemant Agrawal,
Somnath Kotur, Zhang, Qi Z, david.marchand
> > The Tx offload capabilities of ICE ethdev doesn't include tso tunnel, which will
> > result in tso tunnel setting to not take effect.
> >
> > The patch adds tunnel tso offload to ICE_TX_NO_VECTOR_FLAGS.
> >
> > This commit will add tso tunnel capabilities in ice_dev_info_get().
> >
> > Bugzilla ID: 1327
> > Fixes: d852fec1be63 ("net/ice: fix Tx offload path choice")
> > Fixes: 295968d17407 ("ethdev: add namespace")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Kaiwen Deng <kaiwenx.deng@intel.com>
>
> Acked-by: Qi Zhang <qi.z.zhang@intel.com>
>
> Applied to dpdk-next-net-intel.
As said by David in v1, 295968d17407 ("ethdev: add namespace") is not a cause.
Removing while pulling.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-01-22 11:43 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-24 6:44 [PATCH] net/ice: fix tso tunnel setting to not take effect Kaiwen Deng
2023-11-24 7:50 ` lihuisong (C)
2023-11-24 8:02 ` David Marchand
2023-12-07 2:30 ` [PATCH v2] " Kaiwen Deng
2023-12-27 11:20 ` Zhang, Qi Z
2024-01-22 11:43 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).