* [dpdk-stable] [PATCH 1/3] net/sfc: stop periodic DMA if MAC stats upload fails
@ 2017-12-13 7:12 Andrew Rybchenko
2017-12-13 7:12 ` [dpdk-stable] [PATCH 2/3] net/sfc: fix multicast address list copy memory leak Andrew Rybchenko
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Andrew Rybchenko @ 2017-12-13 7:12 UTC (permalink / raw)
To: dev; +Cc: stable
Fixes: 3b257f7e6c0f ("net/sfc: request MAC stats upload immediately on port start")
Cc: stable@dpdk.org
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
Reviewed-by: Ivan Malov <ivan.malov@oktetlabs.ru>
---
drivers/net/sfc/sfc_port.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/sfc/sfc_port.c b/drivers/net/sfc/sfc_port.c
index c1466a7..55d8d46 100644
--- a/drivers/net/sfc/sfc_port.c
+++ b/drivers/net/sfc/sfc_port.c
@@ -279,10 +279,10 @@ sfc_port_start(struct sfc_adapter *sa)
(void)efx_mac_drain(sa->nic, B_TRUE);
fail_mac_drain:
+fail_mac_stats_upload:
(void)efx_mac_stats_periodic(sa->nic, &port->mac_stats_dma_mem,
0, B_FALSE);
-fail_mac_stats_upload:
fail_mac_stats_periodic:
fail_mcast_address_list_set:
fail_mac_filter_set:
--
2.7.4
^ permalink raw reply [flat|nested] 4+ messages in thread
* [dpdk-stable] [PATCH 2/3] net/sfc: fix multicast address list copy memory leak
2017-12-13 7:12 [dpdk-stable] [PATCH 1/3] net/sfc: stop periodic DMA if MAC stats upload fails Andrew Rybchenko
@ 2017-12-13 7:12 ` Andrew Rybchenko
2017-12-13 7:12 ` [dpdk-stable] [PATCH 3/3] net/sfc: fix DMA memory leak after kvarg processing failure Andrew Rybchenko
2017-12-16 2:04 ` [dpdk-stable] [PATCH 1/3] net/sfc: stop periodic DMA if MAC stats upload fails Ferruh Yigit
2 siblings, 0 replies; 4+ messages in thread
From: Andrew Rybchenko @ 2017-12-13 7:12 UTC (permalink / raw)
To: dev; +Cc: stable
Fixes: 295f647a38a2 ("net/sfc: set multicast address list in started state only")
Cc: stable@dpdk.org
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
Reviewed-by: Ivan Malov <ivan.malov@oktetlabs.ru>
---
drivers/net/sfc/sfc_port.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/sfc/sfc_port.c b/drivers/net/sfc/sfc_port.c
index 55d8d46..d71ec18 100644
--- a/drivers/net/sfc/sfc_port.c
+++ b/drivers/net/sfc/sfc_port.c
@@ -406,7 +406,10 @@ sfc_port_attach(struct sfc_adapter *sa)
fail_kvarg_stats_update_period_ms:
fail_mac_stats_dma_alloc:
rte_free(port->mac_stats_buf);
+
fail_mac_stats_buf_alloc:
+ rte_free(port->mcast_addrs);
+
fail_mcast_addr_list_buf_alloc:
sfc_log_init(sa, "failed %d", rc);
return rc;
@@ -422,6 +425,8 @@ sfc_port_detach(struct sfc_adapter *sa)
sfc_dma_free(sa, &port->mac_stats_dma_mem);
rte_free(port->mac_stats_buf);
+ rte_free(port->mcast_addrs);
+
sfc_log_init(sa, "done");
}
--
2.7.4
^ permalink raw reply [flat|nested] 4+ messages in thread
* [dpdk-stable] [PATCH 3/3] net/sfc: fix DMA memory leak after kvarg processing failure
2017-12-13 7:12 [dpdk-stable] [PATCH 1/3] net/sfc: stop periodic DMA if MAC stats upload fails Andrew Rybchenko
2017-12-13 7:12 ` [dpdk-stable] [PATCH 2/3] net/sfc: fix multicast address list copy memory leak Andrew Rybchenko
@ 2017-12-13 7:12 ` Andrew Rybchenko
2017-12-16 2:04 ` [dpdk-stable] [PATCH 1/3] net/sfc: stop periodic DMA if MAC stats upload fails Ferruh Yigit
2 siblings, 0 replies; 4+ messages in thread
From: Andrew Rybchenko @ 2017-12-13 7:12 UTC (permalink / raw)
To: dev; +Cc: stable
Fixes: e56fa9c23e7a ("net/sfc: add kvarg control for MAC statistics update period")
Cc: stable@dpdk.org
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
Reviewed-by: Ivan Malov <ivan.malov@oktetlabs.ru>
---
drivers/net/sfc/sfc_port.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/sfc/sfc_port.c b/drivers/net/sfc/sfc_port.c
index d71ec18..6cfd0e3 100644
--- a/drivers/net/sfc/sfc_port.c
+++ b/drivers/net/sfc/sfc_port.c
@@ -404,6 +404,8 @@ sfc_port_attach(struct sfc_adapter *sa)
return 0;
fail_kvarg_stats_update_period_ms:
+ sfc_dma_free(sa, &port->mac_stats_dma_mem);
+
fail_mac_stats_dma_alloc:
rte_free(port->mac_stats_buf);
--
2.7.4
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-stable] [PATCH 1/3] net/sfc: stop periodic DMA if MAC stats upload fails
2017-12-13 7:12 [dpdk-stable] [PATCH 1/3] net/sfc: stop periodic DMA if MAC stats upload fails Andrew Rybchenko
2017-12-13 7:12 ` [dpdk-stable] [PATCH 2/3] net/sfc: fix multicast address list copy memory leak Andrew Rybchenko
2017-12-13 7:12 ` [dpdk-stable] [PATCH 3/3] net/sfc: fix DMA memory leak after kvarg processing failure Andrew Rybchenko
@ 2017-12-16 2:04 ` Ferruh Yigit
2 siblings, 0 replies; 4+ messages in thread
From: Ferruh Yigit @ 2017-12-16 2:04 UTC (permalink / raw)
To: Andrew Rybchenko, dev; +Cc: stable
On 12/12/2017 11:12 PM, Andrew Rybchenko wrote:
> Fixes: 3b257f7e6c0f ("net/sfc: request MAC stats upload immediately on port start")
> Cc: stable@dpdk.org
>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> Reviewed-by: Ivan Malov <ivan.malov@oktetlabs.ru>
Series applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-12-16 2:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-13 7:12 [dpdk-stable] [PATCH 1/3] net/sfc: stop periodic DMA if MAC stats upload fails Andrew Rybchenko
2017-12-13 7:12 ` [dpdk-stable] [PATCH 2/3] net/sfc: fix multicast address list copy memory leak Andrew Rybchenko
2017-12-13 7:12 ` [dpdk-stable] [PATCH 3/3] net/sfc: fix DMA memory leak after kvarg processing failure Andrew Rybchenko
2017-12-16 2:04 ` [dpdk-stable] [PATCH 1/3] net/sfc: stop periodic DMA if MAC stats upload fails Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).