From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr60075.outbound.protection.outlook.com [40.107.6.75]) by dpdk.org (Postfix) with ESMTP id 9392A1B01F; Tue, 19 Dec 2017 18:14:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=E7Iui4Tf/ZLWW/islowLfkKIlCD75UFFcUrq4IXz0RM=; b=vhFdwL84ErsGzYu5DwSjlKGC2cJAPZa3qkInDl31U5Lpq+Zy3qrszCm0WyxRHYU3XxNGwoRsnRedegu7EZGXPztLQikNRYI8GQbZcWlw0PNwaXjP8ykJz+JETWxSjPC3iIiAGLiCpAyodd4hQqToruEJkGnXUh+qZ1qbcEkGVy8= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; Received: from mellanox.com (37.142.13.130) by HE1PR0502MB3659.eurprd05.prod.outlook.com (2603:10a6:7:85::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.323.15; Tue, 19 Dec 2017 17:14:51 +0000 From: Matan Azrad To: Gaetan Rivet Cc: dev@dpdk.org, stable@dpdk.org Date: Tue, 19 Dec 2017 17:14:27 +0000 Message-Id: <1513703669-29363-2-git-send-email-matan@mellanox.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1513703669-29363-1-git-send-email-matan@mellanox.com> References: <1513703669-29363-1-git-send-email-matan@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: VI1PR0102CA0086.eurprd01.prod.exchangelabs.com (2603:10a6:803:15::27) To HE1PR0502MB3659.eurprd05.prod.outlook.com (2603:10a6:7:85::17) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5e5539d7-df57-4504-f655-08d54704046d X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(5600026)(4604075)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(2017052603307); SRVR:HE1PR0502MB3659; X-Microsoft-Exchange-Diagnostics: 1; HE1PR0502MB3659; 3:fDejmBwRcimpdiMClVju7M5dfrsRHRYL4YYrVKCZ2upNpdFN+zajP1lvU0dfeYWCupi3rc5nb1qyHfMoIZ/X7dM8nIPBp8D3oLE7+K6zy0+c2kbuUjPtPiF4Q7wWDW8W2XMgTqWFXNF/VMC/QNlL3r+HScsXWBTrol0i322Otl+VCjOAKjIAt+v6J9jbvB5azt2vHCCK2cmfAy6i59yV/UWxRxPj4uzpry4Sw3abS7I6eC0pkEM4pJlhWZbSfB7H; 25:fnt4Tm2K+Ja/AIDWk1tV1gOCf5Ffo3VZVETZuSPHBNWcVXzzP3o46AKOWh0n7zTJ56XPLPNKfXHXnR6D4JUK3f48/eHqcD9wb70XtGixkrtVox/mM/N8eQfKOFRo6phoTAbafoSzRM8NDUXEOzDTJDSytwrb1BkKlS9xHI5lKyZvDo3hPAgBpghsfiIWHt/BmjJuOGgQ6QXiZ/odCCH89SsiT6H52MHzOY7doyffA/Wz89/OpWxgV+Oqik1NVEy6S2n3eu4A88EAzz4SrkAMqwzV1Xkook+7Z+qGky4H3TI1Fs9qnFnVLM2rvhYjjS57pknj17xIk2g6lwVM2gPaVA==; 31:xoLAnWBMc/X4GeI53E77o3b8xz/qAg3vaUDKUI9scPjH/CwyZAKiT8aU/pyt9feLWk/K+akZEomHlZikU4Ef4vFy/lW4dFSFcf6y2W/7kbe4yy1aEAcPG/vgE3qEXvyGS4SRMVJC3CfI2NZW/BquehJzKe6w8I9eIQFCundsSzWjUagOmLKkEQAWUtNe6QoNf+JyDVTWrwg7WiY4xuZ3akBi8A/+Z+DHceumXfOio80= X-MS-TrafficTypeDiagnostic: HE1PR0502MB3659: X-Microsoft-Exchange-Diagnostics: 1; HE1PR0502MB3659; 20:zdfY0Fw1o40QQN6EI/IMvD1+3jD+bqL8eOUImKP/gnFcJNfj5c559yKBuIdgg3168/4a/fos3m5iGdaYYfeMXmdkyqTTERWeU+DIh4NrWGFIibNEWxcCK4TVlsiD/iygB4O/sxLNE3ZBSJ4/S9M7fntjz7EhGtg3kBrEuwW7bazIfmqhiq+vhafFb9qnjEyUn+eoettE934di7bBFDzCxUGt1anpfxkmt0zO2ReB+yqq1v1jGWsKRwcqExGNetlWElnEEKObwbCDowvlntqkgYIpYhwSvD6JKZkeALecjxvGZalYr6wluCXbCwl+ql4e+dObNfEiXzrkKrgt/skVM1jAcfmbrQ2Uc8kQ+/M95ZbY7uemlbQnyLFryqKiDFxbBveNh5OX01HLnWcqKpp0sSzJTix3RMrUWRGkgPIVkRr7vF2QHo+uLX2ywaly4RLdY700g3vxjMBWIMUURYAcPryA5jgPtK32GIPcvXvFA9ZC9ixu9h3O2GETvcZ4cvtm; 4:D0VWEA4kWpzd92AxCwPjlLf6KYjRfLIHwCnGFcuq8x0F+0VDvpDZusXS901F5vYvYv8HS5a+gT6shRATRtKrM8FCePjrGIN3xY+oVPPp4J+rTIkRAYK7JiqZvmmYUXCsp29WNp74RdcD40YZMvLsGM55AwIhgVu3ToGUYV+1WK+ND2V76Xofsv8gPU+MmNkUVQR3cEFA3ByNs6ZqIqbOAH3m4CZP5qnbMwP8riEUmKtUFALr9h6+WgkJGwJfdy8jFBV8+l0qN5FOCTBboOBx4A== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3231023)(3002001)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123555025)(20161123560025)(20161123564025)(20161123558100)(6072148)(201708071742011); SRVR:HE1PR0502MB3659; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:HE1PR0502MB3659; X-Forefront-PRVS: 052670E5A4 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(376002)(346002)(39860400002)(396003)(189003)(199004)(478600001)(36756003)(16586007)(316002)(3846002)(7736002)(6116002)(97736004)(50226002)(25786009)(386003)(16526018)(59450400001)(33026002)(69596002)(68736007)(8936002)(2906002)(86362001)(81166006)(8676002)(81156014)(105586002)(50466002)(48376002)(106356001)(53936002)(51416003)(7696005)(52116002)(76176011)(6666003)(4720700003)(6916009)(4326008)(5660300001)(21086003)(305945005)(2950100002)(66066001)(47776003)(55016002); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0502MB3659; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; HE1PR0502MB3659; 23:xKsV0RxQAhuLO+7jQ6Rs7DhGnqwicC/o1EqshZW?= =?us-ascii?Q?hlgPfkKaAq4xFtMEyNSGuOx8Ixn95fakIP2Dr4+P1hBV598E3naxCIWjxANa?= =?us-ascii?Q?PmFrDhEQ0GHPhyVxkQKEkEgfJUNyXH6MR33ZB2EE25puXO4hHhGRuWGDD1Dk?= =?us-ascii?Q?xW721OzRKmiQOYNr7xQSBCBcOy82r4Ja9SiXad8QP01eFbmcsEjAwLLeaUM2?= =?us-ascii?Q?htQgIzWmmZXBtm9ldQPMwzzvls57SurtemOPoIz3cRf5Y6W7EdG3um/EVRGi?= =?us-ascii?Q?hovFmtIYwF14VwBX7ZJyxpDwZKtl5YN3ATR3LZalXRzXzdC1RyheaaVokE+A?= =?us-ascii?Q?C5127HVK16mMX+jczSf7FTmaucWMBSNfXd+NeF22YyzU4JILQbwfupeev2II?= =?us-ascii?Q?Rqr0bTq+G7nWhbFAGkSFNUUJGgMCWXcp9Q8IiX8ovKSMgt8/et7MYNLTwqIY?= =?us-ascii?Q?Xxv/Frq4QsSpwWt2dh6Jeyu7s3Ku7QWlW6F8sJW7BcAZzRVpquGyrl1tubkB?= =?us-ascii?Q?UEWNFaI8KySX8wZtXKU8icaf+QsCQn6a8LzSYQVNNukDE9ehw5s9D50oRDCB?= =?us-ascii?Q?NhxShCeIXpV9MZUwBRqpfNl/LSYnkCxzFDemYEfrT4rEf2La4XAXSoGrorx/?= =?us-ascii?Q?pCePFEQJ9jqKp+SLOucN8xh7bwzxV9r8oRwaIJEGkK1G4BjI+Fw1YhQVI0j9?= =?us-ascii?Q?qPbIpe6DhLCwm1dOoo660npqkdF3LXWTQkQlSsIffwx62tejnchxmKMvrdPN?= =?us-ascii?Q?Mj35osVAGCg5c1pR3mOAPaWnZan1QWrk4Rd2BzUjYN1nzSTL6/yB79F2fOgN?= =?us-ascii?Q?I6p4MYdcxg6cS3YUXFnmtrV1lSyTLEf6sEGz2WG/o6z7oEZyQwg98d71Aef6?= =?us-ascii?Q?w4XNA4HW2AVuw2mwka7Rk0iNA1FbPC0iWXRbJQ7J7/4jGovDLOwJ34HhvqAo?= =?us-ascii?Q?nVS+M0eOH2C6zHwp3/2pbwVrzP0XXz5NZqw9/zeWzq57aRKpOrol26VXzXgi?= =?us-ascii?Q?cGtbptiuX3OYogzS8BPvBIHpn6jUIGKNoJ/GBzIvVZcuew+3CFG7iEK1RScR?= =?us-ascii?Q?wp1Mw2o3cUt4WjeMbh/NSZ7r6wewNpMuqDseIt50s2/xd9nsdzduTvTWIT+x?= =?us-ascii?Q?JPIpFa9PWHpTyjJbIM1ATv35AZJAF1uWG?= X-Microsoft-Exchange-Diagnostics: 1; HE1PR0502MB3659; 6:vns2ELe/HmncylOlLcR5ePdpi8xJxnyA3Ium5gpXiw7RUu5BAJgyvFnBDfBNfHXB+IycO4DjIH10qAFK4+hHtZhH0WkUlxMEZ9joQFZHYXcFnQXa2lZiNGtHcQu5gp8V5T+IdaD+DCNloPZqr7Et5YoFNXqBBHR8rzkheJ1RKW/WEIWNy6bkwNd2t8fVMh999Ek9B7CBWEUmHHMlk7+oJBTgwGkZpgmSp5P+hWfnJE7C5hoRCtIVyL8zXhNF/yzoXGRcuWTek4GM8QYCgGCtmsdzo+77LyUHHAVOvetqgIIaT4vMYCEIgUuP3SengcB3+Z5neKtxyNoRHvRgGIX3vvZ2qaKSgdAMCV81c1kb4y8=; 5:QQWJvLIvtzKUrUHaNiBqQDJB8yN0GMKX9tVZdeSHi96TaafiGA9+tDUXB3ciJsSYNaNkrz6rBTwUsHsekYSxtKKuJKwMHKlVq3oSUVpFy511Jl94nkydNIPs89ueUVyuh2UJIfuP/OpbAC37qyb34CM9sv0c954iIbueo/EPN30=; 24:9wL6HwlhVs0reCrsVfsNLrov/KhMHr9fHSq8KhZBK7pYrwV6I8axEDOPtbOcobnzW0rWcjrl+wz0G7MrcFabrcUmpHZM+e4Hb9YJ58CLgM0=; 7:3XJaW+fb4XiU8BhVnI9YBuxZuR7EJKnKjewdcOBQ4wznzZ8yHwCzNUp7HTe5MPSMrTv4YydRXihLh0NbAxSESotfERy43kRVAbrYg5EueC8eEfxAgwwesi/7FmL7if4ZxBev8FdzxhRvLYMdZpiTdP2pfm2WQzP3D5kNLsDkuZsFf4Bx19yppzq0qcEnGg50ufwj1lxjEMn4BEwgldO1s6n2biykl/ak+52Ed6mWlT3NTaJTauZy3ho3baQFRdAI SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Dec 2017 17:14:51.5049 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5e5539d7-df57-4504-f655-08d54704046d X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0502MB3659 Subject: [dpdk-stable] [PATCH v3 1/3] net/failsafe: fix Rx safe check compiler hint X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Dec 2017 17:14:53 -0000 failsafe_rx_burst function is used when there are no sub-devices or at least one of them has been removed, on the other hand, when all the sub-devices are present, failsafe_rx_burst_fast function is used. So it's really expected that some of the sub-devices will be unsafe for Rx burst in failsafe_rx_burst execution. Remove unlikely compiler hint from fs_rx_unsafe calling. Fixes: a46f8d584eb8 ("net/failsafe: add fail-safe PMD") Cc: stable@dpdk.org Signed-off-by: Matan Azrad --- drivers/net/failsafe/failsafe_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/failsafe/failsafe_rxtx.c b/drivers/net/failsafe/failsafe_rxtx.c index 70157c8..178294c 100644 --- a/drivers/net/failsafe/failsafe_rxtx.c +++ b/drivers/net/failsafe/failsafe_rxtx.c @@ -111,7 +111,7 @@ if (i == priv->subs_tail) i = priv->subs_head; sdev = &priv->subs[i]; - if (unlikely(fs_rx_unsafe(sdev))) + if (fs_rx_unsafe(sdev)) continue; sub_rxq = ETH(sdev)->data->rx_queues[rxq->qid]; FS_ATOMIC_P(rxq->refcnt[sdev->sid]); -- 1.8.3.1