* [dpdk-stable] [PATCH v2 1/5] net/failsafe: fix invalid free
[not found] ` <20171222173846.20731-1-adrien.mazarguil@6wind.com>
@ 2017-12-22 18:01 ` Adrien Mazarguil
[not found] ` <1515509253-17834-1-git-send-email-matan@mellanox.com>
1 sibling, 0 replies; 6+ messages in thread
From: Adrien Mazarguil @ 2017-12-22 18:01 UTC (permalink / raw)
To: Ferruh Yigit; +Cc: dev, stable, Gaetan Rivet
rte_free() is not supposed to work with pointers returned by calloc().
Fixes: a0194d828100 ("net/failsafe: add flexible device definition")
Cc: stable@dpdk.org
Cc: Gaetan Rivet <gaetan.rivet@6wind.com>
Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
---
drivers/net/failsafe/failsafe_args.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/failsafe/failsafe_args.c b/drivers/net/failsafe/failsafe_args.c
index cfc83e365..ec63ac972 100644
--- a/drivers/net/failsafe/failsafe_args.c
+++ b/drivers/net/failsafe/failsafe_args.c
@@ -407,7 +407,7 @@ failsafe_args_free(struct rte_eth_dev *dev)
uint8_t i;
FOREACH_SUBDEV(sdev, i, dev) {
- rte_free(sdev->cmdline);
+ free(sdev->cmdline);
sdev->cmdline = NULL;
free(sdev->devargs.args);
sdev->devargs.args = NULL;
--
2.11.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-stable] [PATCH v3 1/8] net/failsafe: fix invalid free
[not found] ` <1515509253-17834-1-git-send-email-matan@mellanox.com>
@ 2018-01-09 14:47 ` Matan Azrad
2018-01-16 10:24 ` Gaëtan Rivet
[not found] ` <1516265026-6469-1-git-send-email-matan@mellanox.com>
1 sibling, 1 reply; 6+ messages in thread
From: Matan Azrad @ 2018-01-09 14:47 UTC (permalink / raw)
To: Ferruh Yigit
Cc: Thomas Monjalon, dev, stephen, Adrien Mazarguil, stable, Gaetan Rivet
From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
rte_free() is not supposed to work with pointers returned by calloc().
Fixes: a0194d828100 ("net/failsafe: add flexible device definition")
Cc: stable@dpdk.org
Cc: Gaetan Rivet <gaetan.rivet@6wind.com>
Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
---
drivers/net/failsafe/failsafe_args.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/failsafe/failsafe_args.c b/drivers/net/failsafe/failsafe_args.c
index cfc83e3..ec63ac9 100644
--- a/drivers/net/failsafe/failsafe_args.c
+++ b/drivers/net/failsafe/failsafe_args.c
@@ -407,7 +407,7 @@ typedef int (parse_cb)(struct rte_eth_dev *dev, const char *params,
uint8_t i;
FOREACH_SUBDEV(sdev, i, dev) {
- rte_free(sdev->cmdline);
+ free(sdev->cmdline);
sdev->cmdline = NULL;
free(sdev->devargs.args);
sdev->devargs.args = NULL;
--
1.8.3.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-stable] [PATCH v3 1/8] net/failsafe: fix invalid free
2018-01-09 14:47 ` [dpdk-stable] [PATCH v3 1/8] " Matan Azrad
@ 2018-01-16 10:24 ` Gaëtan Rivet
0 siblings, 0 replies; 6+ messages in thread
From: Gaëtan Rivet @ 2018-01-16 10:24 UTC (permalink / raw)
To: Matan Azrad
Cc: Ferruh Yigit, Thomas Monjalon, dev, stephen, Adrien Mazarguil, stable
Hi Matan,
On Tue, Jan 09, 2018 at 02:47:26PM +0000, Matan Azrad wrote:
> From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
>
> rte_free() is not supposed to work with pointers returned by calloc().
>
> Fixes: a0194d828100 ("net/failsafe: add flexible device definition")
> Cc: stable@dpdk.org
>
> Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>
> ---
> drivers/net/failsafe/failsafe_args.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/failsafe/failsafe_args.c b/drivers/net/failsafe/failsafe_args.c
> index cfc83e3..ec63ac9 100644
> --- a/drivers/net/failsafe/failsafe_args.c
> +++ b/drivers/net/failsafe/failsafe_args.c
> @@ -407,7 +407,7 @@ typedef int (parse_cb)(struct rte_eth_dev *dev, const char *params,
> uint8_t i;
>
> FOREACH_SUBDEV(sdev, i, dev) {
> - rte_free(sdev->cmdline);
> + free(sdev->cmdline);
> sdev->cmdline = NULL;
> free(sdev->devargs.args);
> sdev->devargs.args = NULL;
> --
> 1.8.3.1
>
--
Gaëtan Rivet
6WIND
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-stable] [PATCH v4 1/8] net/failsafe: fix invalid free
[not found] ` <1516265026-6469-1-git-send-email-matan@mellanox.com>
@ 2018-01-18 8:43 ` Matan Azrad
[not found] ` <1516269709-15252-1-git-send-email-matan@mellanox.com>
1 sibling, 0 replies; 6+ messages in thread
From: Matan Azrad @ 2018-01-18 8:43 UTC (permalink / raw)
To: Ferruh Yigit
Cc: Thomas Monjalon, dev, stephen, Adrien Mazarguil, stable, Gaetan Rivet
From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
rte_free() is not supposed to work with pointers returned by calloc().
Fixes: a0194d828100 ("net/failsafe: add flexible device definition")
Cc: stable@dpdk.org
Cc: Gaetan Rivet <gaetan.rivet@6wind.com>
Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>
---
drivers/net/failsafe/failsafe_args.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/failsafe/failsafe_args.c b/drivers/net/failsafe/failsafe_args.c
index cfc83e3..ec63ac9 100644
--- a/drivers/net/failsafe/failsafe_args.c
+++ b/drivers/net/failsafe/failsafe_args.c
@@ -407,7 +407,7 @@ typedef int (parse_cb)(struct rte_eth_dev *dev, const char *params,
uint8_t i;
FOREACH_SUBDEV(sdev, i, dev) {
- rte_free(sdev->cmdline);
+ free(sdev->cmdline);
sdev->cmdline = NULL;
free(sdev->devargs.args);
sdev->devargs.args = NULL;
--
1.8.3.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-stable] [PATCH v5 1/8] net/failsafe: fix invalid free
[not found] ` <1516269709-15252-1-git-send-email-matan@mellanox.com>
@ 2018-01-18 10:01 ` Matan Azrad
[not found] ` <1516283506-21198-1-git-send-email-matan@mellanox.com>
1 sibling, 0 replies; 6+ messages in thread
From: Matan Azrad @ 2018-01-18 10:01 UTC (permalink / raw)
To: Ferruh Yigit
Cc: Thomas Monjalon, dev, stephen, Adrien Mazarguil, stable, Gaetan Rivet
From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
rte_free() is not supposed to work with pointers returned by calloc().
Fixes: a0194d828100 ("net/failsafe: add flexible device definition")
Cc: stable@dpdk.org
Cc: Gaetan Rivet <gaetan.rivet@6wind.com>
Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>
---
drivers/net/failsafe/failsafe_args.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/failsafe/failsafe_args.c b/drivers/net/failsafe/failsafe_args.c
index cfc83e3..ec63ac9 100644
--- a/drivers/net/failsafe/failsafe_args.c
+++ b/drivers/net/failsafe/failsafe_args.c
@@ -407,7 +407,7 @@ typedef int (parse_cb)(struct rte_eth_dev *dev, const char *params,
uint8_t i;
FOREACH_SUBDEV(sdev, i, dev) {
- rte_free(sdev->cmdline);
+ free(sdev->cmdline);
sdev->cmdline = NULL;
free(sdev->devargs.args);
sdev->devargs.args = NULL;
--
1.8.3.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-stable] [PATCH v6 1/8] net/failsafe: fix invalid free
[not found] ` <1516283506-21198-1-git-send-email-matan@mellanox.com>
@ 2018-01-18 13:51 ` Matan Azrad
0 siblings, 0 replies; 6+ messages in thread
From: Matan Azrad @ 2018-01-18 13:51 UTC (permalink / raw)
To: Ferruh Yigit, Adrien Mazarguil, Gaetan Rivet; +Cc: Thomas Monjalon, dev, stable
From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
rte_free() is not supposed to work with pointers returned by calloc().
Fixes: a0194d828100 ("net/failsafe: add flexible device definition")
Cc: stable@dpdk.org
Cc: Gaetan Rivet <gaetan.rivet@6wind.com>
Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>
---
drivers/net/failsafe/failsafe_args.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/failsafe/failsafe_args.c b/drivers/net/failsafe/failsafe_args.c
index cfc83e3..ec63ac9 100644
--- a/drivers/net/failsafe/failsafe_args.c
+++ b/drivers/net/failsafe/failsafe_args.c
@@ -407,7 +407,7 @@ typedef int (parse_cb)(struct rte_eth_dev *dev, const char *params,
uint8_t i;
FOREACH_SUBDEV(sdev, i, dev) {
- rte_free(sdev->cmdline);
+ free(sdev->cmdline);
sdev->cmdline = NULL;
free(sdev->devargs.args);
sdev->devargs.args = NULL;
--
1.8.3.1
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-01-18 13:51 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20171218162443.12971-1-adrien.mazarguil@6wind.com>
[not found] ` <20171222173846.20731-1-adrien.mazarguil@6wind.com>
2017-12-22 18:01 ` [dpdk-stable] [PATCH v2 1/5] net/failsafe: fix invalid free Adrien Mazarguil
[not found] ` <1515509253-17834-1-git-send-email-matan@mellanox.com>
2018-01-09 14:47 ` [dpdk-stable] [PATCH v3 1/8] " Matan Azrad
2018-01-16 10:24 ` Gaëtan Rivet
[not found] ` <1516265026-6469-1-git-send-email-matan@mellanox.com>
2018-01-18 8:43 ` [dpdk-stable] [PATCH v4 " Matan Azrad
[not found] ` <1516269709-15252-1-git-send-email-matan@mellanox.com>
2018-01-18 10:01 ` [dpdk-stable] [PATCH v5 " Matan Azrad
[not found] ` <1516283506-21198-1-git-send-email-matan@mellanox.com>
2018-01-18 13:51 ` [dpdk-stable] [PATCH v6 " Matan Azrad
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).