* [dpdk-stable] [PATCH v2] net/i40e: fix flag sent to mac_address_write [not found] <1515624018-12555-1-git-send-email-iryzhov@nfware.com> @ 2018-01-11 10:07 ` Igor Ryzhov 2018-01-12 2:22 ` Xing, Beilei 2018-01-15 8:32 ` [dpdk-stable] [PATCH v3] " Igor Ryzhov 0 siblings, 2 replies; 6+ messages in thread From: Igor Ryzhov @ 2018-01-11 10:07 UTC (permalink / raw) To: dev; +Cc: beilei.xing, stable Use the same value as in Linux driver. Fixes: e18e01e92c29 ("i40e: support default MAC address setting") Cc: stable@dpdk.org Signed-off-by: Igor Ryzhov <iryzhov@nfware.com> --- v2: * fix checkpatch warning (long line) * fix commit subject * add Fixes line * CC to stable --- drivers/net/i40e/i40e_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 285d92b..055b9e8 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -10795,8 +10795,8 @@ static void i40e_set_default_mac_addr(struct rte_eth_dev *dev, return; } - /* Flags: 0x3 updates port address */ - i40e_aq_mac_address_write(hw, 0x3, mac_addr->addr_bytes, NULL); + i40e_aq_mac_address_write(hw, I40E_AQC_WRITE_TYPE_LAA_WOL, + mac_addr->addr_bytes, NULL); } static int -- 2.6.4 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-stable] [PATCH v2] net/i40e: fix flag sent to mac_address_write 2018-01-11 10:07 ` [dpdk-stable] [PATCH v2] net/i40e: fix flag sent to mac_address_write Igor Ryzhov @ 2018-01-12 2:22 ` Xing, Beilei 2018-01-15 8:32 ` Igor Ryzhov 2018-01-15 8:32 ` [dpdk-stable] [PATCH v3] " Igor Ryzhov 1 sibling, 1 reply; 6+ messages in thread From: Xing, Beilei @ 2018-01-12 2:22 UTC (permalink / raw) To: Igor Ryzhov, dev; +Cc: stable > -----Original Message----- > From: Igor Ryzhov [mailto:iryzhov@nfware.com] > Sent: Thursday, January 11, 2018 6:07 PM > To: dev@dpdk.org > Cc: Xing, Beilei <beilei.xing@intel.com>; stable@dpdk.org > Subject: [PATCH v2] net/i40e: fix flag sent to mac_address_write > > Use the same value as in Linux driver. Sorry for missing the comment in v1 patch, but could you please detail the commit log? > > Fixes: e18e01e92c29 ("i40e: support default MAC address setting") > Cc: stable@dpdk.org > > Signed-off-by: Igor Ryzhov <iryzhov@nfware.com> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-stable] [PATCH v2] net/i40e: fix flag sent to mac_address_write 2018-01-12 2:22 ` Xing, Beilei @ 2018-01-15 8:32 ` Igor Ryzhov 0 siblings, 0 replies; 6+ messages in thread From: Igor Ryzhov @ 2018-01-15 8:32 UTC (permalink / raw) To: Xing, Beilei; +Cc: dev, stable Sure. Sent v3. On Fri, Jan 12, 2018 at 5:22 AM, Xing, Beilei <beilei.xing@intel.com> wrote: > > > > -----Original Message----- > > From: Igor Ryzhov [mailto:iryzhov@nfware.com] > > Sent: Thursday, January 11, 2018 6:07 PM > > To: dev@dpdk.org > > Cc: Xing, Beilei <beilei.xing@intel.com>; stable@dpdk.org > > Subject: [PATCH v2] net/i40e: fix flag sent to mac_address_write > > > > Use the same value as in Linux driver. > > Sorry for missing the comment in v1 patch, but could you please detail the > commit log? > > > > > Fixes: e18e01e92c29 ("i40e: support default MAC address setting") > > Cc: stable@dpdk.org > > > > Signed-off-by: Igor Ryzhov <iryzhov@nfware.com> > ^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-stable] [PATCH v3] net/i40e: fix flag sent to mac_address_write 2018-01-11 10:07 ` [dpdk-stable] [PATCH v2] net/i40e: fix flag sent to mac_address_write Igor Ryzhov 2018-01-12 2:22 ` Xing, Beilei @ 2018-01-15 8:32 ` Igor Ryzhov 2018-01-15 10:18 ` [dpdk-stable] [dpdk-dev] " Xing, Beilei 1 sibling, 1 reply; 6+ messages in thread From: Igor Ryzhov @ 2018-01-15 8:32 UTC (permalink / raw) To: dev; +Cc: beilei.xing, stable Current flag is in wrong byte order. Use defined macro as it is done in Linux driver. Fixes: e18e01e92c29 ("i40e: support default MAC address setting") Cc: stable@dpdk.org Signed-off-by: Igor Ryzhov <iryzhov@nfware.com> --- v3: * fix commit message v2: * fix checkpatch warning (long line) * fix commit subject * add Fixes line * CC to stable --- drivers/net/i40e/i40e_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 285d92b..055b9e8 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -10795,8 +10795,8 @@ static void i40e_set_default_mac_addr(struct rte_eth_dev *dev, return; } - /* Flags: 0x3 updates port address */ - i40e_aq_mac_address_write(hw, 0x3, mac_addr->addr_bytes, NULL); + i40e_aq_mac_address_write(hw, I40E_AQC_WRITE_TYPE_LAA_WOL, + mac_addr->addr_bytes, NULL); } static int -- 2.6.4 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH v3] net/i40e: fix flag sent to mac_address_write 2018-01-15 8:32 ` [dpdk-stable] [PATCH v3] " Igor Ryzhov @ 2018-01-15 10:18 ` Xing, Beilei 2018-01-15 16:03 ` Zhang, Helin 0 siblings, 1 reply; 6+ messages in thread From: Xing, Beilei @ 2018-01-15 10:18 UTC (permalink / raw) To: Igor Ryzhov, dev; +Cc: stable > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Igor Ryzhov > Sent: Monday, January 15, 2018 4:32 PM > To: dev@dpdk.org > Cc: Xing, Beilei <beilei.xing@intel.com>; stable@dpdk.org > Subject: [dpdk-dev] [PATCH v3] net/i40e: fix flag sent to mac_address_write > > Current flag is in wrong byte order. > Use defined macro as it is done in Linux driver. > > Fixes: e18e01e92c29 ("i40e: support default MAC address setting") > Cc: stable@dpdk.org > > Signed-off-by: Igor Ryzhov <iryzhov@nfware.com> Acked-by: Beilei Xing <beilei.xing@intel.com> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH v3] net/i40e: fix flag sent to mac_address_write 2018-01-15 10:18 ` [dpdk-stable] [dpdk-dev] " Xing, Beilei @ 2018-01-15 16:03 ` Zhang, Helin 0 siblings, 0 replies; 6+ messages in thread From: Zhang, Helin @ 2018-01-15 16:03 UTC (permalink / raw) To: Xing, Beilei, Igor Ryzhov, dev; +Cc: stable > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Xing, Beilei > Sent: Monday, January 15, 2018 6:19 PM > To: Igor Ryzhov; dev@dpdk.org > Cc: stable@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3] net/i40e: fix flag sent to mac_address_write > > > > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Igor Ryzhov > > Sent: Monday, January 15, 2018 4:32 PM > > To: dev@dpdk.org > > Cc: Xing, Beilei <beilei.xing@intel.com>; stable@dpdk.org > > Subject: [dpdk-dev] [PATCH v3] net/i40e: fix flag sent to mac_address_write > > > > Current flag is in wrong byte order. > > Use defined macro as it is done in Linux driver. > > > > Fixes: e18e01e92c29 ("i40e: support default MAC address setting") > > Cc: stable@dpdk.org > > > > Signed-off-by: Igor Ryzhov <iryzhov@nfware.com> > Acked-by: Beilei Xing <beilei.xing@intel.com> Applied to dpdk-next-net-intel, with minor commit log changes. Thanks! /Helin ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-01-15 16:03 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1515624018-12555-1-git-send-email-iryzhov@nfware.com>
2018-01-11 10:07 ` [dpdk-stable] [PATCH v2] net/i40e: fix flag sent to mac_address_write Igor Ryzhov
2018-01-12 2:22 ` Xing, Beilei
2018-01-15 8:32 ` Igor Ryzhov
2018-01-15 8:32 ` [dpdk-stable] [PATCH v3] " Igor Ryzhov
2018-01-15 10:18 ` [dpdk-stable] [dpdk-dev] " Xing, Beilei
2018-01-15 16:03 ` Zhang, Helin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).