* [dpdk-stable] [PATCH] net/i40e/avf/ixgbe: remove unnecessary mbuf field initialization in PMD
@ 2018-01-19 3:02 Rosen Xu
2018-01-20 9:51 ` [dpdk-stable] [dpdk-dev] " Zhang, Helin
0 siblings, 1 reply; 2+ messages in thread
From: Rosen Xu @ 2018-01-19 3:02 UTC (permalink / raw)
To: beilei.xing, qi.z.zhang, wenzhuo.lu; +Cc: dev, stable
Set the value of m->refcnt to 1, m->nb_segs to 1 and m->next to NULL
when the mbuf is initialized or stored inside the mempool (unused).
All of these are done in rte_pktmbuf_pool_create() and rte_pktmbuf_prefree_seg().
So we remove the redundant code from i40e, ixgbe and avf module.
Fixes: 8f094a9ac5d7 ("mbuf: set mbuf fields while in pool")
Cc: stable@dpdk.org
Signed-off-by: Rosen Xu <rosen.xu@intel.com>
---
drivers/net/avf/avf_rxtx.c | 6 ------
drivers/net/i40e/i40e_rxtx.c | 6 ------
drivers/net/ixgbe/ixgbe_rxtx.c | 1 -
3 files changed, 13 deletions(-)
diff --git a/drivers/net/avf/avf_rxtx.c b/drivers/net/avf/avf_rxtx.c
index e0c4583..b9051d6 100644
--- a/drivers/net/avf/avf_rxtx.c
+++ b/drivers/net/avf/avf_rxtx.c
@@ -221,10 +221,7 @@
return -ENOMEM;
}
- rte_mbuf_refcnt_set(mbuf, 1);
- mbuf->next = NULL;
mbuf->data_off = RTE_PKTMBUF_HEADROOM;
- mbuf->nb_segs = 1;
mbuf->port = rxq->port_id;
dma_addr =
@@ -1239,10 +1236,7 @@
rte_prefetch0(rxep[i + 1]);
mb = rxep[i];
- rte_mbuf_refcnt_set(mb, 1);
- mb->next = NULL;
mb->data_off = RTE_PKTMBUF_HEADROOM;
- mb->nb_segs = 1;
mb->port = rxq->port_id;
dma_addr = rte_cpu_to_le_64(rte_mbuf_data_iova_default(mb));
rxdp[i].read.hdr_addr = 0;
diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c
index 23256b7..b578957 100644
--- a/drivers/net/i40e/i40e_rxtx.c
+++ b/drivers/net/i40e/i40e_rxtx.c
@@ -550,10 +550,7 @@
rte_prefetch0(rxep[i + 1].mbuf);
mb = rxep[i].mbuf;
- rte_mbuf_refcnt_set(mb, 1);
- mb->next = NULL;
mb->data_off = RTE_PKTMBUF_HEADROOM;
- mb->nb_segs = 1;
mb->port = rxq->port_id;
dma_addr = rte_cpu_to_le_64(\
rte_mbuf_data_iova_default(mb));
@@ -2411,10 +2408,7 @@
return -ENOMEM;
}
- rte_mbuf_refcnt_set(mbuf, 1);
- mbuf->next = NULL;
mbuf->data_off = RTE_PKTMBUF_HEADROOM;
- mbuf->nb_segs = 1;
mbuf->port = rxq->port_id;
dma_addr =
diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c
index 4b38247..72da571 100644
--- a/drivers/net/ixgbe/ixgbe_rxtx.c
+++ b/drivers/net/ixgbe/ixgbe_rxtx.c
@@ -1629,7 +1629,6 @@ uint16_t ixgbe_xmit_fixed_burst_vec(void *tx_queue, struct rte_mbuf **tx_pkts,
mb->port = rxq->port_id;
}
- rte_mbuf_refcnt_set(mb, 1);
mb->data_off = RTE_PKTMBUF_HEADROOM;
/* populate the descriptors */
--
1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH] net/i40e/avf/ixgbe: remove unnecessary mbuf field initialization in PMD
2018-01-19 3:02 [dpdk-stable] [PATCH] net/i40e/avf/ixgbe: remove unnecessary mbuf field initialization in PMD Rosen Xu
@ 2018-01-20 9:51 ` Zhang, Helin
0 siblings, 0 replies; 2+ messages in thread
From: Zhang, Helin @ 2018-01-20 9:51 UTC (permalink / raw)
To: Xu, Rosen, Xing, Beilei, Zhang, Qi Z, Lu, Wenzhuo; +Cc: dev, stable
Hi Rosen
You may need to split the patches into 3, one per each PMD.
Also please get it reviewed by maintainers, and do/fix any patchwork check issues.
Thanks!
/Helin
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Rosen Xu
> Sent: Friday, January 19, 2018 11:02 AM
> To: Xing, Beilei; Zhang, Qi Z; Lu, Wenzhuo
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/i40e/avf/ixgbe: remove unnecessary mbuf
> field initialization in PMD
>
> Set the value of m->refcnt to 1, m->nb_segs to 1 and m->next to NULL when
> the mbuf is initialized or stored inside the mempool (unused).
> All of these are done in rte_pktmbuf_pool_create() and
> rte_pktmbuf_prefree_seg().
> So we remove the redundant code from i40e, ixgbe and avf module.
>
> Fixes: 8f094a9ac5d7 ("mbuf: set mbuf fields while in pool")
> Cc: stable@dpdk.org
>
> Signed-off-by: Rosen Xu <rosen.xu@intel.com>
> ---
> drivers/net/avf/avf_rxtx.c | 6 ------
> drivers/net/i40e/i40e_rxtx.c | 6 ------
> drivers/net/ixgbe/ixgbe_rxtx.c | 1 -
> 3 files changed, 13 deletions(-)
>
> diff --git a/drivers/net/avf/avf_rxtx.c b/drivers/net/avf/avf_rxtx.c index
> e0c4583..b9051d6 100644
> --- a/drivers/net/avf/avf_rxtx.c
> +++ b/drivers/net/avf/avf_rxtx.c
> @@ -221,10 +221,7 @@
> return -ENOMEM;
> }
>
> - rte_mbuf_refcnt_set(mbuf, 1);
> - mbuf->next = NULL;
> mbuf->data_off = RTE_PKTMBUF_HEADROOM;
> - mbuf->nb_segs = 1;
> mbuf->port = rxq->port_id;
>
> dma_addr =
> @@ -1239,10 +1236,7 @@
> rte_prefetch0(rxep[i + 1]);
>
> mb = rxep[i];
> - rte_mbuf_refcnt_set(mb, 1);
> - mb->next = NULL;
> mb->data_off = RTE_PKTMBUF_HEADROOM;
> - mb->nb_segs = 1;
> mb->port = rxq->port_id;
> dma_addr =
> rte_cpu_to_le_64(rte_mbuf_data_iova_default(mb));
> rxdp[i].read.hdr_addr = 0;
> diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c index
> 23256b7..b578957 100644
> --- a/drivers/net/i40e/i40e_rxtx.c
> +++ b/drivers/net/i40e/i40e_rxtx.c
> @@ -550,10 +550,7 @@
> rte_prefetch0(rxep[i + 1].mbuf);
>
> mb = rxep[i].mbuf;
> - rte_mbuf_refcnt_set(mb, 1);
> - mb->next = NULL;
> mb->data_off = RTE_PKTMBUF_HEADROOM;
> - mb->nb_segs = 1;
> mb->port = rxq->port_id;
> dma_addr = rte_cpu_to_le_64(\
> rte_mbuf_data_iova_default(mb));
> @@ -2411,10 +2408,7 @@
> return -ENOMEM;
> }
>
> - rte_mbuf_refcnt_set(mbuf, 1);
> - mbuf->next = NULL;
> mbuf->data_off = RTE_PKTMBUF_HEADROOM;
> - mbuf->nb_segs = 1;
> mbuf->port = rxq->port_id;
>
> dma_addr =
> diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c
> index 4b38247..72da571 100644
> --- a/drivers/net/ixgbe/ixgbe_rxtx.c
> +++ b/drivers/net/ixgbe/ixgbe_rxtx.c
> @@ -1629,7 +1629,6 @@ uint16_t ixgbe_xmit_fixed_burst_vec(void
> *tx_queue, struct rte_mbuf **tx_pkts,
> mb->port = rxq->port_id;
> }
>
> - rte_mbuf_refcnt_set(mb, 1);
> mb->data_off = RTE_PKTMBUF_HEADROOM;
>
> /* populate the descriptors */
> --
> 1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-20 9:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-19 3:02 [dpdk-stable] [PATCH] net/i40e/avf/ixgbe: remove unnecessary mbuf field initialization in PMD Rosen Xu
2018-01-20 9:51 ` [dpdk-stable] [dpdk-dev] " Zhang, Helin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).