patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [DPDK 1/4] net/i40e: fix VF RX queue interrupt enabling
@ 2018-01-23  2:43 Wenzhuo Lu
  2018-01-23  2:43 ` [dpdk-stable] [DPDK 2/4] net/ixgbe: " Wenzhuo Lu
  2018-01-23  2:43 ` [dpdk-stable] [DPDK 3/4] net/e1000: " Wenzhuo Lu
  0 siblings, 2 replies; 3+ messages in thread
From: Wenzhuo Lu @ 2018-01-23  2:43 UTC (permalink / raw)
  To: qabuild; +Cc: Wenzhuo Lu, stable

When using UIO, after enabling the interrupt to get the PF
message, VF RX queue interrupt is not working.
It's expected, as UIO doesn't support multiple interrupt.
So, PMD should not try to enable RX queue interrupt. Then
APP can know the RX queue interrupt is not enabled and only
choose the polling mode.

Fixes: ae19955e7c86 ("i40evf: support reporting PF reset")
CC: stable@dpdk.org

Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
---
 drivers/net/i40e/i40e_ethdev_vf.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c
index 0cca0d3..60783f9 100644
--- a/drivers/net/i40e/i40e_ethdev_vf.c
+++ b/drivers/net/i40e/i40e_ethdev_vf.c
@@ -1976,7 +1976,8 @@ static int eth_i40evf_pci_remove(struct rte_pci_device *pci_dev)
 					dev->data->nb_tx_queues);
 
 	/* check and configure queue intr-vector mapping */
-	if (dev->data->dev_conf.intr_conf.rxq != 0) {
+	if (rte_intr_cap_multiple(intr_handle) &&
+	    dev->data->dev_conf.intr_conf.rxq) {
 		intr_vector = dev->data->nb_rx_queues;
 		if (rte_intr_efd_enable(intr_handle, intr_vector))
 			return -1;
-- 
1.9.3

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [dpdk-stable] [DPDK 2/4] net/ixgbe: fix VF RX queue interrupt enabling
  2018-01-23  2:43 [dpdk-stable] [DPDK 1/4] net/i40e: fix VF RX queue interrupt enabling Wenzhuo Lu
@ 2018-01-23  2:43 ` Wenzhuo Lu
  2018-01-23  2:43 ` [dpdk-stable] [DPDK 3/4] net/e1000: " Wenzhuo Lu
  1 sibling, 0 replies; 3+ messages in thread
From: Wenzhuo Lu @ 2018-01-23  2:43 UTC (permalink / raw)
  To: qabuild; +Cc: Wenzhuo Lu, stable

When using UIO, after enabling the interrupt to get the PF
message, VF RX queue interrupt is not working.
It's expected, as UIO doesn't support multiple interrupt.
So, PMD should not try to enable RX queue interrupt. Then
APP can know the RX queue interrupt is not enabled and only
choose the polling mode.

Fixes: 77234603fba0 ("net/ixgbe: support VF mailbox interrupt for link up/down")
CC: stable@dpdk.org

Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
---
 drivers/net/ixgbe/ixgbe_ethdev.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index 4f4334d..91ff54c 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -5033,7 +5033,8 @@ static int ixgbevf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev,
 	ixgbevf_dev_rxtx_start(dev);
 
 	/* check and configure queue intr-vector mapping */
-	if (dev->data->dev_conf.intr_conf.rxq != 0) {
+	if (rte_intr_cap_multiple(intr_handle) &&
+	    dev->data->dev_conf.intr_conf.rxq) {
 		/* According to datasheet, only vector 0/1/2 can be used,
 		 * now only one vector is used for Rx queue
 		 */
-- 
1.9.3

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [dpdk-stable] [DPDK 3/4] net/e1000: fix VF RX queue interrupt enabling
  2018-01-23  2:43 [dpdk-stable] [DPDK 1/4] net/i40e: fix VF RX queue interrupt enabling Wenzhuo Lu
  2018-01-23  2:43 ` [dpdk-stable] [DPDK 2/4] net/ixgbe: " Wenzhuo Lu
@ 2018-01-23  2:43 ` Wenzhuo Lu
  1 sibling, 0 replies; 3+ messages in thread
From: Wenzhuo Lu @ 2018-01-23  2:43 UTC (permalink / raw)
  To: qabuild; +Cc: Wenzhuo Lu, stable

When using UIO, after enabling the interrupt to get the PF
message, VF RX queue interrupt is not working.
It's expected, as UIO doesn't support multiple interrupt.
So, PMD should not try to enable RX queue interrupt. Then
APP can know the RX queue interrupt is not enabled and only
choose the polling mode.

Fixes: 316f4f1adc2e ("net/igb: support VF mailbox interrupt for link up/down")
CC: stable@dpdk.org

Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
---
 drivers/net/e1000/igb_ethdev.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c
index 077e094..15347df 100644
--- a/drivers/net/e1000/igb_ethdev.c
+++ b/drivers/net/e1000/igb_ethdev.c
@@ -3295,7 +3295,8 @@ static int eth_igbvf_link_update(struct e1000_hw *hw)
 	}
 
 	/* check and configure queue intr-vector mapping */
-	if (dev->data->dev_conf.intr_conf.rxq != 0) {
+	if (rte_intr_cap_multiple(intr_handle) &&
+	    dev->data->dev_conf.intr_conf.rxq) {
 		intr_vector = dev->data->nb_rx_queues;
 		ret = rte_intr_efd_enable(intr_handle, intr_vector);
 		if (ret)
-- 
1.9.3

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-01-23  2:41 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-23  2:43 [dpdk-stable] [DPDK 1/4] net/i40e: fix VF RX queue interrupt enabling Wenzhuo Lu
2018-01-23  2:43 ` [dpdk-stable] [DPDK 2/4] net/ixgbe: " Wenzhuo Lu
2018-01-23  2:43 ` [dpdk-stable] [DPDK 3/4] net/e1000: " Wenzhuo Lu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).