From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr60089.outbound.protection.outlook.com [40.107.6.89]) by dpdk.org (Postfix) with ESMTP id 58F15A493 for ; Wed, 24 Jan 2018 00:30:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=w9q14PskWTdYmyiQcksCQEbkux7bGHzEuDQmkZmLiHw=; b=O2rWhq3kEtzk+33UBnMaKkSLMBYllEZH4ybIMFvpbpJn/KvP55pSic8EgajDL0NTioM7n7s/IpZXu8cGIepT6dMdMrjpkzDpoc/UVS2KREjoOdKCEEqorMdz6EZr93mse9ufqpuQ/kJWzQZ218Dm4DanWwWXli1fhBM8l3xXtBA= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=ophirmu@mellanox.com; Received: from mellanox.com (37.142.13.130) by AM0PR0502MB3873.eurprd05.prod.outlook.com (2603:10a6:208:20::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.444.14; Tue, 23 Jan 2018 23:30:13 +0000 From: Ophir Munk To: Ophir Munk Cc: stable@dpdk.org Date: Tue, 23 Jan 2018 23:29:45 +0000 Message-Id: <1516750185-26455-1-git-send-email-ophirmu@mellanox.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: VI1PR0401CA0001.eurprd04.prod.outlook.com (2603:10a6:800:4a::11) To AM0PR0502MB3873.eurprd05.prod.outlook.com (2603:10a6:208:20::15) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 608fb022-264c-4721-3101-08d562b94111 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:AM0PR0502MB3873; X-Microsoft-Exchange-Diagnostics: 1; AM0PR0502MB3873; 3:Wu23UsK1IBtx+sEEzTGxJ3Rn8p4GXABpu5G2p4jbakVQIhjPUwZwxppASDdlnkMX+o6MpQfYm8mPmQL9UF0Yc81A09uetiOF9ADL/yZ6xkGaoCMxMFfd/y6gnbNrV0Jcsx9ds2FvZHEofzsYzacmlyy5QUi/RidccmmbzAyO1BOfk9lRikYP31dIc8OzBVihQ0D9zE3vJMVbkZZvf4PGu15GS/IA+/6j6RE1r6wuoyudl5+QlcXxYghWoGfju+zX; 25:VV/W3H+81+uSe/5SvvSKYZeAg82Et4HNVSFFQ7RO9VLCTq2v6FDPGEiBzOXoY7CXFS2snHiAJeYPkbOpklZFzPcS0cumTNOfBtlOnCzguVEFND/csN7ZNRtv8ntkgcb2otcVVEfrFPWSZjtzWAOcX40uDgaCi9KYohXGOxLL64Zm9m12pe6BzU8b6lb0wRdqdFH7Rok4DXUwkgHCkjewL1olRfD5UFP3UPkOJAiU+DxGi1avRNmYmP80EsGxUe8r6/SriN60+mwcfOH4OfxMFh4cc02yAO7TVHPTWWpEJ50uROWhTUVETuPh6PmC/VmwHKcr7q0z/k0zmVVA8T+Fsg==; 31:6LcigLWSE26EJejWgpXkyovi1r/jGK86XfE+JqLV7HZofcKCxBvzzOfGpdn4bTllQ4EF6ccpTjHtk/v9O7dljLSP2Hgw7gPmYHSsJB11QbSGZ+4dZvwJD0ihsdb8w52tqPCCn42YLzkLlOwJ/SyJTkhvX5MZ+M9D5RZjkM/p3o0Gz0kKOFiWIHxE8g/0FJRZH9BFfTOvouUbSoH5CQFAx907RTEkN12ZlsPCBC/1K2c= X-MS-TrafficTypeDiagnostic: AM0PR0502MB3873: X-Microsoft-Exchange-Diagnostics: 1; AM0PR0502MB3873; 20:VSkwZE2cjqr1gOLxGmWxJ5oXcr9WOZXnYefEDoLwlC11iNI1zfj1RCzyrKVYPxie5K1Ux9vTh0DpAxh1gKM4FuSGKHoFt40NM8HGtaMTadpiXpWgPeSCZ7WhkFnSyMBBcCpFDUvzKvSEetjz5vDNbNyMPT5KC6pNi8PesH8/Bczw46z1IgpUUNH4CZNMX2jcjK2wZIVFwOZtqrF9zacAX7pq7Kpfy/kukguVz5rw+zdETCF2oWuQu/gqAOAW7S4m7uBGxmk7eKwQ1Lc85KQycizOODFRONxj3GZLD6qDbK1Y0LHB950790SWnM8ejWdbeOazvBKjTHGZplHeCXcd46EB5fUpp/l+0bFghl/ZxZYJqQ/3F4IZDM6c4ugltnp5HHjtLD5CTVCtdMUJDyK7JDVrRpSF1qSv7G6LJT57R8PCficRs15S+ujkTO9GQTuhZfl4sIDCx68dVCwcUBpQXIAIAqMeKXZU+CPP4GqcLpMJCJh+1w4NmUaUxIkW6674; 4:M0wAADUtXeWTNTQ9vje+h8ht6iUXUzFWxhTsohVb/LdPFOFqElBIsw18yWspvnhe9hWdn6i1VaDYhng7DXEq+uNty/tlon9yelEjWMjht/e6OFZe1VS5JOdGbU7C3jHEXEx8HJaKGYoGnndMrFOY1b4e1vxFS3XFR0BtNth3rchQMnu0FfYuBUiPoIrVkw35AtmROfvyRzGa2D/IONYLoVSFccURkuDf57Wxzxxhb1ukE7SF7YgsuBCz2yKYqy6m9Y2bp5Yq6kR/LKFEIlKpHA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(93001095)(3231023)(2400081)(944501161)(6055026)(6041288)(20161123558120)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(6072148)(201708071742011); SRVR:AM0PR0502MB3873; BCL:0; PCL:0; RULEID:; SRVR:AM0PR0502MB3873; X-Forefront-PRVS: 05610E64EE X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(366004)(396003)(39380400002)(39840400004)(346002)(189003)(199004)(81166006)(81156014)(4326008)(48376002)(50466002)(33026002)(16586007)(478600001)(316002)(7049001)(8676002)(4720700003)(6862004)(6666003)(68736007)(5660300001)(86362001)(6200100001)(16526018)(53936002)(37006003)(52116002)(386003)(305945005)(7696005)(26005)(59450400001)(66066001)(55016002)(106356001)(47776003)(7736002)(8936002)(25786009)(50226002)(105586002)(3846002)(51416003)(36756003)(21086003)(6116002)(97736004)(69596002)(2906002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB3873; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM0PR0502MB3873; 23:v7AUb9Xtt7MRwDJmKnMVsNbyO+g9a3aCuFCI0he?= =?us-ascii?Q?IwdeMa1uqfDr7x3l57w7oMH0I1oTCMP2aFekKKGFoqzuSDXzjqQmdrgeoSZA?= =?us-ascii?Q?2EkN3ynhQv+4fvfo88ELgMFTySAEtAQ0jqIlY27y1a2DTXM3nT7zQEZc7Ins?= =?us-ascii?Q?86ayDeS+EESN3eNf0wApb80icMFXxEVBW9hcX79TfZ8OG66wMWV18a9eMJv1?= =?us-ascii?Q?iSWGJeXkOPR6XhnFMZkxq/e4/rnRVHZOq8Me4tp6dUcsCsYcBLi4DX9ETteO?= =?us-ascii?Q?Ij0lCwJG7BHko5n8S8+5HjqJPLgL3DTRc0fKDgdU+K9sOAZit3LAgq0c8PSr?= =?us-ascii?Q?e8wp/+6pRFzUkR3kMgCAE/+W67r6POzTL3PaGvTHNDRH+Gag1XbNMG+namnO?= =?us-ascii?Q?m75Kr2bFH3PTpwVWk8XbMeHtpPVBzwjXIOoW/pvxwRvohppsb44FcHLfuswz?= =?us-ascii?Q?LO/WDgSWY84SQAs8FkuS0T0cuKRMY7U83L8mFnfy3FWik4R1KIp5cjPe4RWP?= =?us-ascii?Q?18Urt25p1xRh7ZcciVVZAEsicVe7sIgPNiCf1vn0vGT9eejuh0orWnSvb7FM?= =?us-ascii?Q?f0HGeS7SzkT/V1nLb9CjunX+U9U/Gdjo5DbVERtUHk3sJ3w0tJxvAlFFGVTc?= =?us-ascii?Q?cGrWUdpmUcBzevw2YLygPJGfJyzEomzSXBY2SDB1RHE2TgP0z97DaymtO4UW?= =?us-ascii?Q?yPNfHmI8CAbRE952pnp6N9PBOJ2y2DGwgHjobjuLYWEFPBhlBzpcjgtIUjmZ?= =?us-ascii?Q?W8miyb874g/Fxt6v9ym4TT+jZRTKoR/LYomYrJVUSBgx9JGRaHWWid99Hu3u?= =?us-ascii?Q?ccDE4BVKGHBNsWujvrWWdY5nmCtkFm13BZ6smLzDw4UARzcePnds4ALoJ0n0?= =?us-ascii?Q?n1U7qWsRBXIfthgJfGkW8WSQnD/pOveUMmMzcZml9SdS+3s2v4lPNhyDj3KQ?= =?us-ascii?Q?EI7aBQh4J6nw3GiWgZHKB4PtsZwLmop1zVQRFiZL27kR5NJfe5qewKgL4diE?= =?us-ascii?Q?AonXd/MMxLur2yYIEq0XFY7JEVjBz7d10puaLumlao8BQVx1JfCjGMyIgote?= =?us-ascii?Q?BfoZjcAChDLUA5aX7Udgn/JUkm7hOlKyn6Sokxp7/ItV0Jcl1B94m/q082p9?= =?us-ascii?Q?Z7qE0pM/1BzCqfNCs3FsQwPLKE73G3IFx0d20BKQ17vN2gXdlC5Z03xGg/bB?= =?us-ascii?Q?+F+Mhx/THXknHx0ZUsiRAuOO9mP3hK1Pe16dX?= X-Microsoft-Exchange-Diagnostics: 1; AM0PR0502MB3873; 6:wgLWZRjXGYgmgrHlzR1pTm+D5Aj2462NVas6iM58h6eAk6xDBrpWV/KZy+IDjNboBAtz9KRfr8qPSUKau5Z1O7xIqwQ0W+ELHS6GOi4fai4Q30iYknXAF4pznxJQf4/lo8nHK1+IhnOM38z44LOpogp1IRm73K0YdgTSp77IGDYTzQMSIfsiEALJQsTH+tm6Yk83IrQ7vsVK1d8fR1kpvBHkcvipCKwAwlPnOx+pLSfSp/nBejNVG8gHUHlwuB08Zb6/leQI94g6v4WhDzHxXFNuz3JF1yVRgopuUakdNCu8/+Blc7Ela4Zn4RUHQaxLgFOnR9E/1vEJ5RyJQst4DWxd6SBNzcRWeJEaXe+4Go8=; 5:5sEj4rZwbfDIlnKn9ESH5cBzl4IvtkN1LNJWRXOq7aFq38V7SE9j4X+NkZm55wG6CWKbN1ZVjQroCRUU1kVow93EDfUFe6wWVZCKDqUsoyaHYjcWTyffVODi7iv/NiXvSXoE9wnRPmez4ZMF6ikUfSAzQ2lMmFwUajUjY962POk=; 24:OuqdNdjFJAkpzYmD7dYJUe0fatLLZQ0tbc52qQoGb5pKdvUlXsxg4hohmXuKNmWhg+j57gLXxv0E7B5z1b66wwtFIE7OT/RSewd8JAj6kSM=; 7:RkaGheyZm91d8jYv4XzA9TguOlJ8PD+7FOSeHpyeu+XBxuKGIyFKvVXL+0RorD+ZVbdOpIZNBNp527mYOA7OCN//MmQnqSlQXPLsJn4QyRWvYDlwupkKmCut1LJlQMHtkiqNnqDodw6tZ1AJjo2K2mZh6iqpaSUtzhp7qnrcDYaF9eDRxczfwOWYAj1WUx6K8be4Mglw/s/lBwY9TO+fj1wa8wKQp5qwA42mbZ9RJ6ggyueJG6Nf06ivF18xhGro SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jan 2018 23:30:13.7442 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 608fb022-264c-4721-3101-08d562b94111 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB3873 Subject: [dpdk-stable] [PATCH v1] net/mlx4: fix single port configuration X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Jan 2018 23:30:15 -0000 The number of mlx4 present ports is calculated as follows: conf.ports.present |= (UINT64_C(1) << device_attr.phys_port_cnt) - 1; That is - all ones sequence (due to -1 subtraction) When retrieving the number of ports, 1 must be added in order to obtain the correct number of ports to the power of 2, as follows: uint32_t ports = rte_log2_u32(conf->ports.present + 1); If 1 was not added, in the case of one port, the number of ports would be falsely calculated as 0. Fixes: 82642799 ("net/mlx4: check max number of ports dynamically") Cc: stable@dpdk.org Signed-off-by: Ophir Munk --- drivers/net/mlx4/mlx4.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c index 2a721e7..952dae0 100644 --- a/drivers/net/mlx4/mlx4.c +++ b/drivers/net/mlx4/mlx4.c @@ -337,7 +337,7 @@ mlx4_arg_parse(const char *key, const char *val, struct mlx4_conf *conf) return -rte_errno; } if (strcmp(MLX4_PMD_PORT_KVARG, key) == 0) { - uint32_t ports = rte_log2_u32(conf->ports.present); + uint32_t ports = rte_log2_u32(conf->ports.present + 1); if (tmp >= ports) { ERROR("port index %lu outside range [0,%" PRIu32 ")", -- 2.7.4