* [dpdk-stable] [PATCH] app/pdump: fix the memory leak by rte_service_init
@ 2018-01-24 7:54 Vipin Varghese
2018-01-26 15:44 ` Van Haaren, Harry
0 siblings, 1 reply; 2+ messages in thread
From: Vipin Varghese @ 2018-01-24 7:54 UTC (permalink / raw)
To: harry.van.haaren, dev
Cc: deepak.k.jain, john.mcnamara, stable, amol.patel, Vipin Varghese
When pdump is run multiple times against any primary application,
it consumes huge page memory by rte_service_init. This is not freed
at exit of application.
Invoking rte_service_finalize to free memory and prevent memory leak.
Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
---
app/pdump/main.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/app/pdump/main.c b/app/pdump/main.c
index 0f70c75..9d03366 100644
--- a/app/pdump/main.c
+++ b/app/pdump/main.c
@@ -25,6 +25,7 @@
#include <rte_mempool.h>
#include <rte_ring.h>
#include <rte_pdump.h>
+#include <rte_service.h>
#define CMD_LINE_OPT_PDUMP "pdump"
#define PDUMP_PORT_ARG "port"
@@ -882,5 +883,7 @@ struct parse_val {
/* dump debug stats */
print_pdump_stats();
+ rte_service_finalize();
+
return 0;
}
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-stable] [PATCH] app/pdump: fix the memory leak by rte_service_init
2018-01-24 7:54 [dpdk-stable] [PATCH] app/pdump: fix the memory leak by rte_service_init Vipin Varghese
@ 2018-01-26 15:44 ` Van Haaren, Harry
0 siblings, 0 replies; 2+ messages in thread
From: Van Haaren, Harry @ 2018-01-26 15:44 UTC (permalink / raw)
To: Varghese, Vipin, dev; +Cc: Jain, Deepak K, Mcnamara, John, stable, Patel, Amol
> From: Varghese, Vipin
> Sent: Wednesday, January 24, 2018 7:55 AM
> To: Van Haaren, Harry <harry.van.haaren@intel.com>; dev@dpdk.org
> Cc: Jain, Deepak K <deepak.k.jain@intel.com>; Mcnamara, John
> <john.mcnamara@intel.com>; stable@dpdk.org; Patel, Amol
> <amol.patel@intel.com>; Varghese, Vipin <vipin.varghese@intel.com>
> Subject: [PATCH] app/pdump: fix the memory leak by rte_service_init
>
> When pdump is run multiple times against any primary application,
> it consumes huge page memory by rte_service_init. This is not freed
> at exit of application.
>
> Invoking rte_service_finalize to free memory and prevent memory leak.
>
> Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
Thanks Vipin.
Note that this fixes a hugepages memory leak that would otherwise
occur when a secondary process initializes EAL and then quits.
Note that this patch depends on the patch adding rte_service_finalize()
http://dpdk.org/dev/patchwork/patch/34555/
Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-26 15:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-24 7:54 [dpdk-stable] [PATCH] app/pdump: fix the memory leak by rte_service_init Vipin Varghese
2018-01-26 15:44 ` Van Haaren, Harry
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).