From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id E63371B1BD for ; Wed, 24 Jan 2018 16:41:21 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 6A77822709; Wed, 24 Jan 2018 10:41:21 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Wed, 24 Jan 2018 10:41:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=cb1OAmrndWox4YQeu wKvlfJQrNZzYC+wHo8hqWnd0OY=; b=UkswFe4mZ1LQ5CJLpMEMY8dlmZ45Ist+3 rPn7peONOakhKa+yU8jrln/wR1qFJR2W7Ag2qtU44TXulxHjjDMsgxSowQgJJ2LN ZTJla9jLAB9ryXD2Ra11BlyLA0VZ/dV3YbI2YA/3SU5YxIwEsw3GRDARoD0S9izD 4Z/RK29FpMOlLbnFUghwxCFCBn+Cr5sEZPodZXLOlXj5rgVz2+ORQUpjhsHCAZMD LI1BPflW2/iMCwvzEfqUiij/B+fjHFZhbTkL6Ew2FyX3V4QJAwq8SAGfkbce6R7w mtfDQEfq1SzHWEVLw2njozYa7ZqVE+VwrsIVCU6ojx2wc/3rsb4PQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=cb1OAmrndWox4YQeuwKvlfJQrNZzYC+wHo8hqWnd0OY=; b=IZvWgNqX iTvFafqUCZ+37KuS6ml4V6FZ9quA99aq2XKED8e/V0qysxAxNpNKI69SjcG+Q2pn WdSlyaNBn9GiH9Yg0fRN2ciLWBQ4gcpe4viZ0iv/xFwhGa2VOgUFijVuXMrkz6ml FvmkAGJe5Dqit6/75aPLoBSObhTyWW7dOm4YfXDypLQ8dZkEUm9mHlh2zb8dtt0F bczVA/7tFbkNtjpIceIWZ58+STKcxaOe5+WNqApxSZV3bsVZuSUfccVAw+LitdtR d200aP+Y55mPmrzkyC12cWkwnUfs2eeBD5Ut0drP8KBXN/ZoLPmtG+whp7o4yoGI 5GRCfXEUNPZ+5A== X-ME-Sender: Received: from localhost.localdomain (unknown [115.150.27.206]) by mail.messagingengine.com (Postfix) with ESMTPA id 4FFA17E3DB; Wed, 24 Jan 2018 10:41:18 -0500 (EST) From: Yuanhan Liu To: Anatoly Burakov Cc: Cristian Dumitrescu , dpdk stable Date: Wed, 24 Jan 2018 23:33:10 +0800 Message-Id: <1516808026-25523-122-git-send-email-yliu@fridaylinux.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1516808026-25523-1-git-send-email-yliu@fridaylinux.org> References: <1516808026-25523-1-git-send-email-yliu@fridaylinux.org> Subject: [dpdk-stable] patch 'test/table: fix uninitialized parameter' has been queued to LTS release 17.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Jan 2018 15:41:22 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 01/26/18. So please shout if anyone has objections. Thanks. --yliu --- >>From e8875eecc35325fac7aea727899c5df094629c73 Mon Sep 17 00:00:00 2001 From: Anatoly Burakov Date: Thu, 21 Dec 2017 15:53:05 +0000 Subject: [PATCH] test/table: fix uninitialized parameter [ upstream commit 7e60499b6cb941547a147ed66f912aee148ff252 ] delete_bulk() copies metadata to pointers provided by the entries parameter, but in the unit test, they are uninitialized, leading to rte_table attempting to memcpy into random garbage pointers. Memsetting pointer table to zero will prevent that from happening. Fixes: 48f2543cf0a8 ("app/test: add bulk adding and deleting") Signed-off-by: Anatoly Burakov Acked-by: Cristian Dumitrescu --- test/test/test_table_acl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/test/test_table_acl.c b/test/test/test_table_acl.c index 08c100f..6fcf4cc 100644 --- a/test/test/test_table_acl.c +++ b/test/test/test_table_acl.c @@ -532,6 +532,8 @@ setup_acl_pipeline(void) struct rte_pipeline_table_entry *table_entries[5]; int key_found[5]; + memset(table_entries, 0, sizeof(table_entries)); + for (n = 0; n < 5; n++) { memset(&keys[n], 0, sizeof(struct rte_table_acl_rule_delete_params)); key_array[n] = &keys[n]; -- 2.7.4