patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Yuanhan Liu <yliu@fridaylinux.org>
To: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Cc: Santosh Shukla <santosh.shukla@caviumnetworks.com>,
	dpdk stable <stable@dpdk.org>
Subject: [dpdk-stable] patch 'mempool/octeontx: fix improper memory barrier' has been queued to LTS release 17.11.1
Date: Wed, 24 Jan 2018 23:31:29 +0800	[thread overview]
Message-ID: <1516808026-25523-21-git-send-email-yliu@fridaylinux.org> (raw)
In-Reply-To: <1516808026-25523-1-git-send-email-yliu@fridaylinux.org>

Hi,

FYI, your patch has been queued to LTS release 17.11.1

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 01/26/18. So please
shout if anyone has objections.

Thanks.

	--yliu

---
>From d925af2c087da01457f861890d06a5c288901a13 Mon Sep 17 00:00:00 2001
From: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Date: Mon, 8 Jan 2018 10:10:43 +0530
Subject: [PATCH] mempool/octeontx: fix improper memory barrier

[ upstream commit b6f26c9db26482d0e8c004b138aa72bdf5f6c975 ]

Use smp barrier instead of IO barrier when sending mbox request as the
write has to be reflected between cores not IO devices.

Fixes: 6da9d24574db ("event/octeontx: add mailbox support")

Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Acked-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
---
 drivers/mempool/octeontx/octeontx_mbox.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mempool/octeontx/octeontx_mbox.c b/drivers/mempool/octeontx/octeontx_mbox.c
index 9525da1..6c69003 100644
--- a/drivers/mempool/octeontx/octeontx_mbox.c
+++ b/drivers/mempool/octeontx/octeontx_mbox.c
@@ -128,7 +128,7 @@ mbox_send_request(struct mbox *m, struct octeontx_mbox_hdr *hdr,
 
 	/* Write the msg header */
 	rte_write64(new_hdr.u64, ram_mbox_hdr);
-	rte_io_wmb();
+	rte_smp_wmb();
 	/* Notify PF about the new msg - write to MBOX reg generates PF IRQ */
 	rte_write64(0, m->reg);
 }
-- 
2.7.4

  parent reply	other threads:[~2018-01-24 15:36 UTC|newest]

Thread overview: 161+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-24 15:31 [dpdk-stable] patch 'kni: fix build with kernel 4.15' " Yuanhan Liu
2018-01-24 15:31 ` [dpdk-stable] patch 'app/testpmd: remove xenvirt again' " Yuanhan Liu
2018-01-24 15:31 ` [dpdk-stable] patch 'mk: remove TILE-Gx machine type' " Yuanhan Liu
2018-01-24 15:31 ` [dpdk-stable] patch 'bus/dpaa: fix build when assert enabled' " Yuanhan Liu
2018-01-24 15:31 ` [dpdk-stable] patch 'app/testpmd: fix port id allocation' " Yuanhan Liu
2018-01-24 15:31 ` [dpdk-stable] patch 'app/testpmd: fix crash of txonly with multiple segments' " Yuanhan Liu
2018-01-24 15:31 ` [dpdk-stable] patch 'kni: fix build dependency' " Yuanhan Liu
2018-01-24 15:31 ` [dpdk-stable] patch 'service: fix number mapped cores count' " Yuanhan Liu
2018-01-24 15:31 ` [dpdk-stable] patch 'service: fix lcore role after delete' " Yuanhan Liu
2018-01-24 15:31 ` [dpdk-stable] patch 'service: fix service core launch' " Yuanhan Liu
2018-01-24 15:31 ` [dpdk-stable] patch 'bus/pci: fix interrupt handler type' " Yuanhan Liu
2018-01-24 15:31 ` [dpdk-stable] patch 'memzone: fix leak on allocation error' " Yuanhan Liu
2018-01-24 15:31 ` [dpdk-stable] patch 'malloc: protect stats with lock' " Yuanhan Liu
2018-01-24 15:31 ` [dpdk-stable] patch 'malloc: fix end for bounded elements' " Yuanhan Liu
2018-01-24 15:31 ` [dpdk-stable] patch 'vfio: fix enabled check on error' " Yuanhan Liu
2018-01-24 15:31 ` [dpdk-stable] patch 'pmdinfogen: fix cross compilation for ARM big endian' " Yuanhan Liu
2018-01-24 15:31 ` [dpdk-stable] patch 'lpm: fix ARM big endian build' " Yuanhan Liu
2018-01-24 15:31 ` [dpdk-stable] patch 'bus/dpaa: " Yuanhan Liu
2018-01-24 15:31 ` [dpdk-stable] patch 'net/i40e: " Yuanhan Liu
2018-01-24 15:31 ` [dpdk-stable] patch 'net/ixgbe: " Yuanhan Liu
2018-01-24 15:31 ` Yuanhan Liu [this message]
2018-01-24 15:31 ` [dpdk-stable] patch 'mempool: fix first memory area notification' " Yuanhan Liu
2018-01-24 15:31 ` [dpdk-stable] patch 'mempool/octeontx: fix memory area registration' " Yuanhan Liu
2018-01-24 15:31 ` [dpdk-stable] patch 'app/testpmd: fix port configuration print' " Yuanhan Liu
2018-01-24 15:31 ` [dpdk-stable] patch 'app/testpmd: fix flowgen forwarding offload flags' " Yuanhan Liu
2018-01-24 15:31 ` [dpdk-stable] patch 'examples/l3fwd-power: fix Rx without interrupt' " Yuanhan Liu
2018-01-24 15:31 ` [dpdk-stable] patch 'examples/l3fwd-power: fix frequency detection' " Yuanhan Liu
2018-01-24 15:31 ` [dpdk-stable] patch 'timer: fix reset on service cores' " Yuanhan Liu
2018-01-24 15:31 ` [dpdk-stable] patch 'net/mlx5: cleanup allocation of ethtool stats' " Yuanhan Liu
2018-01-24 15:31 ` [dpdk-stable] patch 'net/bonding: fix bonding in 8023ad mode' " Yuanhan Liu
2018-01-24 15:31 ` [dpdk-stable] patch 'net/nfp: fix MTU settings' " Yuanhan Liu
2018-01-24 15:31 ` [dpdk-stable] patch 'net/nfp: fix jumbo " Yuanhan Liu
2018-01-24 15:31 ` [dpdk-stable] patch 'net/nfp: fix CRC strip check behaviour' " Yuanhan Liu
2018-01-24 15:31 ` [dpdk-stable] patch 'net/thunderx: fix multi segment Tx function return' " Yuanhan Liu
2018-01-24 15:31 ` [dpdk-stable] patch 'net/mlx5: fix Tx checksum offloads' " Yuanhan Liu
2018-01-24 15:31 ` [dpdk-stable] patch 'net/mlx4: fix unnecessary include' " Yuanhan Liu
2018-01-24 15:31 ` [dpdk-stable] patch 'net/szedata2: fix check of mmap return value' " Yuanhan Liu
2018-01-24 15:31 ` [dpdk-stable] patch 'bus/fslmc: fix the cplusplus macro closure' " Yuanhan Liu
2018-01-24 15:31 ` [dpdk-stable] patch 'drivers: change the deprecated memseg physaddr to IOVA' " Yuanhan Liu
2018-01-24 15:31 ` [dpdk-stable] patch 'net/mlx4: revert workaround for broken Verbs' " Yuanhan Liu
2018-01-24 15:31 ` [dpdk-stable] patch 'net/mlx5: fix flow type for allmulti rules' " Yuanhan Liu
2018-02-13 11:56   ` Yuanhan Liu
2018-01-24 15:31 ` [dpdk-stable] patch 'net/mlx4: fix Tx packet drop application report' " Yuanhan Liu
2018-01-24 15:31 ` [dpdk-stable] patch 'net/bonding: fix activated slave in 8023ad mode' " Yuanhan Liu
2018-01-24 15:31 ` [dpdk-stable] patch 'net/qede: fix to enable LRO over tunnels' " Yuanhan Liu
2018-01-24 15:31 ` [dpdk-stable] patch 'net/qede: fix to reject config with no Rx queue' " Yuanhan Liu
2018-01-24 15:31 ` [dpdk-stable] patch 'net/sfc: stop periodic DMA if MAC stats upload fails' " Yuanhan Liu
2018-01-24 15:31 ` [dpdk-stable] patch 'net/sfc: fix multicast address list copy memory leak' " Yuanhan Liu
2018-01-24 15:31 ` [dpdk-stable] patch 'net/sfc: fix DMA memory leak after kvarg processing failure' " Yuanhan Liu
2018-01-24 15:31 ` [dpdk-stable] patch 'ethdev: fix missing imissed counter in xstats' " Yuanhan Liu
2018-01-24 15:31 ` [dpdk-stable] patch 'net/sfc: fix main MAC address handling' " Yuanhan Liu
2018-01-24 15:31 ` [dpdk-stable] patch 'net/mlx5: fix VLAN configuration after port stop' " Yuanhan Liu
2018-01-24 15:32 ` [dpdk-stable] patch 'net/mlx5: fix Memory Region registration' " Yuanhan Liu
2018-01-24 15:32 ` [dpdk-stable] patch 'net/mlx5: fix overflow of Memory Region cache' " Yuanhan Liu
2018-01-24 15:32 ` [dpdk-stable] patch 'net/mlx5: fix RSS key configuration' " Yuanhan Liu
2018-01-24 15:32 ` [dpdk-stable] patch 'net/mlx5: fix HW checksum offload for outer IP' " Yuanhan Liu
2018-01-24 15:32 ` [dpdk-stable] patch 'net/mlx5: fix un-supported RSS hash fields use' " Yuanhan Liu
2018-01-24 15:32 ` [dpdk-stable] patch 'net/i40e: fix VLAN offload setting' " Yuanhan Liu
2018-01-24 15:32 ` [dpdk-stable] patch 'net/fm10k: fix logical port delete' " Yuanhan Liu
2018-01-24 15:32 ` [dpdk-stable] patch 'net/ixgbe: fix wrong PBA setting' " Yuanhan Liu
2018-01-24 15:32 ` [dpdk-stable] patch 'net/igb: fix Tx queue number assignment' " Yuanhan Liu
2018-01-24 15:32 ` [dpdk-stable] patch 'net/i40e: fix VLAN offload setting issue' " Yuanhan Liu
2018-01-24 15:32 ` [dpdk-stable] patch 'net/i40e: fix FDIR input set conflict' " Yuanhan Liu
2018-01-24 15:32 ` [dpdk-stable] patch 'net/ixgbe: fix tunnel filter fail problem' " Yuanhan Liu
2018-01-24 15:32 ` [dpdk-stable] patch 'net/i40e: add FDIR NVGRE parameter check' " Yuanhan Liu
2018-01-24 15:32 ` [dpdk-stable] patch 'net/i40e: fix setting of MAC address on i40evf' " Yuanhan Liu
2018-01-24 15:32 ` [dpdk-stable] patch 'vhost: fix crash' " Yuanhan Liu
2018-01-24 15:32 ` [dpdk-stable] patch 'vhost: fix dequeue zero copy with virtio1' " Yuanhan Liu
2018-01-24 15:32 ` [dpdk-stable] patch 'net/virtio: fix incorrect cast' " Yuanhan Liu
2018-01-24 15:32 ` [dpdk-stable] patch 'net/virtio: fix vector Rx flushing' " Yuanhan Liu
2018-01-24 15:32 ` [dpdk-stable] patch 'net/virtio: fix typo in LRO support' " Yuanhan Liu
2018-01-24 15:32 ` [dpdk-stable] patch 'examples/vhost: fix sending ARP packet to self' " Yuanhan Liu
2018-01-24 15:32 ` [dpdk-stable] patch 'event/octeontx: fix Rx adapter port id mapping' " Yuanhan Liu
2018-01-26 16:00   ` Yuanhan Liu
2018-01-29  8:56     ` Pavan Nikhilesh
2018-01-24 15:32 ` [dpdk-stable] patch 'net/sfc: fix label name to be consistent' " Yuanhan Liu
2018-01-24 15:32 ` [dpdk-stable] patch 'net/sfc: do not hold management event queue lock while MCDI' " Yuanhan Liu
2018-01-24 15:32 ` [dpdk-stable] patch 'net/sfc: fix incorrect bitwise ORing of L3/L4 packet types' " Yuanhan Liu
2018-01-24 15:32 ` [dpdk-stable] patch 'net/ixgbe: fix parsing FDIR NVGRE issue' " Yuanhan Liu
2018-01-24 15:32 ` [dpdk-stable] patch 'net/i40e: fix FDIR rule confiliction " Yuanhan Liu
2018-01-24 15:32 ` [dpdk-stable] patch 'net/i40e: exclude LLDP packet count' " Yuanhan Liu
2018-01-24 15:32 ` [dpdk-stable] patch 'net/ixgbe: fix the failure of number of Tx queue check' " Yuanhan Liu
2018-01-24 15:32 ` [dpdk-stable] patch 'net/i40e: fix VSI MAC filter on primary address change' " Yuanhan Liu
2018-01-24 15:32 ` [dpdk-stable] patch 'net/mlx5: fix overwriting bit-fields in SW Rx queue' " Yuanhan Liu
2018-01-24 15:32 ` [dpdk-stable] patch 'net/dpaa: fix uninitialized and unused variables' " Yuanhan Liu
2018-01-24 15:32 ` [dpdk-stable] patch 'net/dpaa: fix the mbuf packet type if zero' " Yuanhan Liu
2018-01-24 15:32 ` [dpdk-stable] patch 'net/dpaa: fix FW version code' " Yuanhan Liu
2018-01-24 15:32 ` [dpdk-stable] patch 'net/bnxt: fix double increment of idx during Tx ring alloc' " Yuanhan Liu
2018-01-24 15:32 ` [dpdk-stable] patch 'net/bnxt: parse checksum offload flags' " Yuanhan Liu
2018-01-24 15:32 ` [dpdk-stable] patch 'net/bnxt: fix group info usage' " Yuanhan Liu
2018-01-24 15:32 ` [dpdk-stable] patch 'net/bnxt: fix check for ether type' " Yuanhan Liu
2018-01-24 15:32 ` [dpdk-stable] patch 'net/bnxt: fix duplicate filter pattern creation error' " Yuanhan Liu
2018-01-24 15:32 ` [dpdk-stable] patch 'net/bnxt: fix duplicate pattern for 5tuple filter' " Yuanhan Liu
2018-01-24 15:32 ` [dpdk-stable] patch 'net/bnxt: free the aggregation ring' " Yuanhan Liu
2018-01-24 15:32 ` [dpdk-stable] patch 'net/bonding: fix setting slave MAC addresses' " Yuanhan Liu
2018-01-24 15:32 ` [dpdk-stable] patch 'ethdev: fix link autonegotiation value' " Yuanhan Liu
2018-01-24 15:32 ` [dpdk-stable] patch 'net/enic: fix L4 Rx ptype comparison' " Yuanhan Liu
2018-01-24 15:32 ` [dpdk-stable] patch 'net/pcap: fix the NUMA id display in logs' " Yuanhan Liu
2018-01-24 15:32 ` [dpdk-stable] patch 'net/failsafe: fix Rx safe check compiler hint' " Yuanhan Liu
2018-01-24 15:32 ` [dpdk-stable] patch 'net/tap: remove unused kernel version definitions' " Yuanhan Liu
2018-01-24 15:32 ` [dpdk-stable] patch 'net/mrvl: fix multiple probe' " Yuanhan Liu
2018-01-24 15:32 ` [dpdk-stable] patch 'net/mrvl: fix HIF objects allocation' " Yuanhan Liu
2018-01-24 15:32 ` [dpdk-stable] patch 'net/mrvl: fix oversize bpool handling' " Yuanhan Liu
2018-01-24 15:32 ` [dpdk-stable] patch 'net/mrvl: fix shadow queue tail and size calculations' " Yuanhan Liu
2018-01-24 15:32 ` [dpdk-stable] patch 'net/mrvl: keep shadow Txqs inside PMD Txq' " Yuanhan Liu
2018-01-24 15:32 ` [dpdk-stable] patch 'net/ixgbe: fix max queue number for VF' " Yuanhan Liu
2018-01-24 15:32 ` [dpdk-stable] patch 'net/i40e: fix setting MAC address of " Yuanhan Liu
2018-01-24 15:32 ` [dpdk-stable] patch 'net/i40e: fix port segmentation fault when restart' " Yuanhan Liu
2018-01-24 15:32 ` [dpdk-stable] patch 'net/i40e: fix VF reset stats crash' " Yuanhan Liu
2018-01-24 15:32 ` [dpdk-stable] patch 'net/mlx5: fix deadlock of link status alarm' " Yuanhan Liu
2018-01-24 15:32 ` [dpdk-stable] patch 'net/mlx5: fix missing attribute size for drop action' " Yuanhan Liu
2018-01-24 15:32 ` [dpdk-stable] patch 'net/mlx5: fix calculation of flow ID flag' " Yuanhan Liu
2018-01-24 15:32 ` [dpdk-stable] patch 'vhost: fix error code check when creating thread' " Yuanhan Liu
2018-01-24 15:32 ` [dpdk-stable] patch 'examples/vhost: fix startup check' " Yuanhan Liu
2018-01-24 15:33 ` [dpdk-stable] patch 'net/i40e: fix ISO C in exported header' " Yuanhan Liu
2018-01-24 15:33 ` [dpdk-stable] patch 'flow_classify: " Yuanhan Liu
2018-01-24 15:33 ` [dpdk-stable] patch 'member: " Yuanhan Liu
2018-01-24 15:33 ` [dpdk-stable] patch 'lib: fix missing includes in exported headers' " Yuanhan Liu
2018-01-24 15:33 ` [dpdk-stable] patch 'igb_uio: allow multi-process access' " Yuanhan Liu
2018-01-24 15:33 ` [dpdk-stable] patch 'pdump: fix error check when creating/canceling thread' " Yuanhan Liu
2018-01-24 15:33 ` [dpdk-stable] patch 'app/testpmd: fix invalid Rx queue number setting' " Yuanhan Liu
2018-01-24 15:33 ` [dpdk-stable] patch 'app/testpmd: fix invalid Tx " Yuanhan Liu
2018-01-24 15:33 ` [dpdk-stable] patch 'app/procinfo: add compilation option in config' " Yuanhan Liu
2018-01-24 15:33 ` [dpdk-stable] patch 'test: register test as failed if setup failed' " Yuanhan Liu
2018-01-24 15:33 ` [dpdk-stable] patch 'test/table: fix uninitialized parameter' " Yuanhan Liu
2018-01-24 15:33 ` [dpdk-stable] patch 'test/memzone: fix wrong test' " Yuanhan Liu
2018-01-24 15:33 ` [dpdk-stable] patch 'test/memzone: fix NULL freeing' " Yuanhan Liu
2018-01-24 15:33 ` [dpdk-stable] patch 'test/memzone: fix freeing test' " Yuanhan Liu
2018-01-24 15:33 ` [dpdk-stable] patch 'mbuf: fix performance of freeing with non atomic refcnt' " Yuanhan Liu
2018-01-24 15:33 ` [dpdk-stable] patch 'mempool/octeontx: fix natural alignment being optimized out' " Yuanhan Liu
2018-01-24 15:33 ` [dpdk-stable] patch 'member: fix memory leak on error' " Yuanhan Liu
2018-01-24 15:33 ` [dpdk-stable] patch 'eventdev: set error code in port link/unlink functions' " Yuanhan Liu
2018-01-24 15:33 ` [dpdk-stable] patch 'test/eventdev: use CPU event type' " Yuanhan Liu
2018-01-24 15:33 ` [dpdk-stable] patch 'event/sw: fix queue memory leak and multi-link bug' " Yuanhan Liu
2018-01-24 15:33 ` [dpdk-stable] patch 'eventdev: fix doxygen comments' " Yuanhan Liu
2018-01-24 15:33 ` [dpdk-stable] patch 'bus/pci: forbid IOVA mode if IOMMU address width too small' " Yuanhan Liu
2018-01-24 15:33 ` [dpdk-stable] patch 'doc: fix lists of supported crypto algorithms' " Yuanhan Liu
2018-01-24 15:33 ` [dpdk-stable] patch 'doc: fix format in OpenSSL installation guide' " Yuanhan Liu
2018-01-24 15:33 ` [dpdk-stable] patch 'test/crypto: fix missing include' " Yuanhan Liu
2018-01-24 15:33 ` [dpdk-stable] patch 'examples/ipsec-secgw: fix usage of incorrect port' " Yuanhan Liu
2018-01-24 15:33 ` [dpdk-stable] patch 'security: fix device operation type' " Yuanhan Liu
2018-01-24 15:33 ` [dpdk-stable] patch 'crypto: fix pedantic compilation' " Yuanhan Liu
2018-01-24 15:33 ` [dpdk-stable] patch 'security: " Yuanhan Liu
2018-01-24 15:33 ` [dpdk-stable] patch 'security: fix enum start value' " Yuanhan Liu
2018-01-24 15:33 ` [dpdk-stable] patch 'cryptodev: add missing CPU flag string' " Yuanhan Liu
2018-01-24 15:33 ` [dpdk-stable] patch 'cryptodev: fix function prototype' " Yuanhan Liu
2018-01-24 15:33 ` [dpdk-stable] patch 'examples/ipsec-secgw: fix corner case for SPI value' " Yuanhan Liu
2018-01-24 15:33 ` [dpdk-stable] patch 'examples/ipsec-secgw: fix missing ingress flow attribute' " Yuanhan Liu
2018-01-24 15:33 ` [dpdk-stable] patch 'net: fix ESP header byte ordering definition' " Yuanhan Liu
2018-01-24 15:33 ` [dpdk-stable] patch 'examples/ipsec-secgw: fix SPI byte order in flow item' " Yuanhan Liu
2018-01-24 15:33 ` [dpdk-stable] patch 'net/qede: replace config option with run-time arg' " Yuanhan Liu
2018-01-24 15:33 ` [dpdk-stable] patch 'net/i40e: fix flag for MAC address write' " Yuanhan Liu
2018-01-24 15:33 ` [dpdk-stable] patch 'net/i40e: fix packet type for X722' " Yuanhan Liu
2018-01-24 15:33 ` [dpdk-stable] patch 'net/mlx5: fix IPv6 header fields' " Yuanhan Liu
2018-01-24 15:33 ` [dpdk-stable] patch 'net/sfc: fix initialization of flow structure' " Yuanhan Liu
2018-01-24 15:33 ` [dpdk-stable] patch 'net/sfc: fix flow RSS check in error handling' " Yuanhan Liu
2018-01-24 15:33 ` [dpdk-stable] patch 'vhost: fix mbuf free' " Yuanhan Liu
2018-01-24 15:33 ` [dpdk-stable] patch 'vhost: protect active rings from async ring changes' " Yuanhan Liu
2018-01-24 15:33 ` [dpdk-stable] patch 'net/failsafe: fix invalid free' " Yuanhan Liu
2018-01-24 15:33 ` [dpdk-stable] patch 'net/i40e: fix flow director Rx resource defect' " Yuanhan Liu
2018-01-24 15:33 ` [dpdk-stable] patch 'net/mlx5: fix memory region lookup' " Yuanhan Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1516808026-25523-21-git-send-email-yliu@fridaylinux.org \
    --to=yliu@fridaylinux.org \
    --cc=pbhagavatula@caviumnetworks.com \
    --cc=santosh.shukla@caviumnetworks.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).