From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 326341B1B9 for ; Wed, 24 Jan 2018 16:36:56 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id DEB6D22353; Wed, 24 Jan 2018 10:36:55 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Wed, 24 Jan 2018 10:36:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=9DvZVO8TnBBZtfICT jpl7PQJi+UJK6k1ftqiF/TTWl8=; b=QiXPxSXWfvJLAGSGpO6MHCUw6yCqzII+c D0Ct6ZZnFZnDMOziQkRk3gZOVgcW9x0EIiPEKb7q6AXllN0tVTVNEuq/T4o32Pkj 4lOhU48t+3L85OTncNK2kvrDBkfMVLM7q60HGQOI0kclkZoYMlGmOzzBSy9TqGZw bulmYl0MqXGM8lcLHd5/LRTpQVoE1oJrWB6AMgIokCVl3pjFqnUFsavc08LO/yzh Z6Uia5pFZF3BczN5YBh3Wdc9zrLGUmmjbfeeLneq7jR6DsbvfKv3EjIEIScJ/toy NhunmUGmqlW+zyT9u9cpDAVqTXHpsDvkPAYUJgVsRg2zQNiuGLYkw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=9DvZVO8TnBBZtfICTjpl7PQJi+UJK6k1ftqiF/TTWl8=; b=iKVYS1D8 iPGvPd2jmrGww8+i8VLdbFouwU//CeXNzwj0g1Mf8EHlmZ2FvoZ/MQIZp9qdLwuE zQXKad0VmAhzYhlA2vPiLVGqFTU3KBNciekF2Fl8kjZQRiXfzQ+GwHG5SUNBl82H L5aeOmEscIY/huQOwQgZXK9kNqqWXssBnaj9H8QxYEidwwl/SKDnPaj1Kuhv13yM Etmt2rm/Irl0U7NftHgDBEO9TlSCeCSyMNSmX00kfzPL8lp/0bHGOEmFi9P3CCWx GQBKs4wgAmSgcdurZeyamY5RxFxjAH3WiSJLshqzdfK38goFsODF2409PMkV9fMl pcaUpgJPAGY21Q== X-ME-Sender: Received: from localhost.localdomain (unknown [115.150.27.206]) by mail.messagingengine.com (Postfix) with ESMTPA id 1A1E47E1A2; Wed, 24 Jan 2018 10:36:53 -0500 (EST) From: Yuanhan Liu To: Shahaf Shuler Cc: Wenzhuo Lu , dpdk stable Date: Wed, 24 Jan 2018 23:31:33 +0800 Message-Id: <1516808026-25523-25-git-send-email-yliu@fridaylinux.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1516808026-25523-1-git-send-email-yliu@fridaylinux.org> References: <1516808026-25523-1-git-send-email-yliu@fridaylinux.org> Subject: [dpdk-stable] patch 'app/testpmd: fix flowgen forwarding offload flags' has been queued to LTS release 17.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Jan 2018 15:36:56 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 01/26/18. So please shout if anyone has objections. Thanks. --yliu --- >>From 45954b8cb72d999fcd0bf5aa36ebb7476cf0a235 Mon Sep 17 00:00:00 2001 From: Shahaf Shuler Date: Wed, 10 Jan 2018 11:09:13 +0200 Subject: [PATCH] app/testpmd: fix flowgen forwarding offload flags [ upstream commit b62678f7a3e4f423496b4cbd593c2c37f9283685 ] The mbuf ol_flags were taken directly from testpmd internal enumeration leading to incorrect values. addressing only insertion offload flags as the checksum flags by the application design are only with csum forwarding. Fixes: e9e23a617eb8 ("app/testpmd: add flowgen forwarding engine") Signed-off-by: Shahaf Shuler Acked-by: Wenzhuo Lu --- app/test-pmd/flowgen.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/flowgen.c b/app/test-pmd/flowgen.c index acf9af9..46478fc 100644 --- a/app/test-pmd/flowgen.c +++ b/app/test-pmd/flowgen.c @@ -123,7 +123,7 @@ pkt_burst_flow_gen(struct fwd_stream *fs) struct ipv4_hdr *ip_hdr; struct udp_hdr *udp_hdr; uint16_t vlan_tci, vlan_tci_outer; - uint16_t ol_flags; + uint64_t ol_flags; uint16_t nb_rx; uint16_t nb_tx; uint16_t nb_pkt; @@ -151,7 +151,13 @@ pkt_burst_flow_gen(struct fwd_stream *fs) mbp = current_fwd_lcore()->mbp; vlan_tci = ports[fs->tx_port].tx_vlan_id; vlan_tci_outer = ports[fs->tx_port].tx_vlan_id_outer; - ol_flags = ports[fs->tx_port].tx_ol_flags; + + if (ports[fs->tx_port].tx_ol_flags & TESTPMD_TX_OFFLOAD_INSERT_VLAN) + ol_flags = PKT_TX_VLAN_PKT; + if (ports[fs->tx_port].tx_ol_flags & TESTPMD_TX_OFFLOAD_INSERT_QINQ) + ol_flags |= PKT_TX_QINQ_PKT; + if (ports[fs->tx_port].tx_ol_flags & TESTPMD_TX_OFFLOAD_MACSEC) + ol_flags |= PKT_TX_MACSEC; for (nb_pkt = 0; nb_pkt < nb_pkt_per_burst; nb_pkt++) { pkt = rte_mbuf_raw_alloc(mbp); -- 2.7.4