From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 21D301B1B9 for ; Wed, 24 Jan 2018 16:37:17 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id CE2AC22389; Wed, 24 Jan 2018 10:37:16 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Wed, 24 Jan 2018 10:37:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=5ekp4TeP4p8nZjtvT jdLOSaIj2+cCm7pjiJOR94bydU=; b=CM9FJ0HZcYQloB7dYwffBcKUh9UNenx1G 0OhYvjQBvomGdDR3qWmKprqaiVzhW0WkNlau04HvRQkSINrvlGCNS1J9oorvWFv/ o5/WoYJWNGC8nrTfUOzMxjKLdGn9Cvf+SE6OyDGY4nBdTb+BN6LTgM2rbN5KOZX0 UPtRmVI/32R6AokDfx86AKVIbMaN8YYXTaHuxkzW0irBFAldOB8EKPljg/sDpgkw oBSsRsyNuECcz8iRpimc30PQBnuZGWusCJrnZDovjLrv8OPI/pC2B8WbxJgTJWdt aKuOqw1jSPZr8iA1hfU2NlROvYufG0mfUQjfOaCMkbcB4lfIBvHgA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=5ekp4TeP4p8nZjtvTjdLOSaIj2+cCm7pjiJOR94bydU=; b=eV/bz4WK nPrfW9M2sFbLX5R8d2fgUCaaFvwLkXlhp0RoWIfoerx0TaSWRHE1CHRvNcR71MBY qQfNEJYKo74fn7dM1IerDmTs3cIOAAhuHBTkMjSKXiMPd3i4PKeLMhPuBTJhPaWX +jRp03WyJteEXW4NSiWXVmwaBJZHpdghT2Lz+/B0U++Cn/D+PgGD2u5wk9V4rkSV tTKd5dr8DOXlJp7zzYEIQFFnScwUHwj96PNqlxT1LBMVktSahMT9dszQKVZe5iC1 EsKgrPRAAyvdclq/vmgd+Keiyo4Zzjt3sFf4OSXFeK0PG2sjbc4Uo00ml89gzRM6 k6VsptK5aaTjbQ== X-ME-Sender: Received: from localhost.localdomain (unknown [115.150.27.206]) by mail.messagingengine.com (Postfix) with ESMTPA id 094EA7E1A2; Wed, 24 Jan 2018 10:37:14 -0500 (EST) From: Yuanhan Liu To: Alejandro Lucero Cc: dpdk stable Date: Wed, 24 Jan 2018 23:31:41 +0800 Message-Id: <1516808026-25523-33-git-send-email-yliu@fridaylinux.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1516808026-25523-1-git-send-email-yliu@fridaylinux.org> References: <1516808026-25523-1-git-send-email-yliu@fridaylinux.org> Subject: [dpdk-stable] patch 'net/nfp: fix CRC strip check behaviour' has been queued to LTS release 17.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Jan 2018 15:37:17 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 01/26/18. So please shout if anyone has objections. Thanks. --yliu --- >>From fdad105bd353811bc03c8157cba573f1ebaa1d62 Mon Sep 17 00:00:00 2001 From: Alejandro Lucero Date: Fri, 24 Nov 2017 14:26:02 +0000 Subject: [PATCH] net/nfp: fix CRC strip check behaviour [ upstream commit d4abcc55c5c6922ab24bb62358b6ba54fb14df87 ] NFP does CRC strip by default and it is not configurable. But, even if an app requests not to do it, that should not be a reason for PMD configuration failure. Fixes: defb9a5dd156 ("nfp: introduce driver initialization") Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c index 4aec94d..fa8ff3c 100644 --- a/drivers/net/nfp/nfp_net.c +++ b/drivers/net/nfp/nfp_net.c @@ -491,10 +491,8 @@ nfp_net_configure(struct rte_eth_dev *dev) if (rxmode->jumbo_frame) hw->mtu = rxmode->max_rx_pkt_len; - if (rxmode->hw_strip_crc) { - PMD_INIT_LOG(INFO, "strip CRC not supported"); - return -EINVAL; - } + if (!rxmode->hw_strip_crc) + PMD_INIT_LOG(INFO, "HW does strip CRC and it is not configurable"); if (rxmode->enable_scatter) { PMD_INIT_LOG(INFO, "Scatter not supported"); -- 2.7.4