From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id E58071B1B6 for ; Wed, 24 Jan 2018 16:37:49 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 9D94D2241E; Wed, 24 Jan 2018 10:37:49 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Wed, 24 Jan 2018 10:37:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=ywDKd6IeYiUINrM5V RKaVKd06qPBPFoS+TkB+jJp6e0=; b=rV0z4KBDByw3YGRz5ns0SdVtf6WsIZaB7 MDJ0w7FWKG+VDRQU1874MpL5riBlRwIMudTB6/PpPq5wSQF2TR4cYF6BNql5TNT3 yrgpy/pYypDk9Z8l/kha8SVnLt8U2Wh/5ZEYTQpnWp4PjATKVJH7S3BG+ZJQ5Lik R+w6/blQEFsYdiMuNN7/HhAlRKpFHZteV0lsvtwQyvj4Mt5tUFPzXVyecHN1RI8g PnCanY+tf0FfBe+OzA58UrpyPbmGJupproGN9VMW9gee+uALH4I4boEX0dmqj5/x gyz44tcK7I0lOq7eyOB7wOdbJbMkSPMQsvTf8fl7sG3w9/xAZFsGA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=ywDKd6IeYiUINrM5VRKaVKd06qPBPFoS+TkB+jJp6e0=; b=c78+Ee26 9cr+WpgpG16zLe1QQZVvmsBhLHulwE5BP9qygRmgaaHxnFq9DSWWDeC6bVm3+MNn XKuBWokWcyjx0zmQL6wLgwYnVNrsEgPCNn4W5RnrV7bnRGYlcU9DLNbIEcJRv+VL is8CEnF7dt/M7XG32kbz6PATRUo9Cqyiu+ifnAclvQykM2bqS7mdwelFUy7eBWGy 93BFgS4H3dXJ3oTbX/CZJFyoaxvQ3Zvas3w2qc983Bxk8KrWSpU5OH42cl6E130V 5RXySXSDQJ6vTAM8ZO242i/j2BOOj17BL39rre4ANDN3XC7b+Q4zvdGkl9eISYpr j8qOt5ymwyZnOg== X-ME-Sender: Received: from localhost.localdomain (unknown [115.150.27.206]) by mail.messagingengine.com (Postfix) with ESMTPA id E08AD7E1A2; Wed, 24 Jan 2018 10:37:47 -0500 (EST) From: Yuanhan Liu To: Harish Patil Cc: dpdk stable Date: Wed, 24 Jan 2018 23:31:53 +0800 Message-Id: <1516808026-25523-45-git-send-email-yliu@fridaylinux.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1516808026-25523-1-git-send-email-yliu@fridaylinux.org> References: <1516808026-25523-1-git-send-email-yliu@fridaylinux.org> Subject: [dpdk-stable] patch 'net/qede: fix to reject config with no Rx queue' has been queued to LTS release 17.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Jan 2018 15:37:50 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 01/26/18. So please shout if anyone has objections. Thanks. --yliu --- >>From 5e9f158973e9c6b5b68e205f55356ad06de2f2ac Mon Sep 17 00:00:00 2001 From: Harish Patil Date: Wed, 13 Dec 2017 22:36:02 -0800 Subject: [PATCH] net/qede: fix to reject config with no Rx queue [ upstream commit e60644c4420c47fa196c0c947a6c6e5891d167d0 ] The qede firmware expects minimum one RX queue to be created, otherwise it results in firmware exception. So a check is added to prevent that. Fixes: ec94dbc57362 ("qede: add base driver") Signed-off-by: Harish Patil --- drivers/net/qede/qede_ethdev.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c index cc473d6..0128cec 100644 --- a/drivers/net/qede/qede_ethdev.c +++ b/drivers/net/qede/qede_ethdev.c @@ -1233,6 +1233,14 @@ static int qede_dev_configure(struct rte_eth_dev *eth_dev) } } + /* We need to have min 1 RX queue.There is no min check in + * rte_eth_dev_configure(), so we are checking it here. + */ + if (eth_dev->data->nb_rx_queues == 0) { + DP_ERR(edev, "Minimum one RX queue is required\n"); + return -EINVAL; + } + /* Sanity checks and throw warnings */ if (rxmode->enable_scatter) eth_dev->data->scattered_rx = 1; -- 2.7.4