From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 64A111B173 for ; Wed, 24 Jan 2018 16:38:07 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 1A2D322433; Wed, 24 Jan 2018 10:38:07 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Wed, 24 Jan 2018 10:38:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=7fy3ZQ6T2ahyB/OxR qMC6qA7rqRCl0fVHn5MHv9tAw8=; b=J6IUcss3mhpiJHx3xN/nW/IMityVxB8TR 3op0rY6U8TfG5aq1SRtRQllbQJEyVe7N3Y56gY8CfGgfMdEn7JwZYSFB1ix9rcbq pon5tARiNRy01CcmcwlvErVrVbfUsOZl+K3v2j6zoz0FHgWUI5Z06ZeaY9STQB8h 6oSKeSCjoDeWB04W7peuI2P/sdC894lRGgH4O9tRFbRfML3zojD+QOy54ZOrzW9E srM2HR4J6K6W/ibpk/vdtevUeBdsWsnwqx6XSg1Cbw1djja3YY0X/gbuAgNB+l2a 5cNRsQNdxjH1HgLRm6xf1L0mI/c0zjwOp8DZZGJqroVcEX+UYUTnQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=7fy3ZQ6T2ahyB/OxRqMC6qA7rqRCl0fVHn5MHv9tAw8=; b=EqbDUczq +qaJZhW0wjwJPPVIEAAxHDyMKimdUrZgUP74Mm6cDPUSu4PXcO/8Lkna36snOw4y pejMwtZJteb64QL8PETdDYQtmzqU45F3fyVPfo2nY6NiACYy1cdzJqqTPU/yPz9e wiFqIKFb2RQZTajyt5bLc9J86Yy/18++0pD6XRdWpqnJ6FfNva58AXLnHTFMJ6sG KsdUwhWtP9r+LVm/cYyvHPYH3SeYLp2MTf82qWYaumovgUo8MMwsV5rOLdf14L0B 5D/BXqi36bWfSUhwGagHK6OB9FVay3wcwbw/AnijLmSOgeIIZrbpwUAuBS6VlkfG rTxa205X36VUWg== X-ME-Sender: Received: from localhost.localdomain (unknown [115.150.27.206]) by mail.messagingengine.com (Postfix) with ESMTPA id 6AB857E3DB; Wed, 24 Jan 2018 10:38:04 -0500 (EST) From: Yuanhan Liu To: Shahaf Shuler Cc: Nelio Laranjeiro , dpdk stable Date: Wed, 24 Jan 2018 23:31:59 +0800 Message-Id: <1516808026-25523-51-git-send-email-yliu@fridaylinux.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1516808026-25523-1-git-send-email-yliu@fridaylinux.org> References: <1516808026-25523-1-git-send-email-yliu@fridaylinux.org> Subject: [dpdk-stable] patch 'net/mlx5: fix VLAN configuration after port stop' has been queued to LTS release 17.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Jan 2018 15:38:07 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 01/26/18. So please shout if anyone has objections. Thanks. --yliu --- >>From 2e82fea4f48a86682273e37c9fddec390bac1cc9 Mon Sep 17 00:00:00 2001 From: Shahaf Shuler Date: Wed, 13 Dec 2017 16:03:10 +0200 Subject: [PATCH] net/mlx5: fix VLAN configuration after port stop [ upstream commit 3a76da0ac85ff90280ec612dd444a553a4782f7b ] Ethdev layer has an API to configure vlan setting on the flight, i.e. when the port state is start. Calling such API when the port is stopped may cause segmentation fault as the related Verbs contexts has not been created yet. Fixes: 09cb5b581762 ("net/mlx5: separate DPDK from verbs Rx queue objects") Signed-off-by: Shahaf Shuler Acked-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_vlan.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/mlx5/mlx5_vlan.c b/drivers/net/mlx5/mlx5_vlan.c index 6fc315e..198a69e 100644 --- a/drivers/net/mlx5/mlx5_vlan.c +++ b/drivers/net/mlx5/mlx5_vlan.c @@ -127,6 +127,11 @@ priv_vlan_strip_queue_set(struct priv *priv, uint16_t idx, int on) DEBUG("set VLAN offloads 0x%x for port %d queue %d", vlan_offloads, rxq->port_id, idx); + if (!rxq_ctrl->ibv) { + /* Update related bits in RX queue. */ + rxq->vlan_strip = !!on; + return; + } mod = (struct ibv_wq_attr){ .attr_mask = IBV_WQ_ATTR_FLAGS, .flags_mask = IBV_WQ_FLAGS_CVLAN_STRIPPING, -- 2.7.4