From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 4FEBA1B1B9 for ; Wed, 24 Jan 2018 16:38:15 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 043FB22415; Wed, 24 Jan 2018 10:38:15 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Wed, 24 Jan 2018 10:38:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=y08HX95XUk26HGks0 G0KPJSzbUdChXWFJGG9jI6fCeA=; b=J+MA5SqVUedtLJB8PazOjDc4Cdzy6LFoO arZE1d0A4fZxkQqWGXa9VOJ3pe4bcS0RlJ7JPqT28k4zAyqv2YMEarDGzw0V8WjN QXuCD8W4KOm2nFk1ckgD/1wzE+GtzmzXVxbBRCAJ75uhJPk43b/wYYRVy4hEyC19 Gc0+A1eYxST+NpGTNV6r8zp7U2wT9YhArntOIfBlYjABKwoxK2PkCZRvnXMb27/X v//xu62dPT8SW1VHN7vh+MPKgatq9eulM7XBWx6k6xli8nT95oHvgkfv5ZXcmN75 GFivHD8wRzcp4W92zsMBNFmkfMRLHXmsfrzR+UzKbmstwsPZsC2Jw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=y08HX95XUk26HGks0G0KPJSzbUdChXWFJGG9jI6fCeA=; b=A7IzmRJx 0GqDLbeW8wNZqVi/ks3C7JmCkaly+6Yy9B93488xtbjmFUzq9TEP4kmdtMd5tgNR gPvpeoNCr+TIobSk3Ok+iqwB2ZgP04vD/ykC19ylBhgdiixqqSxz+4cnGEJUOWil X9dbKihLW4IkN+k3At3ti0Gqu9YD9COZpa5Hc3ERQkcMfrrXUcKmBeSI960c3/04 yUU3VHn4qGmfF0WqCJMS0xl7iAmJRx+OLfg6fMz7IM161Fr9qVnhMqAy5ZQme1vB ytWunHrZS/fMaXIesuV785SYrVMB80oyboWd9CIIJTldD5kZd+NMjFx6Itnfn0oV MrdCsn+D5B5Icg== X-ME-Sender: Received: from localhost.localdomain (unknown [115.150.27.206]) by mail.messagingengine.com (Postfix) with ESMTPA id EED917E3D4; Wed, 24 Jan 2018 10:38:12 -0500 (EST) From: Yuanhan Liu To: Shahaf Shuler Cc: Yongseok Koh , dpdk stable Date: Wed, 24 Jan 2018 23:32:02 +0800 Message-Id: <1516808026-25523-54-git-send-email-yliu@fridaylinux.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1516808026-25523-1-git-send-email-yliu@fridaylinux.org> References: <1516808026-25523-1-git-send-email-yliu@fridaylinux.org> Subject: [dpdk-stable] patch 'net/mlx5: fix RSS key configuration' has been queued to LTS release 17.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Jan 2018 15:38:15 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 01/26/18. So please shout if anyone has objections. Thanks. --yliu --- >>From c1253aff6a367fcdbe578f08cce6f2ad9c988bff Mon Sep 17 00:00:00 2001 From: Shahaf Shuler Date: Tue, 26 Dec 2017 09:40:41 +0200 Subject: [PATCH] net/mlx5: fix RSS key configuration [ upstream commit 21e3a9747fd67f0581842d4070b4e34a4885cbbe ] The trigger for PMD to use the application RSS configuration should be based on the validity of rss_key and not the rss_key_len. Otherwise segmentation fault can occur if application provide valid RSS key length but without any RSS key. Fixes: 29c1d8bb3e79 ("net/mlx5: handle a single RSS hash key for all protocols") Signed-off-by: Shahaf Shuler Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c index a3cef68..b518083 100644 --- a/drivers/net/mlx5/mlx5_ethdev.c +++ b/drivers/net/mlx5/mlx5_ethdev.c @@ -577,7 +577,7 @@ dev_configure(struct rte_eth_dev *dev) unsigned int j; unsigned int reta_idx_n; const uint8_t use_app_rss_key = - !!dev->data->dev_conf.rx_adv_conf.rss_conf.rss_key_len; + !!dev->data->dev_conf.rx_adv_conf.rss_conf.rss_key; if (use_app_rss_key && (dev->data->dev_conf.rx_adv_conf.rss_conf.rss_key_len != -- 2.7.4