From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 72C071B1B8 for ; Wed, 24 Jan 2018 16:38:45 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 2993E226C4; Wed, 24 Jan 2018 10:38:45 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Wed, 24 Jan 2018 10:38:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=vBqdFi8OlvGok2qf4 AMV0jYdPMCUs+8uyDu3h598J+U=; b=Y2e67QM6hljhNv7BtoEYOk2iBOJhX3GLE NhFVNNpECvtN6sSu8gDsxhgRfmBFnvGRUSgMgD6419hzExj1PXweCvWtDhKhX7J3 ckt6MKRHcXnspPGK6+GRA1qWDs4aoEYZ3ecYtSMSzTMTK753WkE8l4zxbQBmGJRB 1BreMnJ7svfz90epXLCcuC8EvCQTaBC1aC0lh6ED4axOO4fKsP1eDt3/jByej2r6 +W1v0Iw2KHEmnJbeDlROtOrFZ7HenIFmP/QSiBmBFpFj61TkKbSCdTzYAwFNNBSE z1wwHbTZwkS7pjixHEEplqsmKmY0+l96p4V2++v2LNxrTTyP5b10g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=vBqdFi8OlvGok2qf4AMV0jYdPMCUs+8uyDu3h598J+U=; b=VUZaCjtq /I4cML+hvrHvLlAUyPZx7i1MRRZJ1dIES6YcjkSRoQFoKI/BtFz/4xYigddPGbz7 RAqE2+fLWPIlEQvAsWBlSOzoXHgR69QTKZz4vAc/ccVc4fwyq92t5nc+OYeWNWL8 aC6qKf7No0WTnTKks/0+Khgw7B+mmLXRHLnTcULRY+mpyr29jtvicM64Eji4oDUV uFgGpsWI6IqL79y88GQ3bZP+5U9BA6vXGLObgPCo1v0lonB/vpugWjfAGMbQtYwq A8ekYf0e7PzrZUgp5U+BUKX2CROw21Ii0reSOlbybrJ3Q9UVt/q5aoTI/Oh6bELY TNPV/EWh11jdvQ== X-ME-Sender: Received: from localhost.localdomain (unknown [115.150.27.206]) by mail.messagingengine.com (Postfix) with ESMTPA id 175A57E354; Wed, 24 Jan 2018 10:38:42 -0500 (EST) From: Yuanhan Liu To: Olivier Matz Cc: Beilei Xing , dpdk stable Date: Wed, 24 Jan 2018 23:32:13 +0800 Message-Id: <1516808026-25523-65-git-send-email-yliu@fridaylinux.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1516808026-25523-1-git-send-email-yliu@fridaylinux.org> References: <1516808026-25523-1-git-send-email-yliu@fridaylinux.org> Subject: [dpdk-stable] patch 'net/i40e: fix setting of MAC address on i40evf' has been queued to LTS release 17.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Jan 2018 15:38:45 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 01/26/18. So please shout if anyone has objections. Thanks. --yliu --- >>From 1bbd934f9944382755b92528c6bcd349b7cf4948 Mon Sep 17 00:00:00 2001 From: Olivier Matz Date: Wed, 3 Jan 2018 14:34:18 +0100 Subject: [PATCH] net/i40e: fix setting of MAC address on i40evf [ upstream commit b8a0cebddac88c784c9d2b71481ba358b401cccf ] When setting the MAC address, the ethdev layer copies the new mac address in dev->data->mac_addrs[0] before calling the dev_ops. Therefore, "is_same_ether_addr(mac_addr, dev->data->mac_addrs)" was always true, and the MAC was never set. Remove this test to fix the issue. Fixes: 943c2d899a0c ("net/i40e: set VF MAC from VF") Signed-off-by: Olivier Matz Acked-by: Beilei Xing --- drivers/net/i40e/i40e_ethdev_vf.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c index 4927b14..e2cdc7f 100644 --- a/drivers/net/i40e/i40e_ethdev_vf.c +++ b/drivers/net/i40e/i40e_ethdev_vf.c @@ -2687,9 +2687,6 @@ i40evf_set_default_mac_addr(struct rte_eth_dev *dev, return; } - if (is_same_ether_addr(mac_addr, dev->data->mac_addrs)) - return; - if (vf->flags & I40E_FLAG_VF_MAC_BY_PF) return; -- 2.7.4