From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 58ECE1B1BE for ; Wed, 24 Jan 2018 16:39:42 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 0B64D22430; Wed, 24 Jan 2018 10:39:42 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Wed, 24 Jan 2018 10:39:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=5WCvCpZyZCi4378SB rlv5AHYKxVNL68QIOVQ0Wjxoyc=; b=g1fdAn19OEY0GD+eFmbHmAktEHp+zG2H0 txw1tIf/G4WJQsVVVV89He8m9B9fBR0JtC3bUC2vm9LoJ9uD1BdcGDEk1Gwxgpz0 N2/L/4zjXFe/98DBbMaQUTyNwN/idZJyH3IKHhG+f0YkOWA4IdBng1k6GsGJRL1C 27Kg2ZsCoodwVhbn6MK1W5RgqCq06B3wdJvHNWgFMJndc1qSXB+Vewt5RbvgJknt 1rrzwd4AV6zakUAcR3anqBEnB921ZhM5Y76nx9CEx+rxVsvoebmZ9hRiAsnaqEc2 vM4RrWfHbk1Osgk2sqWWFLcWFcRmZu32o+xPbQ+cStUxsh3eUd/wA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=5WCvCpZyZCi4378SBrlv5AHYKxVNL68QIOVQ0Wjxoyc=; b=ZgC819ZR Q/NFAVu6fApxoNQdnN63ZbGncYOfy+5r1RGZ6Uwn+UbW4lIlDwi+Rq9N0iahG0tN O1ssgBnRENuJtDlvHnGG9X+Mfm+RB8VI61EZDYXfj/P9NG5QK8gHWh+//wHW0P+Z JwYYFn1ZYRFE9CZkFK68YkW3iLXBm7vUQIuamZnq/3DcqyyyaO6svCapTHYgAXkj eg683E9TyOGa6I8/YtbT1W7AVCP3ibQlMaUQyr1fl0ac2f9Yp/VvF0svTytqgmF0 /2sRlX1bGGEoUMejnM18isG9lv2zSJ1vgtz6UrT1pm6ixC6Fpg/62Hy9BfVn0cen 77U8KxyfrjCOfw== X-ME-Sender: Received: from localhost.localdomain (unknown [115.150.27.206]) by mail.messagingengine.com (Postfix) with ESMTPA id 8DB4C7E1A2; Wed, 24 Jan 2018 10:39:40 -0500 (EST) From: Yuanhan Liu To: Ajit Khaparde Cc: dpdk stable Date: Wed, 24 Jan 2018 23:32:33 +0800 Message-Id: <1516808026-25523-85-git-send-email-yliu@fridaylinux.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1516808026-25523-1-git-send-email-yliu@fridaylinux.org> References: <1516808026-25523-1-git-send-email-yliu@fridaylinux.org> Subject: [dpdk-stable] patch 'net/bnxt: fix double increment of idx during Tx ring alloc' has been queued to LTS release 17.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Jan 2018 15:39:42 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 01/26/18. So please shout if anyone has objections. Thanks. --yliu --- >>From fa0de80155492bb2d83eba36932e86995c62114e Mon Sep 17 00:00:00 2001 From: Ajit Khaparde Date: Mon, 8 Jan 2018 12:24:26 -0800 Subject: [PATCH] net/bnxt: fix double increment of idx during Tx ring alloc [ upstream commit 1005d96445e9df72d9a907e0c82843528efed939 ] We are incrementing idx twice while allocating Tx rings. Since this is passed to the firmware, it may cause unexpected behavior. Fixes: daef48efe5e5 ("net/bnxt: support set MTU") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ring.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ring.c b/drivers/net/bnxt/bnxt_ring.c index 0fa2f0c..e0ca0e7 100644 --- a/drivers/net/bnxt/bnxt_ring.c +++ b/drivers/net/bnxt/bnxt_ring.c @@ -362,9 +362,6 @@ int bnxt_alloc_hwrm_rings(struct bnxt *bp) struct bnxt_ring *ring = txr->tx_ring_struct; unsigned int idx = i + 1 + bp->rx_cp_nr_rings; - /* Account for AGG Rings. AGG ring cnt = Rx Cmpl ring cnt */ - idx += bp->rx_cp_nr_rings; - /* Tx cmpl */ rc = bnxt_hwrm_ring_alloc(bp, cp_ring, HWRM_RING_ALLOC_INPUT_RING_TYPE_L2_CMPL, -- 2.7.4