From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 3AC9D1B1B9 for ; Wed, 24 Jan 2018 16:39:49 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id E5E9A226BA; Wed, 24 Jan 2018 10:39:48 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Wed, 24 Jan 2018 10:39:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=uq9izO63NyWMO3h0i JmP6x/rrpG3GvI/Xb3M7DHUfF4=; b=hq8hAa55kgFYxnQy3ol6kdEA6+B/37THs qB4wGGhAs9HEVfWjn/iGK4kcJWTVo0Q/t/asXrVI9gt2R4KrZMaJuRxzR42U5O08 vE3cAGUcvBh759H4rHT1nzjN9/6Jjk4SXMYC8TcUT4WAkv8iZAjvFE2DSmrHrBqF B9C8BFt01ygUKe5szzoT0Ji6BallfEHAzlYJrEq5OxOLDUYapImjS/AlHeVLSlYp 968qFm4mXFBpRXLpqxpgIBeIt/9SwT0Bg5hkjGEKf2OSUA8oOGtBsXs6lph9g+N7 avWn4rjpAxxQFvdq4SBD8fR8LK+r4eRACN9SsWBfBgdzSP7BSC/0g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=uq9izO63NyWMO3h0iJmP6x/rrpG3GvI/Xb3M7DHUfF4=; b=c3WruX1M 8+YfPAJgJUcy1X4ZSlzcKzaisR8Amhin2xrQwEKO19BT2d+m3hQljndeV7Kv8Szp A6p2kbFSFzNNoAUs0BHGxX2e5hdiXsFU7hs6+WMqS9LpMu9Fu8akzVsgtu+/zMwJ L/q1im7VZvHmLUNgza/tGRf/b0l3xn5PIgM50gyeBj7NZu78BpZhaytuVz7eyaGR YRaJ9GeHmPAbtkNLx+PfSJXFJOa1dRImf48m+tnr17WB5HWW4V3U08Ps63uuAvLh cQMW9tcImimufbbDYw60MyboDcY1Z2QfShOaX/S+HiNvRPNSti4C+kINmtuc+hea c2gKklA+pEhgqA== X-ME-Sender: Received: from localhost.localdomain (unknown [115.150.27.206]) by mail.messagingengine.com (Postfix) with ESMTPA id 310E77E1A2; Wed, 24 Jan 2018 10:39:46 -0500 (EST) From: Yuanhan Liu To: Ajit Khaparde Cc: dpdk stable Date: Wed, 24 Jan 2018 23:32:36 +0800 Message-Id: <1516808026-25523-88-git-send-email-yliu@fridaylinux.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1516808026-25523-1-git-send-email-yliu@fridaylinux.org> References: <1516808026-25523-1-git-send-email-yliu@fridaylinux.org> Subject: [dpdk-stable] patch 'net/bnxt: fix check for ether type' has been queued to LTS release 17.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Jan 2018 15:39:49 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 01/26/18. So please shout if anyone has objections. Thanks. --yliu --- >>From 7f12fd066e33676aaf0bb9e6faf1739afccc3d72 Mon Sep 17 00:00:00 2001 From: Ajit Khaparde Date: Mon, 8 Jan 2018 12:24:32 -0800 Subject: [PATCH] net/bnxt: fix check for ether type [ upstream commit 2b30803c096b42976cd199660c9ddec54588d928 ] As per documentation, While supporting ethertype_filters matching ether_types 0x0800 (IPv4) and 0x86DD (IPv6) is invalid. But we were wrongly doing that. This patch fixes it. Fixes: 5ef3b79fdfe6 ("net/bnxt: support flow filter ops") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 7832e20..5f0aae4 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -1726,9 +1726,9 @@ bnxt_match_and_validate_ether_filter(struct bnxt *bp, int match = 0; *ret = 0; - if (efilter->ether_type != ETHER_TYPE_IPv4 && - efilter->ether_type != ETHER_TYPE_IPv6) { - RTE_LOG(ERR, PMD, "unsupported ether_type(0x%04x) in" + if (efilter->ether_type == ETHER_TYPE_IPv4 || + efilter->ether_type == ETHER_TYPE_IPv6) { + RTE_LOG(ERR, PMD, "invalid ether_type(0x%04x) in" " ethertype filter.", efilter->ether_type); *ret = -EINVAL; goto exit; -- 2.7.4