From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id EF6081B1A8 for ; Wed, 24 Jan 2018 16:40:10 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id A5F69226E5; Wed, 24 Jan 2018 10:40:10 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Wed, 24 Jan 2018 10:40:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=cc9VHJx2X0QG5X30x MDNCuj0mCNZ0YJDHfzxZpjRD+8=; b=RGInZ4Ds8x8fjO7bq5AlzFXp1LganYpot TyFC/kfmsbFlYuQKFfxwgJcSG7TNWt2hX/0Qob4Mz/gQ73X/Qh9Kd/dL66rX5prK 3n17tP1Lh5JOd1YrEqh2p0wnqve5rBU8+WpwlzJfm03yqqGxnRvnxgwmlxDN2MbB goZVq9cH+9L2kTJweb/DEIGAEeP+6zXcZK093C/l1JS1fSZ3n8VEhje19dybcLnZ /2smhWLLHpfFDy7ebpyvqkkV94w4UdMLX2ZRHo7lHKRJhyotrHY2QDHZ0Yi5Vhvi rqfSoOAcrKTNsMsVYiq2y1o22D3+LSVIuDpDZdoA4Yu4v7KC8Vy3g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=cc9VHJx2X0QG5X30xMDNCuj0mCNZ0YJDHfzxZpjRD+8=; b=SVi6WM1T KyGpkyveEo0gLfEcpdbe/s+CfgMat82Ur1FiOSopSjkevwyUdIYNosUhjbUD6BQ3 waW4AMdlDtCGpI4aXYvxPRnS1D0pqNkb4ttBrPLhrQUc/OuXIa6MMqgXib0swTBi /p1ibwllF2sNwQwdi7jlYO9GpJvT5wl0bKji7TBN/7Na4cFQi6bnCKhOzttsvf4B rZpJPnxjWTibOFz2H2MVbT4tX9NsNK3pPIBtibO5eCbmNSqkAA2jOYB0Vt7FQKlh d4QPI+TiPPxyY7roNe4t8wdg0kYgOhr6SXR+yLAQZ/a1rstTXmY1KlHuwgCCIXEO Wk3xR7RR0n6sdw== X-ME-Sender: Received: from localhost.localdomain (unknown [115.150.27.206]) by mail.messagingengine.com (Postfix) with ESMTPA id EFBAD7E1A2; Wed, 24 Jan 2018 10:40:07 -0500 (EST) From: Yuanhan Liu To: Matan Azrad Cc: Gaetan Rivet , dpdk stable Date: Wed, 24 Jan 2018 23:32:44 +0800 Message-Id: <1516808026-25523-96-git-send-email-yliu@fridaylinux.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1516808026-25523-1-git-send-email-yliu@fridaylinux.org> References: <1516808026-25523-1-git-send-email-yliu@fridaylinux.org> Subject: [dpdk-stable] patch 'net/failsafe: fix Rx safe check compiler hint' has been queued to LTS release 17.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Jan 2018 15:40:11 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 01/26/18. So please shout if anyone has objections. Thanks. --yliu --- >>From 89e3394fe94e53e712d4f62bf9071bb36d53ad19 Mon Sep 17 00:00:00 2001 From: Matan Azrad Date: Tue, 19 Dec 2017 17:14:27 +0000 Subject: [PATCH] net/failsafe: fix Rx safe check compiler hint [ upstream commit e6282283090b479953b8c0f951977c82cc368322 ] failsafe_rx_burst function is used when there are no sub-devices or at least one of them has been removed, on the other hand, when all the sub-devices are present, failsafe_rx_burst_fast function is used. So it's really expected that some of the sub-devices will be unsafe for Rx burst in failsafe_rx_burst execution. Remove unlikely compiler hint from fs_rx_unsafe calling. Fixes: a46f8d584eb8 ("net/failsafe: add fail-safe PMD") Signed-off-by: Matan Azrad Acked-by: Gaetan Rivet --- drivers/net/failsafe/failsafe_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/failsafe/failsafe_rxtx.c b/drivers/net/failsafe/failsafe_rxtx.c index 70157c8..178294c 100644 --- a/drivers/net/failsafe/failsafe_rxtx.c +++ b/drivers/net/failsafe/failsafe_rxtx.c @@ -111,7 +111,7 @@ failsafe_rx_burst(void *queue, if (i == priv->subs_tail) i = priv->subs_head; sdev = &priv->subs[i]; - if (unlikely(fs_rx_unsafe(sdev))) + if (fs_rx_unsafe(sdev)) continue; sub_rxq = ETH(sdev)->data->rx_queues[rxq->qid]; FS_ATOMIC_P(rxq->refcnt[sdev->sid]); -- 2.7.4