From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f67.google.com (mail-lf0-f67.google.com [209.85.215.67]) by dpdk.org (Postfix) with ESMTP id 4A0601B01F for ; Thu, 25 Jan 2018 16:10:55 +0100 (CET) Received: by mail-lf0-f67.google.com with SMTP id t79so10233932lfe.3 for ; Thu, 25 Jan 2018 07:10:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=tL7Iiho1Sdc4Y1ZbePF9P70ClSaIb4SPvf83NxdDWBM=; b=aiu0UAUbNMJ/Ds5soZiSMNUfwIaRezoGJAV7JvOmp1SNmZKkjryTkjgyWGTeHSNezV GVEaspZuMMYwFvC/lgziLRj+Ohe7aECP0/aZJfwsfdQoA/sFLiNVPJyYGAas/UF4jaI6 fe/7u8Otk0qeXAFr8nJwfnCJt3LcHPQ+NEeMYnp3f6CX1zo2Fd5JRNxWlCMfp5NhCv+u GwlIfWGkdL7JdLqO18II2l77ys3pcBtpbLRkYdMQiPoMa6CuW36tBm9tkHJqwT4QToua sHGQE46Kbp0xVt7mfekeXqIYBhSGJQlHqZ3j6qnl3cBoDIIInZeHSTKkFb+DvB1+8t7W huPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=tL7Iiho1Sdc4Y1ZbePF9P70ClSaIb4SPvf83NxdDWBM=; b=RYr3m1ds0UEEHNRxFDp4kNnUQ0IekIbzU3AEbjxp+KtMbjleinvlyLhjubenDongV0 VhR7zgZ8NGGgxjsT/ydF5xeFE8X1ElmQDaFKAKHVPK4VTXYTULUmj4uGpQ44RcAnL0UA 5raht9Kan/hiw+krr73cw5tdV4K06+PDtKzgHQtueCl5UnDAzPgqyHEOUzAv9QbeXjEs K6IPEJb5E15iWO1Rj1h84twqhMVaN6VJ/dMCO6jXOqgSt0hiNEhDWJEIoLGpwqyAmrpi qYhyyZzw5cCGAUzwXTnFzgILgQjPdKbpRkXBtqlRGBECHCiij8rcmryRG7AQeot9hzJj nbJA== X-Gm-Message-State: AKwxytcv1jd8Yrz4L3E3AdH6nmxPYjd8Te7Vp+art0uZFpPTz3saSXAx jzgnM0iaktluanehdBks2LFD4w== X-Google-Smtp-Source: AH8x227+8dUf6v1IZB9iqjGmyIMvaYE7TNBhT7BOb+42+IsiXTAC13rmKcvSK7AhoGltHljTU7SbqQ== X-Received: by 10.25.234.18 with SMTP id i18mr6015187lfh.65.1516893054915; Thu, 25 Jan 2018 07:10:54 -0800 (PST) Received: from rafalkozik.semihalf.local (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id x186sm1009867lfd.24.2018.01.25.07.10.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 25 Jan 2018 07:10:53 -0800 (PST) From: Rafal Kozik To: mk@semihalf.com Cc: Rafal Kozik , stable@dpdk.org Date: Thu, 25 Jan 2018 16:10:47 +0100 Message-Id: <1516893047-8193-1-git-send-email-rk@semihalf.com> X-Mailer: git-send-email 2.7.4 Subject: [dpdk-stable] [PATCH] net/ena: TX L4 offloads should not be set in RX path X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Jan 2018 15:10:55 -0000 Information about received packet type detected by NIC should be stored in packet_type field of rte_mbuf. TX L4 offload flags should not be set in RX path. Only fields that could be set in of_flags during packet receiving are information if L4 and L3 checksum is correct. Fixes: 1173fca25af9 ("ena: add polling-mode driver") Cc: stable@dpdk.org Reported-by: Matthew Smith Signed-off-by: Rafal Kozik --- drivers/net/ena/ena_ethdev.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index 83e0ae2..1e2af80 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -275,16 +275,17 @@ static inline void ena_rx_mbuf_prepare(struct rte_mbuf *mbuf, struct ena_com_rx_ctx *ena_rx_ctx) { uint64_t ol_flags = 0; + uint32_t packet_type = 0; if (ena_rx_ctx->l4_proto == ENA_ETH_IO_L4_PROTO_TCP) - ol_flags |= PKT_TX_TCP_CKSUM; + packet_type |= RTE_PTYPE_L4_TCP; else if (ena_rx_ctx->l4_proto == ENA_ETH_IO_L4_PROTO_UDP) - ol_flags |= PKT_TX_UDP_CKSUM; + packet_type |= RTE_PTYPE_L4_UDP; if (ena_rx_ctx->l3_proto == ENA_ETH_IO_L3_PROTO_IPV4) - ol_flags |= PKT_TX_IPV4; + packet_type |= RTE_PTYPE_L3_IPV4; else if (ena_rx_ctx->l3_proto == ENA_ETH_IO_L3_PROTO_IPV6) - ol_flags |= PKT_TX_IPV6; + packet_type |= RTE_PTYPE_L3_IPV6; if (unlikely(ena_rx_ctx->l4_csum_err)) ol_flags |= PKT_RX_L4_CKSUM_BAD; @@ -292,6 +293,7 @@ static inline void ena_rx_mbuf_prepare(struct rte_mbuf *mbuf, ol_flags |= PKT_RX_IP_CKSUM_BAD; mbuf->ol_flags = ol_flags; + mbuf->packet_type = packet_type; } static inline void ena_tx_mbuf_prepare(struct rte_mbuf *mbuf, -- 2.7.4