From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f65.google.com (mail-lf0-f65.google.com [209.85.215.65]) by dpdk.org (Postfix) with ESMTP id 0444AA49A for ; Thu, 25 Jan 2018 16:12:15 +0100 (CET) Received: by mail-lf0-f65.google.com with SMTP id a204so10216670lfa.2 for ; Thu, 25 Jan 2018 07:12:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=tL7Iiho1Sdc4Y1ZbePF9P70ClSaIb4SPvf83NxdDWBM=; b=QhdIhpN65M7mRtkWk9Uz69zjRqVdKqyem3qGeimfB569f6I1rjoZBmtK/Fag4yCKww oOPoD7nrVSd9Sq3Fh4JtThkno3j9x6f+RmsYBifsTnszHh5xj0ZR0jXH0dGAIhS7luh1 IAj9fByG/R5tfRmwcLScpqibc2rOR4Ec0fJHcizLJrIPkunzSgRBP0p3ah0CM3fZsNCu sR+B+owmF+Xxyz6UXvs3RNvk2CoY+pPqHHGD717PRy1ToehaXH6AZdGEoyBg2H950CSx aXIxpC0b44nAIsoQv/L4imtqwzJULuXXcJOiLqqpetk0AMVBvEi5GB800mH052+Umw1Q 6wAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=tL7Iiho1Sdc4Y1ZbePF9P70ClSaIb4SPvf83NxdDWBM=; b=sM2q3uB3PN6rnjW8V9WgV8ZXOjUDoRN0weQjKnsCV8aHg54chVFOUA2C2wRNwWTvqh YKc4W7od5Kusz29DU3SvGyMwngN+mdM3fNNX0YO54/poAaPIzGn5nriHzvHjPpHazJad bUQgKsHSle6BZxIGmL/OwBUcCBpq358AJst+x/rJOl7AUrXqfNXL+993W5HEb+4rNCsA LAonKHeKRlIajYe3epQ4CwmZHpjt/PT+menlqoMQ8IjcIvhiJx8k+xo70+HLo6yt2Dln AwDwNhPKH8zeVaZakBRn3FsJrctNk6hRJbcvufUsSapAzBK5hfe1Ob4v8L0jBi5xAprp 6WJQ== X-Gm-Message-State: AKwxytcqVQTxLLdP3hGF3czcG5JszIxlxVMe3PbXumTzhpfZAjJblkWp yR/doVYCO5XY6e6qm9NXc2CeVg== X-Google-Smtp-Source: AH8x226f5F0ROQMsN5vfJFBXgSPpxitpXTqDt3jvL+Ge0nMEBeGZrupzK8ILOn9k8RxYxUGoKBgnFA== X-Received: by 10.46.64.211 with SMTP id r80mr6210577lje.149.1516893135633; Thu, 25 Jan 2018 07:12:15 -0800 (PST) Received: from rafalkozik.semihalf.local (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id c123sm836096lfc.94.2018.01.25.07.12.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 25 Jan 2018 07:12:14 -0800 (PST) From: Rafal Kozik To: rk@semihalf.com Cc: stable@dpdk.org Date: Thu, 25 Jan 2018 16:12:12 +0100 Message-Id: <1516893132-8257-1-git-send-email-rk@semihalf.com> X-Mailer: git-send-email 2.7.4 Subject: [dpdk-stable] [PATCH] net/ena: TX L4 offloads should not be set in RX path X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Jan 2018 15:12:16 -0000 Information about received packet type detected by NIC should be stored in packet_type field of rte_mbuf. TX L4 offload flags should not be set in RX path. Only fields that could be set in of_flags during packet receiving are information if L4 and L3 checksum is correct. Fixes: 1173fca25af9 ("ena: add polling-mode driver") Cc: stable@dpdk.org Reported-by: Matthew Smith Signed-off-by: Rafal Kozik --- drivers/net/ena/ena_ethdev.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index 83e0ae2..1e2af80 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -275,16 +275,17 @@ static inline void ena_rx_mbuf_prepare(struct rte_mbuf *mbuf, struct ena_com_rx_ctx *ena_rx_ctx) { uint64_t ol_flags = 0; + uint32_t packet_type = 0; if (ena_rx_ctx->l4_proto == ENA_ETH_IO_L4_PROTO_TCP) - ol_flags |= PKT_TX_TCP_CKSUM; + packet_type |= RTE_PTYPE_L4_TCP; else if (ena_rx_ctx->l4_proto == ENA_ETH_IO_L4_PROTO_UDP) - ol_flags |= PKT_TX_UDP_CKSUM; + packet_type |= RTE_PTYPE_L4_UDP; if (ena_rx_ctx->l3_proto == ENA_ETH_IO_L3_PROTO_IPV4) - ol_flags |= PKT_TX_IPV4; + packet_type |= RTE_PTYPE_L3_IPV4; else if (ena_rx_ctx->l3_proto == ENA_ETH_IO_L3_PROTO_IPV6) - ol_flags |= PKT_TX_IPV6; + packet_type |= RTE_PTYPE_L3_IPV6; if (unlikely(ena_rx_ctx->l4_csum_err)) ol_flags |= PKT_RX_L4_CKSUM_BAD; @@ -292,6 +293,7 @@ static inline void ena_rx_mbuf_prepare(struct rte_mbuf *mbuf, ol_flags |= PKT_RX_IP_CKSUM_BAD; mbuf->ol_flags = ol_flags; + mbuf->packet_type = packet_type; } static inline void ena_tx_mbuf_prepare(struct rte_mbuf *mbuf, -- 2.7.4