From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f194.google.com (mail-wr0-f194.google.com [209.85.128.194]) by dpdk.org (Postfix) with ESMTP id 3B9BE1B1B9 for ; Fri, 26 Jan 2018 14:39:11 +0100 (CET) Received: by mail-wr0-f194.google.com with SMTP id g21so544791wrb.13 for ; Fri, 26 Jan 2018 05:39:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=HMKigkKzHd2PDkuYxYgIafNTK/dxvCzVWMpw/Li4lH4=; b=qOz1ALWMUlSBIOKuKhwmetktBlSdicDYpP01cQ9fsL3JA9lmytfYN3FmjPZoLAvbb/ kWkc1ga7zgScGsKz9+CcHNih1P4l/HC87dF2nrL8YuXftJOH206KmttNwlvpdIKhsrzo 5vO74RL6r3AQlKH58n1lHBdrUvGoU49cP8hyRdOR5TUk3L1ZIesLoiGzTG1ChbjGiqHN uwQynYmY6IeetKyYrtFiJHQNkBoySWmer/z7NeZGbY3nMdplHxi0LZUScLxREjOqL1Mp H3RteEGipCVJKh2jI1+CNoYZzFcdcGkwir/m1A9AsKJg1NbFu8uIfThMyQeJd8WFnvVz 3GCg== X-Gm-Message-State: AKwxytem2HFgwuK+TVai/LOljefXv6unVLrTHmscsy5LZb/wGZVUBkCA G8PgnAqsrV/7cuJnTeSlGgU9kczTfbs= X-Google-Smtp-Source: AH8x225zhWHpn4fuMUtk/HYw5ybUOFTbfr99O0T4Cg07qOfXWhewS01y+vRzmyHuIHtAR2SjHjgUxg== X-Received: by 10.223.186.129 with SMTP id p1mr11884227wrg.183.1516973950830; Fri, 26 Jan 2018 05:39:10 -0800 (PST) Received: from localhost ([2a00:23c5:bef3:400:9531:588b:44ae:bec4]) by smtp.gmail.com with ESMTPSA id p10sm11884488wrh.61.2018.01.26.05.39.10 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 26 Jan 2018 05:39:10 -0800 (PST) Message-ID: <1516973949.10752.3.camel@debian.org> From: Luca Boccassi To: Rafal Kozik Cc: stable@dpdk.org Date: Fri, 26 Jan 2018 13:39:09 +0000 In-Reply-To: <1516893132-8257-1-git-send-email-rk@semihalf.com> References: <1516893132-8257-1-git-send-email-rk@semihalf.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH] net/ena: TX L4 offloads should not be set in RX path X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jan 2018 13:39:11 -0000 On Thu, 2018-01-25 at 16:12 +0100, Rafal Kozik wrote: > Information about received packet type detected by NIC should be > stored in packet_type field of rte_mbuf. TX L4 offload flags should > not be set in RX path. Only fields that could be set in of_flags > during packet receiving are information if L4 and L3 checksum is > correct. >=20 > Fixes: 1173fca25af9 ("ena: add polling-mode driver") > Cc: stable@dpdk.org >=20 > Reported-by: Matthew Smith > Signed-off-by: Rafal Kozik > --- > =C2=A0drivers/net/ena/ena_ethdev.c | 10 ++++++---- > =C2=A01 file changed, 6 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/net/ena/ena_ethdev.c > b/drivers/net/ena/ena_ethdev.c > index 83e0ae2..1e2af80 100644 > --- a/drivers/net/ena/ena_ethdev.c > +++ b/drivers/net/ena/ena_ethdev.c > @@ -275,16 +275,17 @@ static inline void ena_rx_mbuf_prepare(struct > rte_mbuf *mbuf, > =C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0struct ena_com_rx_ctx > *ena_rx_ctx) > =C2=A0{ > =C2=A0 uint64_t ol_flags =3D 0; > + uint32_t packet_type =3D 0; > =C2=A0 > =C2=A0 if (ena_rx_ctx->l4_proto =3D=3D ENA_ETH_IO_L4_PROTO_TCP) > - ol_flags |=3D PKT_TX_TCP_CKSUM; > + packet_type |=3D RTE_PTYPE_L4_TCP; > =C2=A0 else if (ena_rx_ctx->l4_proto =3D=3D ENA_ETH_IO_L4_PROTO_UDP) > - ol_flags |=3D PKT_TX_UDP_CKSUM; > + packet_type |=3D RTE_PTYPE_L4_UDP; > =C2=A0 > =C2=A0 if (ena_rx_ctx->l3_proto =3D=3D ENA_ETH_IO_L3_PROTO_IPV4) > - ol_flags |=3D PKT_TX_IPV4; > + packet_type |=3D RTE_PTYPE_L3_IPV4; > =C2=A0 else if (ena_rx_ctx->l3_proto =3D=3D ENA_ETH_IO_L3_PROTO_IPV6) > - ol_flags |=3D PKT_TX_IPV6; > + packet_type |=3D RTE_PTYPE_L3_IPV6; > =C2=A0 > =C2=A0 if (unlikely(ena_rx_ctx->l4_csum_err)) > =C2=A0 ol_flags |=3D PKT_RX_L4_CKSUM_BAD; > @@ -292,6 +293,7 @@ static inline void ena_rx_mbuf_prepare(struct > rte_mbuf *mbuf, > =C2=A0 ol_flags |=3D PKT_RX_IP_CKSUM_BAD; > =C2=A0 > =C2=A0 mbuf->ol_flags =3D ol_flags; > + mbuf->packet_type =3D packet_type; > =C2=A0} > =C2=A0 > =C2=A0static inline void ena_tx_mbuf_prepare(struct rte_mbuf *mbuf, Hi, has a similar/related fix been applied to dpdk/master? --=20 Kind regards, Luca Boccassi