From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67]) by dpdk.org (Postfix) with ESMTP id 3FA7E1B1D4 for ; Fri, 26 Jan 2018 15:14:11 +0100 (CET) Received: by mail-wm0-f67.google.com with SMTP id r71so1552788wmd.1 for ; Fri, 26 Jan 2018 06:14:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=VQn5BwzvKKyNWjg++Me5H3tKshb3lpYwXQOJ/pG0tVg=; b=PYHCqh2HNfG1MKJgI+S7Y3eMGs4WC62tQ5acnDSO4PBslS1/5o9G81MtDxWmvOezSR s+xi7eIAU+U6PacipU+ZMBk0dc10yAXi9GTgEWYvnW/ThoDQ5OsTtw/N5u31J57K1kED vOef8d+PCPy3sHNdfxVgxVkiDqj9Gemz+pIy9QTD2jtV+d9rhC+RSqyFHl0QPkEA2K7M gUCuVwc6UjJO9kz7qEnl5GN5hPuPZ84haNANSIqq15DJKxDENLKj7BSz4OWRe9RKd55c B/DrAbV0VnYwHuHjOjEpC3jzGuo/hEmiztvQ/F5jvdQO+fbXveAIfH7M2vCzcOu1bQ84 3zuw== X-Gm-Message-State: AKwxytesTbS0KmGKHIRxwLa46ryr8kCUNO5jvf1LC+t36S/s+hIXx69d oagNw1BJmzNLODgZWBbIHys= X-Google-Smtp-Source: AH8x226Rxk2KNfTxEUl4oacrwP8dj9JVYB/7PvaGDyh+7Rq+bTMNdwxw20DEj+eI88mL7uaS670Mjg== X-Received: by 10.28.138.146 with SMTP id m140mr5070226wmd.85.1516976050908; Fri, 26 Jan 2018 06:14:10 -0800 (PST) Received: from localhost ([2a00:23c5:bef3:400:9531:588b:44ae:bec4]) by smtp.gmail.com with ESMTPSA id r76sm4380926wmf.0.2018.01.26.06.14.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 26 Jan 2018 06:14:10 -0800 (PST) Message-ID: <1516976048.10752.9.camel@debian.org> From: Luca Boccassi To: =?UTF-8?Q?Rafa=C5=82?= Kozik Cc: stable@dpdk.org Date: Fri, 26 Jan 2018 14:14:08 +0000 In-Reply-To: References: <1516893132-8257-1-git-send-email-rk@semihalf.com> <1516973949.10752.3.camel@debian.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH] net/ena: TX L4 offloads should not be set in RX path X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jan 2018 14:14:11 -0000 On Fri, 2018-01-26 at 14:51 +0100, Rafa=C5=82 Kozik wrote: > Hello, >=20 > I send this patch to stable list by mistake. I misunderstood git-send > configuration. > Currently this patch is under review on dpdk-dev list > http://dpdk.org/ml/archives/dev/2018-January/089053.html. >=20 > I am very sorry about the trouble I caused, I assure you that it will > never happen again. >=20 > Kind regards, > Rafal Kozik Don't worry, it's no trouble at all. Given it applies to older releases as well, keep stable in the CC list so that when it gets merged we can backport it. > 2018-01-26 14:39 GMT+01:00 Luca Boccassi : > > On Thu, 2018-01-25 at 16:12 +0100, Rafal Kozik wrote: > > > Information about received packet type detected by NIC should be > > > stored in packet_type field of rte_mbuf. TX L4 offload flags > > > should > > > not be set in RX path. Only fields that could be set in of_flags > > > during packet receiving are information if L4 and L3 checksum is > > > correct. > > >=20 > > > Fixes: 1173fca25af9 ("ena: add polling-mode driver") > > > Cc: stable@dpdk.org > > >=20 > > > Reported-by: Matthew Smith > > > Signed-off-by: Rafal Kozik > > > --- > > > =C2=A0drivers/net/ena/ena_ethdev.c | 10 ++++++---- > > > =C2=A01 file changed, 6 insertions(+), 4 deletions(-) > > >=20 > > > diff --git a/drivers/net/ena/ena_ethdev.c > > > b/drivers/net/ena/ena_ethdev.c > > > index 83e0ae2..1e2af80 100644 > > > --- a/drivers/net/ena/ena_ethdev.c > > > +++ b/drivers/net/ena/ena_ethdev.c > > > @@ -275,16 +275,17 @@ static inline void > > > ena_rx_mbuf_prepare(struct > > > rte_mbuf *mbuf, > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0struct ena_com_rx_ctx > > > *ena_rx_ctx) > > > =C2=A0{ > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0uint64_t ol_flags =3D 0; > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0uint32_t packet_type =3D 0; > > >=20 > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if (ena_rx_ctx->l4_proto =3D=3D E= NA_ETH_IO_L4_PROTO_TCP) > > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0ol_flags |=3D PKT_TX_TCP_CKSUM; > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0packet_type |=3D RTE_PTYPE_L4_TCP; > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0else if (ena_rx_ctx->l4_proto =3D= =3D ENA_ETH_IO_L4_PROTO_UDP) > > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0ol_flags |=3D PKT_TX_UDP_CKSUM; > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0packet_type |=3D RTE_PTYPE_L4_UDP; > > >=20 > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if (ena_rx_ctx->l3_proto =3D=3D E= NA_ETH_IO_L3_PROTO_IPV4) > > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0ol_flags |=3D PKT_TX_IPV4; > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0packet_type |=3D RTE_PTYPE_L3_IPV4; > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0else if (ena_rx_ctx->l3_proto =3D= =3D ENA_ETH_IO_L3_PROTO_IPV6) > > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0ol_flags |=3D PKT_TX_IPV6; > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0packet_type |=3D RTE_PTYPE_L3_IPV6; > > >=20 > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if (unlikely(ena_rx_ctx->l4_csum_= err)) > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0ol_flags |=3D PKT_RX_L4_CKSUM_BAD; > > > @@ -292,6 +293,7 @@ static inline void ena_rx_mbuf_prepare(struct > > > rte_mbuf *mbuf, > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0ol_flags |=3D PKT_RX_IP_CKSUM_BAD; > > >=20 > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0mbuf->ol_flags =3D ol_flags; > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0mbuf->packet_type =3D packet_type; > > > =C2=A0} > > >=20 > > > =C2=A0static inline void ena_tx_mbuf_prepare(struct rte_mbuf *mbuf, > >=20 > > Hi, > >=20 > > has a similar/related fix been applied to dpdk/master? > >=20 > > -- > > Kind regards, > > Luca Boccassi --=20 Kind regards, Luca Boccassi