From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 3C5DA325F for ; Thu, 1 Feb 2018 10:48:34 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id E90E3202F7; Thu, 1 Feb 2018 04:48:33 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Thu, 01 Feb 2018 04:48:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=rmk8bjUkAwTJS11PN yphAhHE92J/Fqpbz2q7FPvsDrE=; b=BYsII9CQqOIEKzPWvo5WoLkozuc1p2Y6L kxZq6ia3CZa69osH5FuIfeN3cuqzNAaU6XJht70ogY2IO0Ofp86CZRYTIZuuTLQL /AFUX90S81XqSVG9lCMH0oxAPS/mM0HeAMBHvd2mv7QJ4U1bGQoegtlRMSyKLiD+ eC8pXrpXibaztYmtScwBcMXJxXBezHRwyi1AIaQV4oFLwKaY6ctKHdPqBzOo4CKj HBu5DhHFbzhPQLNKbZ1JbvbRSsYD6lWMCWBbQdwnnZ+SAanFGmKeI89Z2vW6HpYG sshLTTYwy3mjHDVHJmDwxpv8lhjgXITHpAadNndnopd5ExgSgan/w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=rmk8bjUkAwTJS11PNyphAhHE92J/Fqpbz2q7FPvsDrE=; b=BWS80/8U o5OXgA85TinZVN7WRsgE7Oha9zjwHrJCHIGY8aE/HYgOYFvcqVubhy3GCebezQmZ DksdPK7TNjmw6TDo3nRdIFjyDXVLEdkV0+wal/GY+inANDjck3T8Qwsem3JVV1i7 Qg/mXLIB9mWxp1/H92d9E/0jQnSlsRTRFAA7wsAgH3TqfxnWmxJwWsK1yIoeNKZF WKWfYaxC2K6romGLpuM45S1RN+2lTbu8QYjxcMpdhGM/fDNSR9LCieLPYLxKhYf9 WPSVMupK+IHWF6MukMDtzj7Fp+/Nca0/dgfOFb69H83KG6ETCcAZXXLzyO00YIlk 9s70PuXaIzn8tQ== X-ME-Sender: Received: from yliu-mob.mtl.com (unknown [115.150.27.200]) by mail.messagingengine.com (Postfix) with ESMTPA id B36E1245F1; Thu, 1 Feb 2018 04:48:31 -0500 (EST) From: Yuanhan Liu To: Fiona Trahe Cc: Radu Nicolau , dpdk stable Date: Thu, 1 Feb 2018 17:47:26 +0800 Message-Id: <1517478479-12417-12-git-send-email-yliu@fridaylinux.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1517478479-12417-1-git-send-email-yliu@fridaylinux.org> References: <1517478479-12417-1-git-send-email-yliu@fridaylinux.org> Subject: [dpdk-stable] patch 'crypto/qat: fix null auth algo overwrite' has been queued to LTS release 17.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Feb 2018 09:48:34 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/03/18. So please shout if anyone has objections. Thanks. --yliu --- >>From a50d7a400b50f569b08295cd4eece503502aab94 Mon Sep 17 00:00:00 2001 From: Fiona Trahe Date: Thu, 25 Jan 2018 17:19:14 +0000 Subject: [PATCH] crypto/qat: fix null auth algo overwrite [ upstream commit 4e0955bddb0880949fb12de3a1a8f07eb9ace832 ] If auth algorithm is RTE_CRYPTO_AUTH_NULL and digest_length is 0 in the xform and digest pointer is set in the op, then the PMD may overwrite memory at the digest pointer. With this patch the memory is not overwritten. Fixes: db0e952a5c01 ("crypto/qat: add NULL capability") Signed-off-by: Fiona Trahe Acked-by: Radu Nicolau --- drivers/crypto/qat/qat_crypto.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/qat/qat_crypto.c b/drivers/crypto/qat/qat_crypto.c index 8629595..acd979d 100644 --- a/drivers/crypto/qat/qat_crypto.c +++ b/drivers/crypto/qat/qat_crypto.c @@ -1371,7 +1371,9 @@ qat_write_hw_desc_entry(struct rte_crypto_op *op, uint8_t *out_msg, } min_ofs = auth_ofs; - auth_param->auth_res_addr = op->sym->auth.digest.phys_addr; + if (likely(ctx->qat_hash_alg != ICP_QAT_HW_AUTH_ALGO_NULL)) + auth_param->auth_res_addr = + op->sym->auth.digest.phys_addr; } -- 2.7.4