From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66]) by dpdk.org (Postfix) with ESMTP id 2A4D21B7CF for ; Thu, 8 Feb 2018 15:13:38 +0100 (CET) Received: by mail-wm0-f66.google.com with SMTP id i186so9725259wmi.4 for ; Thu, 08 Feb 2018 06:13:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=3cr8kxSfTri/sU+cCA4DhHp9xNkmskoLEotW/Z6iZJg=; b=iiZJA8XlJbb293Cq61sY1//x1PQ8h2C0FTKwVmxCgDBNaaJDXcTTyZIkI/ODI5jerL JsBtYNgjKE7qH/1IX8Dog9SxHatKfMULI2YgdjGxqQ3Yj5KRhEokmLJfHKqgFtwib1mn V8jVyXJlTva1YGxXd9hBBbIVOAY12Hd4i/Mmw7dnEOHEPcVcxvfIzN/eV/U0mXLlpE2n J6W+I/2lOWuLpOWmtbeLuGscIt2dZm/RphYDpK5r30J/Q+aJPMD6aNzMvZUv2KaCS3GE D8yanyxswgp9M4MSweCAwAiw9WjHd5p49fXoYLnRz5q+zOP74HAnnAZICNBkTrBZjUIx eNjg== X-Gm-Message-State: APf1xPDZCwWpEpvaPu1beIoF1CdBn19pn3uwoKLzc9VRl9WXvh32YzEA 8BRPQ+5WAsaZBt1LFX2WzL4= X-Google-Smtp-Source: AH8x227LKoGwFZEf8UjLS19qgLB2n2IKXHVEEo11bOJRYVBfB3SLPciOLXIgSxeSZYqZyqI00Rd7wg== X-Received: by 10.28.94.12 with SMTP id s12mr1115431wmb.155.1518099217854; Thu, 08 Feb 2018 06:13:37 -0800 (PST) Received: from localhost ([213.251.34.146]) by smtp.gmail.com with ESMTPSA id x19sm108084wrd.7.2018.02.08.06.13.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 08 Feb 2018 06:13:36 -0800 (PST) Message-ID: <1518099215.15424.56.camel@debian.org> From: Luca Boccassi To: Yong Wang , stable@dpdk.org Date: Thu, 08 Feb 2018 14:13:35 +0000 In-Reply-To: <1518090548-8984-1-git-send-email-wang.yong19@zte.com.cn> References: <1518090548-8984-1-git-send-email-wang.yong19@zte.com.cn> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH] crypto/qat: fix allocation check and leak X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Feb 2018 14:13:38 -0000 On Thu, 2018-02-08 at 06:49 -0500, Yong Wang wrote: > [ backported from upstream commit > 963898f0e316611df9dc2964d059b4e16835b95a ] >=20 > There are several func calls to rte_zmalloc() which don't do null > point check on the return value. Fix it by adding null point check. >=20 > Fixes: 1703e94ac5ce ("qat: add driver for QuickAssist devices") > Cc: stable@dpdk.org >=20 > Signed-off-by: Yong Wang > Acked-by: Fiona Trahe > Acked-by: Ferruh Yigit > --- > =C2=A0drivers/crypto/qat/qat_adf/qat_algs_build_desc.c | 10 ++++++++++ > =C2=A01 file changed, 10 insertions(+) >=20 > diff --git a/drivers/crypto/qat/qat_adf/qat_algs_build_desc.c > b/drivers/crypto/qat/qat_adf/qat_algs_build_desc.c > index 1c4b184..ac9d822 100644 > --- a/drivers/crypto/qat/qat_adf/qat_algs_build_desc.c > +++ b/drivers/crypto/qat/qat_adf/qat_algs_build_desc.c > @@ -334,6 +334,11 @@ static int qat_alg_do_precomputes(enum > icp_qat_hw_auth_algo hash_alg, > =C2=A0 > =C2=A0 in =3D rte_zmalloc("working mem for key", > =C2=A0 ICP_QAT_HW_AES_XCBC_MAC_STATE2_SZ, > 16); > + if (in =3D=3D NULL) { > + PMD_DRV_LOG(ERR, "Failed to alloc memory"); > + return -ENOMEM; > + } > + > =C2=A0 rte_memcpy(in, qat_aes_xcbc_key_seed, > =C2=A0 ICP_QAT_HW_AES_XCBC_MAC_STATE2_SZ); > =C2=A0 for (x =3D 0; x < HASH_XCBC_PRECOMP_KEY_NUM; x++) { > @@ -364,6 +369,11 @@ static int qat_alg_do_precomputes(enum > icp_qat_hw_auth_algo hash_alg, > =C2=A0 ICP_QAT_HW_GALOIS_E_CTR0_SZ); > =C2=A0 in =3D rte_zmalloc("working mem for key", > =C2=A0 ICP_QAT_HW_GALOIS_H_SZ, 16); > + if (in =3D=3D NULL) { > + PMD_DRV_LOG(ERR, "Failed to alloc memory"); > + return -ENOMEM; > + } > + > =C2=A0 memset(in, 0, ICP_QAT_HW_GALOIS_H_SZ); > =C2=A0 if (AES_set_encrypt_key(auth_key, auth_keylen << 3, > =C2=A0 &enc_key) !=3D 0) { Applied to dpdk-stable/16.11 (will be pushed soon), thanks. --=20 Kind regards, Luca Boccassi