* [dpdk-stable] patch 'net/tap: fix cleanup on allocation failure' has been queued to LTS release 17.11.1
@ 2018-02-11 4:02 Yuanhan Liu
2018-02-11 4:02 ` [dpdk-stable] patch 'net/bnxt: fix Rx checksum flags' " Yuanhan Liu
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Yuanhan Liu @ 2018-02-11 4:02 UTC (permalink / raw)
To: Moti Haimovsky; +Cc: Pascal Mazon, dpdk stable
Hi,
FYI, your patch has been queued to LTS release 17.11.1
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/13/18. So please
shout if anyone has objections.
Thanks.
--yliu
---
>From 344d489593d878837c45815ba5b8cf3ef5689826 Mon Sep 17 00:00:00 2001
From: Moti Haimovsky <motih@mellanox.com>
Date: Mon, 5 Feb 2018 18:17:20 +0200
Subject: [PATCH] net/tap: fix cleanup on allocation failure
[ upstream commit cb7e68da630abe7bb7b69885cc2a1a8e6d705943 ]
This patch complements the partial cleanup done inside
eth_dev_tap_create when the routine failed.
Such a failure left a non-functional device attached to the system.
Fixes: 050fe6e9ff97 ("drivers/net: use ethdev allocation helper for vdev")
Signed-off-by: Moti Haimovsky <motih@mellanox.com>
Acked-by: Pascal Mazon <pascal.mazon@6wind.com>
---
drivers/net/tap/rte_eth_tap.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index 036028f..b8187f9 100644
--- a/drivers/net/tap/rte_eth_tap.c
+++ b/drivers/net/tap/rte_eth_tap.c
@@ -1240,13 +1240,13 @@ eth_dev_tap_create(struct rte_vdev_device *vdev, char *tap_name,
data = rte_zmalloc_socket(tap_name, sizeof(*data), 0, numa_node);
if (!data) {
RTE_LOG(ERR, PMD, "TAP Failed to allocate data\n");
- goto error_exit;
+ goto error_exit_nodev;
}
dev = rte_eth_vdev_allocate(vdev, sizeof(*pmd));
if (!dev) {
RTE_LOG(ERR, PMD, "TAP Unable to allocate device struct\n");
- goto error_exit;
+ goto error_exit_nodev;
}
pmd = dev->data->dev_private;
@@ -1416,6 +1416,11 @@ error_remote:
tap_flow_implicit_flush(pmd, NULL);
error_exit:
+ if (pmd->ioctl_sock > 0)
+ close(pmd->ioctl_sock);
+ rte_eth_dev_release_port(dev);
+
+error_exit_nodev:
RTE_LOG(ERR, PMD, "TAP Unable to initialize %s\n",
rte_vdev_device_name(vdev));
--
2.7.4
^ permalink raw reply [flat|nested] 5+ messages in thread
* [dpdk-stable] patch 'net/bnxt: fix Rx checksum flags' has been queued to LTS release 17.11.1
2018-02-11 4:02 [dpdk-stable] patch 'net/tap: fix cleanup on allocation failure' has been queued to LTS release 17.11.1 Yuanhan Liu
@ 2018-02-11 4:02 ` Yuanhan Liu
2018-02-11 4:02 ` [dpdk-stable] patch 'net/bnxt: fix return code in MAC address set' " Yuanhan Liu
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Yuanhan Liu @ 2018-02-11 4:02 UTC (permalink / raw)
To: Olivier Matz; +Cc: Ajit Khaparde, dpdk stable
Hi,
FYI, your patch has been queued to LTS release 17.11.1
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/13/18. So please
shout if anyone has objections.
Thanks.
--yliu
---
>From 8c22fe7eb1ddbfea570c5fcfa6f60c847817d988 Mon Sep 17 00:00:00 2001
From: Olivier Matz <olivier.matz@6wind.com>
Date: Tue, 6 Feb 2018 14:39:31 +0100
Subject: [PATCH] net/bnxt: fix Rx checksum flags
[ upstream commit 0fc49cbb2cab782bf44e1a29e7c8e1c22af576c8 ]
Fix the Rx offload flags when the IP or L4 checksum is seen as incorrect
by the hardware. In this case, the proper value is PKT_RX_IP_CKSUM_BAD.
PKT_RX_IP_CKSUM_NONE means that the checksum may be incorrect in the
packet headers, but the integrity of the IP header is verified. This is
mostly useful for virtual drivers.
Fixes: 7ec39d8c524b ("net/bnxt: update status of Rx IP/L4 CKSUM")
Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
---
drivers/net/bnxt/bnxt_rxr.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c
index 30891b7..5128335 100644
--- a/drivers/net/bnxt/bnxt_rxr.c
+++ b/drivers/net/bnxt/bnxt_rxr.c
@@ -470,12 +470,12 @@ static int bnxt_rx_pkt(struct rte_mbuf **rx_pkt,
if (likely(RX_CMP_IP_CS_OK(rxcmp1)))
mbuf->ol_flags |= PKT_RX_IP_CKSUM_GOOD;
else
- mbuf->ol_flags |= PKT_RX_IP_CKSUM_NONE;
+ mbuf->ol_flags |= PKT_RX_IP_CKSUM_BAD;
if (likely(RX_CMP_L4_CS_OK(rxcmp1)))
mbuf->ol_flags |= PKT_RX_L4_CKSUM_GOOD;
else
- mbuf->ol_flags |= PKT_RX_L4_CKSUM_NONE;
+ mbuf->ol_flags |= PKT_RX_L4_CKSUM_BAD;
mbuf->packet_type = bnxt_parse_pkt_type(rxcmp, rxcmp1);
--
2.7.4
^ permalink raw reply [flat|nested] 5+ messages in thread
* [dpdk-stable] patch 'net/bnxt: fix return code in MAC address set' has been queued to LTS release 17.11.1
2018-02-11 4:02 [dpdk-stable] patch 'net/tap: fix cleanup on allocation failure' has been queued to LTS release 17.11.1 Yuanhan Liu
2018-02-11 4:02 ` [dpdk-stable] patch 'net/bnxt: fix Rx checksum flags' " Yuanhan Liu
@ 2018-02-11 4:02 ` Yuanhan Liu
2018-02-11 4:02 ` [dpdk-stable] patch 'net/i40e: check multi-driver option parsing' " Yuanhan Liu
2018-02-11 4:02 ` [dpdk-stable] patch 'app/testpmd: fix flow director filter' " Yuanhan Liu
3 siblings, 0 replies; 5+ messages in thread
From: Yuanhan Liu @ 2018-02-11 4:02 UTC (permalink / raw)
To: Ajit Khaparde; +Cc: dpdk stable
Hi,
FYI, your patch has been queued to LTS release 17.11.1
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/13/18. So please
shout if anyone has objections.
Thanks.
--yliu
---
>From ea61f8e30c1826c8a5cd49a04afe3d49017edf8d Mon Sep 17 00:00:00 2001
From: Ajit Khaparde <ajit.khaparde@broadcom.com>
Date: Tue, 6 Feb 2018 17:16:16 -0800
Subject: [PATCH] net/bnxt: fix return code in MAC address set
[ upstream commit a6411929a56dce97770ed95ff14855649160e2bc ]
There is no need to return an error if an existing MAC is added.
Fixes: 778b759ba10e ("net/bnxt: add MAC address")
Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
---
drivers/net/bnxt/bnxt_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index 99242c4..3eeca6f 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -716,7 +716,7 @@ static int bnxt_mac_addr_add_op(struct rte_eth_dev *eth_dev,
if (filter->mac_index == index) {
RTE_LOG(ERR, PMD,
"MAC addr already existed for pool %d\n", pool);
- return -EINVAL;
+ return 0;
}
}
filter = bnxt_alloc_filter(bp);
--
2.7.4
^ permalink raw reply [flat|nested] 5+ messages in thread
* [dpdk-stable] patch 'net/i40e: check multi-driver option parsing' has been queued to LTS release 17.11.1
2018-02-11 4:02 [dpdk-stable] patch 'net/tap: fix cleanup on allocation failure' has been queued to LTS release 17.11.1 Yuanhan Liu
2018-02-11 4:02 ` [dpdk-stable] patch 'net/bnxt: fix Rx checksum flags' " Yuanhan Liu
2018-02-11 4:02 ` [dpdk-stable] patch 'net/bnxt: fix return code in MAC address set' " Yuanhan Liu
@ 2018-02-11 4:02 ` Yuanhan Liu
2018-02-11 4:02 ` [dpdk-stable] patch 'app/testpmd: fix flow director filter' " Yuanhan Liu
3 siblings, 0 replies; 5+ messages in thread
From: Yuanhan Liu @ 2018-02-11 4:02 UTC (permalink / raw)
To: Beilei Xing; +Cc: John McNamara, Jingjing Wu, Helin Zhang, dpdk stable
Hi,
FYI, your patch has been queued to LTS release 17.11.1
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/13/18. So please
shout if anyone has objections.
Thanks.
--yliu
---
>From c771a07722fbe6f3b8cdce73cf87fd1c86cf81ed Mon Sep 17 00:00:00 2001
From: Beilei Xing <beilei.xing@intel.com>
Date: Thu, 8 Feb 2018 21:18:12 +0800
Subject: [PATCH] net/i40e: check multi-driver option parsing
[ upstream commit 7469a495aec98082bcd4219cf7a25c6c3867c11a ]
This patch fixes the coverity CHECKED_RETURN issue.
Coverity issue: 261779
Fixes: cfdfca493cae ("net/i40e: fix multiple driver support")
Reported-by: John McNamara <john.mcnamara@intel.com>
Signed-off-by: Beilei Xing <beilei.xing@intel.com>
Acked-by: Jingjing Wu <jingjing.wu@intel.com>
Acked-by: Helin Zhang <helin.zhang@intel.com>
---
drivers/net/i40e/i40e_ethdev.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index b6ee8d1..290ef24 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -1148,8 +1148,12 @@ i40e_support_multi_driver(struct rte_eth_dev *dev)
"the first invalid or last valid one is used !",
ETH_I40E_SUPPORT_MULTI_DRIVER);
- rte_kvargs_process(kvlist, ETH_I40E_SUPPORT_MULTI_DRIVER,
- i40e_parse_multi_drv_handler, pf);
+ if (rte_kvargs_process(kvlist, ETH_I40E_SUPPORT_MULTI_DRIVER,
+ i40e_parse_multi_drv_handler, pf) < 0) {
+ rte_kvargs_free(kvlist);
+ return -EINVAL;
+ }
+
rte_kvargs_free(kvlist);
return 0;
}
--
2.7.4
^ permalink raw reply [flat|nested] 5+ messages in thread
* [dpdk-stable] patch 'app/testpmd: fix flow director filter' has been queued to LTS release 17.11.1
2018-02-11 4:02 [dpdk-stable] patch 'net/tap: fix cleanup on allocation failure' has been queued to LTS release 17.11.1 Yuanhan Liu
` (2 preceding siblings ...)
2018-02-11 4:02 ` [dpdk-stable] patch 'net/i40e: check multi-driver option parsing' " Yuanhan Liu
@ 2018-02-11 4:02 ` Yuanhan Liu
3 siblings, 0 replies; 5+ messages in thread
From: Yuanhan Liu @ 2018-02-11 4:02 UTC (permalink / raw)
To: Beilei Xing; +Cc: Jingjing Wu, dpdk stable
Hi,
FYI, your patch has been queued to LTS release 17.11.1
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/13/18. So please
shout if anyone has objections.
Thanks.
--yliu
---
>From b7fc71592739fe18d0e5cb688cc45a07cb09d2a2 Mon Sep 17 00:00:00 2001
From: Beilei Xing <beilei.xing@intel.com>
Date: Thu, 8 Feb 2018 20:35:40 +0800
Subject: [PATCH] app/testpmd: fix flow director filter
[ upstream commit 0abd847be0d146a022b5bb46e4f53d7adaf64c64 ]
This patch fixes issue during dealing with flow
director filter.
Fixes: 6c684f579df5 ("app/testpmd: add or delete flow director filter")
Signed-off-by: Beilei Xing <beilei.xing@intel.com>
Acked-by: Jingjing Wu <jingjing.wu@intel.com>
---
app/test-pmd/cmdline.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 8979627..b3c3f24 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -9751,11 +9751,11 @@ struct cmd_flow_director_result {
uint16_t port_dst;
cmdline_fixed_string_t verify_tag;
uint32_t verify_tag_value;
- cmdline_ipaddr_t tos;
+ cmdline_fixed_string_t tos;
uint8_t tos_value;
- cmdline_ipaddr_t proto;
+ cmdline_fixed_string_t proto;
uint8_t proto_value;
- cmdline_ipaddr_t ttl;
+ cmdline_fixed_string_t ttl;
uint8_t ttl_value;
cmdline_fixed_string_t vlan;
uint16_t vlan_value;
@@ -10302,7 +10302,7 @@ cmdline_parse_inst_t cmd_add_del_sctp_flow_director = {
(void *)&cmd_flow_director_flow_type,
(void *)&cmd_flow_director_src,
(void *)&cmd_flow_director_ip_src,
- (void *)&cmd_flow_director_port_dst,
+ (void *)&cmd_flow_director_port_src,
(void *)&cmd_flow_director_dst,
(void *)&cmd_flow_director_ip_dst,
(void *)&cmd_flow_director_port_dst,
--
2.7.4
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-02-11 4:03 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-11 4:02 [dpdk-stable] patch 'net/tap: fix cleanup on allocation failure' has been queued to LTS release 17.11.1 Yuanhan Liu
2018-02-11 4:02 ` [dpdk-stable] patch 'net/bnxt: fix Rx checksum flags' " Yuanhan Liu
2018-02-11 4:02 ` [dpdk-stable] patch 'net/bnxt: fix return code in MAC address set' " Yuanhan Liu
2018-02-11 4:02 ` [dpdk-stable] patch 'net/i40e: check multi-driver option parsing' " Yuanhan Liu
2018-02-11 4:02 ` [dpdk-stable] patch 'app/testpmd: fix flow director filter' " Yuanhan Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).