Re: [dpdk-stable] [PATCH] net/mlx5: fix handling link status event

[Luca Boccassi <bluca@debian.org>]

On Mon, 2018-02-12 at 23:39 +0000, Yongseok Koh wrote:
> > On Feb 12, 2018, at 10:31 AM, Luca Boccassi <bluca@debian.org>
> > wrote:
> > 
> > On Mon, 2018-02-12 at 10:20 -0800, Yongseok Koh wrote:
> > > [ backported from upstream commit c7bf62255edf ]
> > > 
> > > Even though link of a port gets down, device still can receive
> > > traffic.
> > > That is the reason why mlx5_set_link_up/down() switches
> > > rx/tx_pkt_burst().
> > > However, if link gets down by an external command (e.g.
> > > ifconfig), it
> > > isn't
> > > effective. It is better to change burst functions when link
> > > status
> > > change
> > > is detected.
> > > 
> > > Fixes: 62072098b54e ("mlx5: support setting link up or down")
> > > Cc: stable@dpdk.org
> > > 
> > > Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
> > > Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> > > ---
> > >  drivers/net/mlx5/mlx5.c         |   1 -
> > >  drivers/net/mlx5/mlx5.h         |   1 +
> > >  drivers/net/mlx5/mlx5_ethdev.c  | 118
> > > ++++++++++++++++++++++++++++++----------
> > >  drivers/net/mlx5/mlx5_trigger.c |  23 ++------
> > >  4 files changed, 95 insertions(+), 48 deletions(-)
> > 
> > Hi,
> > 
> > 62072098b54e ("mlx5: support setting link up or down") is in 16.11,
> > but
> > this patch does not apply cleanly. Should it be backported to
> > 16.11? If
> > so, could you please take care of it?
> 
> Thank you for the email.
> But, like I answered in the other email to you, you can drop this
> patch
> because there're some missing APIs in 16.11. And it isn't a critical
> bug.
> 
> Yongseok

Gah sorry - too many patches to remember, I should have checked the
list before asking :-)

-- 
Kind regards,
Luca Boccassi